Do not check getPolyHeight status

It may fail in some cases depending on a platform without obvious reason.

CHANGELOG.md

@@ -8,6 +8,7 @@
     Bug #5977: Fatigueless NPCs' corpse underwater changes animation on game load
     Bug #6939: OpenMW-CS: ID columns are too short
     Bug #6949: Sun Damage effect doesn't work in quasi exteriors
+    Bug #6964: Nerasa Dralor Won't Follow
     Feature #6945: Support S3TC-compressed and BGR/BGRA NiPixelData
 
 0.48.0

apps/openmw/mwlua/luabindings.cpp

@@ -52,7 +52,7 @@ namespace MWLua
     {
         auto* lua = context.mLua;
         sol::table api(lua->sol(), sol::create);
-        api["API_REVISION"] = 29;
+        api["API_REVISION"] = 30;
         api["quit"] = [lua]()
         {
             Log(Debug::Warning) << "Quit requested by a Lua script.\n" << lua->debugTraceback();

apps/openmw/mwlua/nearbybindings.cpp

@@ -150,7 +150,6 @@ namespace MWLua
                 {"EndPolygonNotFound", DetourNavigator::Status::EndPolygonNotFound},
                 {"MoveAlongSurfaceFailed", DetourNavigator::Status::MoveAlongSurfaceFailed},
                 {"FindPathOverPolygonsFailed", DetourNavigator::Status::FindPathOverPolygonsFailed},
-                {"GetPolyHeightFailed", DetourNavigator::Status::GetPolyHeightFailed},
                 {"InitNavMeshQueryFailed", DetourNavigator::Status::InitNavMeshQueryFailed},
             }));
 

components/detournavigator/debug.cpp

@@ -38,7 +38,6 @@ namespace DetourNavigator
             OPENMW_COMPONENTS_DETOURNAVIGATOR_DEBUG_STATUS_MESSAGE(EndPolygonNotFound)
             OPENMW_COMPONENTS_DETOURNAVIGATOR_DEBUG_STATUS_MESSAGE(MoveAlongSurfaceFailed)
             OPENMW_COMPONENTS_DETOURNAVIGATOR_DEBUG_STATUS_MESSAGE(FindPathOverPolygonsFailed)
-            OPENMW_COMPONENTS_DETOURNAVIGATOR_DEBUG_STATUS_MESSAGE(GetPolyHeightFailed)
             OPENMW_COMPONENTS_DETOURNAVIGATOR_DEBUG_STATUS_MESSAGE(InitNavMeshQueryFailed)
         }
 #undef OPENMW_COMPONENTS_DETOURNAVIGATOR_DEBUG_STATUS_MESSAGE

components/detournavigator/findsmoothpath.hpp

@@ -239,8 +239,7 @@ namespace DetourNavigator
                 }
             }
 
-            if (dtStatusFailed(navMeshQuery.getPolyHeight(polyRef, polyPos.ptr(), &iterPos.y())))
-                return Status::GetPolyHeightFailed;
+            navMeshQuery.getPolyHeight(polyRef, polyPos.ptr(), &iterPos.y());
             iterPos.x() = result->mResultPos.x();
             iterPos.z() = result->mResultPos.z();
 

components/detournavigator/status.hpp

@@ -12,7 +12,6 @@ namespace DetourNavigator
         EndPolygonNotFound,
         MoveAlongSurfaceFailed,
         FindPathOverPolygonsFailed,
-        GetPolyHeightFailed,
         InitNavMeshQueryFailed,
     };
 
@@ -34,8 +33,6 @@ namespace DetourNavigator
                 return "move along surface on navmesh is failed";
             case Status::FindPathOverPolygonsFailed:
                 return "path over navmesh polygons is not found";
-            case Status::GetPolyHeightFailed:
-                return "failed to get polygon height";
             case Status::InitNavMeshQueryFailed:
                 return "failed to init navmesh query";
         }

files/lua_api/openmw/nearby.lua

@@ -121,8 +121,6 @@
 -- algorithm implementation or bad navigation mesh data;
 -- @field [parent=#FIND_PATH_STATUS] #number FindPathOverPolygonsFailed Path over navigation mesh from `source` to
 -- `destination` does not exist or navigation mesh is not fully generated to provide the path;
--- @field [parent=#FIND_PATH_STATUS] #number GetPolyHeightFailed Found path couldn't be smoothed due to imperfect
--- algorithm implementation or bad navigation mesh data;
 -- @field [parent=#FIND_PATH_STATUS] #number InitNavMeshQueryFailed Couldn't initialize required data due to bad input
 -- or bad navigation mesh data.