Do not make redundant copies

pull/3236/head
Andrei Kortunov 4 months ago
parent f456978cc3
commit b620b9b239

@ -47,18 +47,18 @@ namespace MWLua
{ "Closing", MWWorld::DoorState::Closing }, { "Closing", MWWorld::DoorState::Closing },
})); }));
door["getDoorState"] = [](const Object& o) -> MWWorld::DoorState { door["getDoorState"] = [](const Object& o) -> MWWorld::DoorState {
auto door = doorPtr(o); const MWWorld::Ptr& door = doorPtr(o);
return door.getClass().getDoorState(door); return door.getClass().getDoorState(door);
}; };
door["isOpen"] = [](const Object& o) { door["isOpen"] = [](const Object& o) {
auto door = doorPtr(o); const MWWorld::Ptr& door = doorPtr(o);
bool doorIsIdle = door.getClass().getDoorState(door) == MWWorld::DoorState::Idle; bool doorIsIdle = door.getClass().getDoorState(door) == MWWorld::DoorState::Idle;
bool doorIsOpen = door.getRefData().getPosition().rot[2] != door.getCellRef().getPosition().rot[2]; bool doorIsOpen = door.getRefData().getPosition().rot[2] != door.getCellRef().getPosition().rot[2];
return doorIsIdle && doorIsOpen; return doorIsIdle && doorIsOpen;
}; };
door["isClosed"] = [](const Object& o) { door["isClosed"] = [](const Object& o) {
auto door = doorPtr(o); const MWWorld::Ptr& door = doorPtr(o);
bool doorIsIdle = door.getClass().getDoorState(door) == MWWorld::DoorState::Idle; bool doorIsIdle = door.getClass().getDoorState(door) == MWWorld::DoorState::Idle;
bool doorIsOpen = door.getRefData().getPosition().rot[2] != door.getCellRef().getPosition().rot[2]; bool doorIsOpen = door.getRefData().getPosition().rot[2] != door.getCellRef().getPosition().rot[2];
@ -70,7 +70,7 @@ namespace MWLua
if (!allowChanges) if (!allowChanges)
throw std::runtime_error("Can only be used in global scripts or in local scripts on self."); throw std::runtime_error("Can only be used in global scripts or in local scripts on self.");
auto door = doorPtr(o); const MWWorld::Ptr& door = doorPtr(o);
auto world = MWBase::Environment::get().getWorld(); auto world = MWBase::Environment::get().getWorld();
if (!openState.has_value()) if (!openState.has_value())

Loading…
Cancel
Save