Merge pull request #2712 from Capostrophic/search

Make search fields behave more consistently

apps/openmw/mwgui/companionwindow.cpp

@@ -121,6 +121,7 @@ void CompanionWindow::setPtr(const MWWorld::Ptr& npc)
 
     mModel = new CompanionItemModel(npc);
     mSortModel = new SortFilterItemModel(mModel);
+    mFilterEdit->setCaption(std::string());
     mItemView->setModel(mSortModel);
     mItemView->resetScrollBars();
 

apps/openmw/mwgui/inventorywindow.cpp

@@ -134,6 +134,8 @@ namespace MWGui
         else
             mSortModel = new SortFilterItemModel(mTradeModel);
 
+        mSortModel->setNameFilter(mFilterEdit->getCaption());
+
         mItemView->setModel(mSortModel);
 
         mFilterAll->setStateSelected(true);

apps/openmw/mwgui/keyboardnavigation.cpp

@@ -16,9 +16,6 @@ namespace MWGui
 
 bool shouldAcceptKeyFocus(MyGUI::Widget* w)
 {
-    if (w && w->getUserString("IgnoreTabKey") == "y")
-        return false;
-
     return w && !w->castType<MyGUI::Window>(false) && w->getInheritedEnabled() && w->getInheritedVisible() && w->getVisible() && w->getEnabled();
 }
 

apps/openmw/mwgui/spellwindow.cpp

@@ -45,8 +45,6 @@ namespace MWGui
         getWidget(mEffectBox, "EffectsBox");
         getWidget(mFilterEdit, "FilterEdit");
 
-        mFilterEdit->setUserString("IgnoreTabKey", "y");
-
         mSpellView->eventSpellClicked += MyGUI::newDelegate(this, &SpellWindow::onModelIndexSelected);
         mFilterEdit->eventEditTextChange += MyGUI::newDelegate(this, &SpellWindow::onFilterChanged);
         deleteButton->eventMouseButtonClick += MyGUI::newDelegate(this, &SpellWindow::onDeleteClicked);

files/mygui/openmw_companion_window.layout

@@ -8,6 +8,7 @@
         <Widget type="HBox"  position="5 5 575 23" align="Left Top HStretch" name="_Filter">
             <Widget type="EditBox" skin="MW_TextBoxEditWithBorder" position="0 0 0 23" name="FilterEdit">
                 <UserString key="HStretch" value="true"/>
+                <UserString key="AcceptTab" value="true"/>
             </Widget>
         </Widget>
         <!-- Items -->

files/mygui/openmw_inventory_window.layout

@@ -52,7 +52,8 @@
                 </Widget>
                 <!-- Search box-->
                 <Widget type="EditBox" skin="MW_TextBoxEditWithBorder" position="0 0 0 23" name="FilterEdit">
-                <UserString key="HStretch" value="true"/>
+                    <UserString key="HStretch" value="true"/>
+                    <UserString key="AcceptTab" value="true"/>
                 </Widget>
             </Widget>
 

files/mygui/openmw_spell_window.layout

@@ -24,6 +24,7 @@
 
         <!-- Search box-->
         <Widget type="EditBox" skin="MW_TextBoxEditWithBorder" position="8 535 268 23" align="Left Bottom HStretch" name="FilterEdit">
+            <UserString key="AcceptTab" value="true"/>
         </Widget>
 
     </Widget>

files/mygui/openmw_trade_window.layout

@@ -30,6 +30,7 @@
             <!-- Search box-->
             <Widget type="EditBox" skin="MW_TextBoxEditWithBorder" position="0 0 0 23" name="FilterEdit">
                 <UserString key="HStretch" value="true"/>
+                <UserString key="AcceptTab" value="true"/>
             </Widget>
         </Widget>