Cleanup(CS): Pass const ref when applicable for selection groups

apps/opencs/view/render/cell.cpp

@@ -612,7 +612,7 @@ osg::ref_ptr<CSVRender::TagBase> CSVRender::Cell::getSnapTarget(unsigned int ele
     return result;
 }
 
-void CSVRender::Cell::selectFromGroup(const std::vector<std::string> group)
+void CSVRender::Cell::selectFromGroup(const std::vector<std::string>& group)
 {
     for (const auto& [_, object] : mObjects)
     {

apps/opencs/view/render/cell.hpp

@@ -148,7 +148,7 @@ namespace CSVRender
         // already selected
         void selectAllWithSameParentId(int elementMask);
 
-        void selectFromGroup(const std::vector<std::string> group);
+        void selectFromGroup(const std::vector<std::string>& group);
 
         void unhideAll();
 

apps/opencs/view/render/object.cpp

@@ -484,7 +484,7 @@ CSVRender::Object::~Object()
     mParentNode->removeChild(mRootNode);
 }
 
-void CSVRender::Object::setSelected(bool selected, osg::Vec4f color)
+void CSVRender::Object::setSelected(bool selected, const osg::Vec4f& color)
 {
     mSelected = selected;
 

apps/opencs/view/render/object.hpp

@@ -139,7 +139,7 @@ namespace CSVRender
         ~Object();
 
         /// Mark the object as selected, selected objects show an outline effect
-        void setSelected(bool selected, osg::Vec4f color = osg::Vec4f(1, 1, 1, 1));
+        void setSelected(bool selected, const osg::Vec4f& color = osg::Vec4f(1, 1, 1, 1));
 
         bool getSelected() const;
 

apps/opencs/view/render/pagedworldspacewidget.cpp

@@ -875,7 +875,7 @@ std::vector<osg::ref_ptr<CSVRender::TagBase>> CSVRender::PagedWorldspaceWidget::
     return result;
 }
 
-void CSVRender::PagedWorldspaceWidget::selectGroup(std::vector<std::string> group) const
+void CSVRender::PagedWorldspaceWidget::selectGroup(const std::vector<std::string>& group) const
 {
     for (const auto& [_, cell] : mCells)
         cell->selectFromGroup(group);

apps/opencs/view/render/pagedworldspacewidget.hpp

@@ -163,7 +163,7 @@ namespace CSVRender
 
         std::vector<osg::ref_ptr<TagBase>> getSelection(unsigned int elementMask) const override;
 
-        void selectGroup(const std::vector<std::string> group) const override;
+        void selectGroup(const std::vector<std::string>& group) const override;
 
         void unhideAll() const override;
 

apps/opencs/view/render/unpagedworldspacewidget.cpp

@@ -199,7 +199,7 @@ std::vector<osg::ref_ptr<CSVRender::TagBase>> CSVRender::UnpagedWorldspaceWidget
     return mCell->getSelection(elementMask);
 }
 
-void CSVRender::UnpagedWorldspaceWidget::selectGroup(const std::vector<std::string> group) const
+void CSVRender::UnpagedWorldspaceWidget::selectGroup(const std::vector<std::string>& group) const
 {
     mCell->selectFromGroup(group);
 }

apps/opencs/view/render/unpagedworldspacewidget.hpp

@@ -93,7 +93,7 @@ namespace CSVRender
 
         std::vector<osg::ref_ptr<TagBase>> getSelection(unsigned int elementMask) const override;
 
-        void selectGroup(const std::vector<std::string> group) const override;
+        void selectGroup(const std::vector<std::string>& group) const override;
 
         void unhideAll() const override;
 

apps/opencs/view/render/worldspacewidget.hpp

@@ -201,7 +201,7 @@ namespace CSVRender
 
         virtual std::vector<osg::ref_ptr<TagBase>> getSelection(unsigned int elementMask) const = 0;
 
-        virtual void selectGroup(const std::vector<std::string>) const = 0;
+        virtual void selectGroup(const std::vector<std::string>&) const = 0;
 
         virtual void unhideAll() const = 0;