mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-04-03 13:36:40 +00:00
Code Issues Releases Wiki Activity

Check for head and hair. Correct faction check.

Browse source
This commit is contained in:
Marek Kochanowicz 2013-12-30 11:39:03 +01:00
parent 842e26b8e5
commit c89608f390
1 changed files with 25 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
apps/opencs/model/tools/referenceablecheck.cpp
View file

@ -995,19 +995,18 @@ void CSMTools::ReferenceableCheckStage::npcCheck(int stage, const CSMWorld::RefI
messages.push_back(id.toString() + "|" + NPC.mId + " has negative reputation"); messages.push_back(id.toString() + "|" + NPC.mId + " has negative reputation");
} }
if (!NPC.mFaction.empty()) if (NPC.mFaction.empty() == false)
{ {
if (Rank < 0) if (Rank < 0)
{ {
messages.push_back(id.toString() + "|" + NPC.mId + " has negative rank"); messages.push_back(id.toString() + "|" + NPC.mId + " has negative rank");
} }
//This code does not work at the moment. nosuchfaction is true for every npc record
/*
bool nosuchfaction(true); bool nosuchfaction(true);
for (int i = 0; i < mRaces.getSize(); ++i)
for (int i = 0; i < mFactions.getSize(); ++i)
{ {
if (dynamic_cast<const ESM::Faction &>(mFactions.getRecord(i).get()).mName == NPC.mFaction) if (dynamic_cast<const ESM::Faction&>(mFactions.getRecord(i).get()).mId == NPC.mFaction)
{ {
nosuchfaction = false; nosuchfaction = false;
break; break;
@ -1018,7 +1017,16 @@ void CSMTools::ReferenceableCheckStage::npcCheck(int stage, const CSMWorld::RefI
{ {
messages.push_back(id.toString() + "|" + NPC.mId + " has invalid faction"); messages.push_back(id.toString() + "|" + NPC.mId + " has invalid faction");
} }
*/ }
if (NPC.mHead.empty())
{
messages.push_back(id.toString() + "|" + NPC.mId + " has no head");
}
if (NPC.mHair.empty())
{
messages.push_back(id.toString() + "|" + NPC.mId + " has no har");
} }
//TODO: reputation, Disposition, rank, everything else //TODO: reputation, Disposition, rank, everything else