Initialize FileSystemArchive index in constructor

It should be initialize for each created archive anyway. There is no good reason
to have additional complexity for lazy initialization. And it helps to catch
problems with specific directory when it's added to the VFS not when all are
added and index is built.

components/vfs/filesystemarchive.cpp

@@ -12,19 +12,12 @@ namespace VFS
 {
 
     FileSystemArchive::FileSystemArchive(const std::filesystem::path& path)
-        : mBuiltIndex(false)
+        : mPath(path)
-        , mPath(path)
-    {
-    }
-
-    void FileSystemArchive::listResources(FileMap& out)
-    {
-        if (!mBuiltIndex)
     {
         const auto str = mPath.u8string();
-            size_t prefix = str.size();
+        std::size_t prefix = str.size();
 
-            if (!mPath.empty() && str[prefix - 1] != '\\' && str[prefix - 1] != '/')
+        if (prefix > 0 && str[prefix - 1] != '\\' && str[prefix - 1] != '/')
             ++prefix;
 
         for (const auto& i : std::filesystem::recursive_directory_iterator(mPath))
@@ -32,29 +25,24 @@ namespace VFS
             if (std::filesystem::is_directory(i))
                 continue;
 
-                const auto& path = i.path();
+            const std::filesystem::path& filePath = i.path();
-                const std::string proper = Files::pathToUnicodeString(path);
+            const std::string proper = Files::pathToUnicodeString(filePath);
-
-                FileSystemArchiveFile file(path);
-
             VFS::Path::Normalized searchable(std::string_view{ proper }.substr(prefix));
+            FileSystemArchiveFile file(filePath);
 
             const auto inserted = mIndex.emplace(std::move(searchable), std::move(file));
             if (!inserted.second)
                 Log(Debug::Warning)
-                        << "Warning: found duplicate file for '" << proper
+                    << "Found duplicate file for '" << proper
                     << "', please check your file system for two files with the same name in different cases.";
-                else
-                    out[inserted.first->first] = &inserted.first->second;
         }
-            mBuiltIndex = true;
     }
-        else
+
+    void FileSystemArchive::listResources(FileMap& out)
     {
         for (auto& [k, v] : mIndex)
             out[k] = &v;
     }
-    }
 
     bool FileSystemArchive::contains(Path::NormalizedView file) const
     {

components/vfs/filesystemarchive.hpp

@@ -36,7 +36,6 @@ namespace VFS
 
     private:
         std::map<VFS::Path::Normalized, FileSystemArchiveFile, std::less<>> mIndex;
-        bool mBuiltIndex;
         std::filesystem::path mPath;
     };