From d2958a17faa3346203127b8dd4ce32b6aacaf6cf Mon Sep 17 00:00:00 2001 From: Evil Eye Date: Mon, 22 Sep 2025 22:13:03 +0200 Subject: [PATCH] Make Absorb Skill safe for creatures --- CHANGELOG.md | 1 + apps/openmw/mwmechanics/spelleffects.cpp | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 830ab93094..78a65d7557 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -71,6 +71,7 @@ Bug #8650: Some plants turn invisible when being called types.Container.inventory(cont):isResolved() Bug #8680: Dead ancestor ghosts stop being dust when you rest near them Bug #8686: openmw-cs: Crash when smoothing terrain of a not-yet-created cell. + Bug #8710: Absorb Skill breaks on creatures Feature #2522: Support quick item transfer Feature #3740: Gamepad GUI Mode Feature #3769: Allow GetSpellEffects on enchantments diff --git a/apps/openmw/mwmechanics/spelleffects.cpp b/apps/openmw/mwmechanics/spelleffects.cpp index c2a7924c77..85fa14b09b 100644 --- a/apps/openmw/mwmechanics/spelleffects.cpp +++ b/apps/openmw/mwmechanics/spelleffects.cpp @@ -850,7 +850,7 @@ namespace MWMechanics else if (!godmode) { damageSkill(target, effect, effect.mMagnitude); - if (!caster.isEmpty()) + if (!caster.isEmpty() && caster.getClass().isNpc()) fortifySkill(caster, effect, effect.mMagnitude); } break; @@ -1302,7 +1302,7 @@ namespace MWMechanics { const auto caster = world->searchPtrViaActorId(spellParams.getCasterActorId()); restoreSkill(target, effect, effect.mMagnitude); - if (!caster.isEmpty()) + if (!caster.isEmpty() && caster.getClass().isNpc()) fortifySkill(caster, effect, -effect.mMagnitude); } break;