diff --git a/apps/wizard/mainwizard.cpp b/apps/wizard/mainwizard.cpp index a7d60df4ba..c3d5905687 100644 --- a/apps/wizard/mainwizard.cpp +++ b/apps/wizard/mainwizard.cpp @@ -71,7 +71,7 @@ Wizard::MainWizard::MainWizard(Files::ConfigurationManager&& cfgMgr, QWidget* pa setupInstallations(); setupPages(); - for (std::filesystem::path installationPath : mCfgMgr.getInstallPaths()) + for (const std::filesystem::path& installationPath : mCfgMgr.getInstallPaths()) { addInstallation(Files::pathToQString(installationPath / "Data Files")); } diff --git a/components/files/linuxpath.cpp b/components/files/linuxpath.cpp index 4ac184f521..9c333a0147 100644 --- a/components/files/linuxpath.cpp +++ b/components/files/linuxpath.cpp @@ -119,10 +119,10 @@ namespace Files // Flatpak homePath / ".var/app/com.valvesoftware.Steam/.local/share/Steam/steamapps/common/Morrowind", }; - for (std::filesystem::path steam : steamPaths) + for (const std::filesystem::path& steam : steamPaths) { if (std::filesystem::is_directory(steam)) - paths.emplace_back(std::move(steam)); + paths.emplace_back(steam); } } return paths; diff --git a/components/files/wine.hpp b/components/files/wine.hpp index 905a19ed1b..6bba1fad96 100644 --- a/components/files/wine.hpp +++ b/components/files/wine.hpp @@ -11,7 +11,7 @@ namespace Files::Wine { - std::filesystem::path getInstallPath(const std::filesystem::path& homePath) + static std::filesystem::path getInstallPath(const std::filesystem::path& homePath) { std::filesystem::path wineDefaultRegistry = homePath / ".wine/system.reg"; if (!std::filesystem::is_regular_file(wineDefaultRegistry))