From db0c7350b87ec3e05d5addd0495c9cf91b578228 Mon Sep 17 00:00:00 2001 From: ddbb07 <31517774-ddbb07@users.noreply.gitlab.com> Date: Tue, 18 Nov 2025 20:38:22 +0100 Subject: [PATCH] Don't make copies of variables unless absolutely necessary. --- apps/openmw/mwgui/settingswindow.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/apps/openmw/mwgui/settingswindow.cpp b/apps/openmw/mwgui/settingswindow.cpp index eaf5f222c7..6bec0ed837 100644 --- a/apps/openmw/mwgui/settingswindow.cpp +++ b/apps/openmw/mwgui/settingswindow.cpp @@ -943,24 +943,24 @@ namespace MWGui namespace { - std::vector generatePatternArray(std::string inputString) + std::vector generatePatternArray(const MyGUI::UString& inputString) { if (inputString.empty() || inputString.find_first_not_of(" ") == std::string::npos) return std::vector(); - Misc::StringUtils::lowerCaseInPlace(inputString); - std::istringstream stringStream(inputString); + std::string inputStringLowerCase = Misc::StringUtils::lowerCase(inputString); + std::istringstream stringStream(inputStringLowerCase); return { std::istream_iterator(stringStream), std::istream_iterator() }; } - size_t weightedSearch(std::string corpus, const std::vector& patternArray) + size_t weightedSearch(const std::string& corpus, const std::vector& patternArray) { if (patternArray.empty()) return 1; - Misc::StringUtils::lowerCaseInPlace(corpus); + std::string corpusLowerCase = Misc::StringUtils::lowerCase(corpus); size_t numberOfMatches = 0; for (const std::string& word : patternArray) - numberOfMatches += corpus.find(word) != std::string::npos ? 1 : 0; + numberOfMatches += corpusLowerCase.find(word) != std::string::npos ? 1 : 0; return numberOfMatches; }