Move prepareMaster logic into addMaster. Having these separate only introduces the possibility for a bug.

apps/openmw/engine.cpp

@@ -20,18 +20,6 @@ OMW::Engine::Engine()
 {
 }
 
-// adjust name and load bsa
-
-void OMW::Engine::prepareMaster()
-{
-    std::string::size_type sep = mMaster.find_last_of (".");
-
-    if (sep==std::string::npos)
-    {
-        mMaster += ".esm";
-    }
-}
-
 // Load all BSA files in data directory.
 
 void OMW::Engine::loadBSA()
@@ -79,6 +67,13 @@ void OMW::Engine::addMaster (const std::string& master)
 {
     assert (mMaster.empty());
     mMaster = master;
+
+    // Append .esm if not already there
+    std::string::size_type sep = mMaster.find_last_of (".");
+    if (sep == std::string::npos)
+    {
+        mMaster += ".esm";
+    }
 }
 
 // Enables sky rendering
@@ -109,7 +104,6 @@ void OMW::Engine::go()
     addResourcesDirectory (mDataDir / "Meshes");
     addResourcesDirectory (mDataDir / "Textures");
 
-    prepareMaster();
     loadBSA();
 
     boost::filesystem::path masterPath (mDataDir);

apps/openmw/engine.hpp

@@ -30,9 +30,6 @@ namespace OMW
             Engine (const Engine&);
             Engine& operator= (const Engine&);
 
-            /// adjust name and load bsa
-            void prepareMaster();
-
             /// add resources directory
             /// \note This function works recursively.
             void addResourcesDirectory (const boost::filesystem::path& path);