diff --git a/apps/openmw/mwbase/mechanicsmanager.hpp b/apps/openmw/mwbase/mechanicsmanager.hpp index 37586ed33a..4883fa2000 100644 --- a/apps/openmw/mwbase/mechanicsmanager.hpp +++ b/apps/openmw/mwbase/mechanicsmanager.hpp @@ -27,11 +27,6 @@ namespace ESM class ESMWriter; } -namespace MWSound -{ - enum class MusicType; -} - namespace MWWorld { class Ptr; @@ -312,9 +307,6 @@ namespace MWBase virtual float getAngleToPlayer(const MWWorld::Ptr& ptr) const = 0; virtual MWMechanics::GreetingState getGreetingState(const MWWorld::Ptr& ptr) const = 0; virtual bool isTurningToPlayer(const MWWorld::Ptr& ptr) const = 0; - - virtual MWSound::MusicType getMusicType() const = 0; - virtual void setMusicType(MWSound::MusicType type) = 0; }; } diff --git a/apps/openmw/mwmechanics/mechanicsmanagerimp.cpp b/apps/openmw/mwmechanics/mechanicsmanagerimp.cpp index e9c34407e8..a3761e1b64 100644 --- a/apps/openmw/mwmechanics/mechanicsmanagerimp.cpp +++ b/apps/openmw/mwmechanics/mechanicsmanagerimp.cpp @@ -250,7 +250,6 @@ namespace MWMechanics , mClassSelected(false) , mRaceSelected(false) , mAI(true) - , mMusicType(MWSound::MusicType::Normal) { // buildPlayer no longer here, needs to be done explicitly after all subsystems are up and running } diff --git a/apps/openmw/mwmechanics/mechanicsmanagerimp.hpp b/apps/openmw/mwmechanics/mechanicsmanagerimp.hpp index 1ef4d9ab19..4b0126cd34 100644 --- a/apps/openmw/mwmechanics/mechanicsmanagerimp.hpp +++ b/apps/openmw/mwmechanics/mechanicsmanagerimp.hpp @@ -38,8 +38,6 @@ namespace MWMechanics typedef std::map StolenItemsMap; StolenItemsMap mStolenItems; - MWSound::MusicType mMusicType; - public: void buildPlayer(); ///< build player according to stored class/race/birthsign information. Will @@ -245,9 +243,6 @@ namespace MWMechanics GreetingState getGreetingState(const MWWorld::Ptr& ptr) const override; bool isTurningToPlayer(const MWWorld::Ptr& ptr) const override; - MWSound::MusicType getMusicType() const override { return mMusicType; } - void setMusicType(MWSound::MusicType type) override { mMusicType = type; } - private: bool canCommitCrimeAgainst(const MWWorld::Ptr& victim, const MWWorld::Ptr& attacker); bool canReportCrime( diff --git a/apps/openmw/mwsound/soundmanagerimp.cpp b/apps/openmw/mwsound/soundmanagerimp.cpp index 38530d859f..cb0d6ac331 100644 --- a/apps/openmw/mwsound/soundmanagerimp.cpp +++ b/apps/openmw/mwsound/soundmanagerimp.cpp @@ -115,6 +115,7 @@ namespace MWSound , mOutput(std::make_unique(*this)) , mWaterSoundUpdater(makeWaterSoundUpdaterSettings()) , mSoundBuffers(*mOutput) + , mMusicType(MWSound::MusicType::Normal) , mListenerUnderwater(false) , mListenerPos(0, 0, 0) , mListenerDir(1, 0, 0) @@ -307,10 +308,10 @@ namespace MWSound const auto mechanicsManager = MWBase::Environment::get().getMechanicsManager(); // Can not interrupt scripted music by built-in playlists - if (mechanicsManager->getMusicType() == MusicType::MWScript && type != MusicType::MWScript) + if (mMusicType == MusicType::MWScript && type != MusicType::MWScript) return; - mechanicsManager->setMusicType(type); + mMusicType = type; advanceMusic(filename, fade); } diff --git a/apps/openmw/mwsound/soundmanagerimp.hpp b/apps/openmw/mwsound/soundmanagerimp.hpp index 2e38215e14..fab6489878 100644 --- a/apps/openmw/mwsound/soundmanagerimp.hpp +++ b/apps/openmw/mwsound/soundmanagerimp.hpp @@ -86,7 +86,7 @@ namespace MWSound TrackList mActiveTracks; StreamPtr mMusic; - VFS::Path::Normalized mCurrentPlaylist; + MusicType mMusicType; bool mListenerUnderwater; osg::Vec3f mListenerPos;