Merge branch 'clang-tidy' into 'master'

Add clang-tidy to the CI

See merge request OpenMW/openmw!900

.gitlab-ci.yml

@@ -31,6 +31,23 @@ stages:
     paths:
       - build/install/
 
+Clang_Tidy:
+  extends: .Debian_Image
+  stage: build
+  rules:
+    - if: '$CI_PIPELINE_SOURCE == "schedule"'
+  before_script:
+    - CI/install_debian_deps.sh gcc openmw-deps openmw-deps-dynamic clang-tidy clang
+  script:
+    - CI/before_script.linux.sh
+    - cd build
+    - cmake --build . -- -j $(nproc)
+  variables:
+    CC: clang
+    CXX: clang++
+    CI_CLANG_TIDY: 1
+  timeout: 8h
+
 Coverity:
   extends: .Debian_Image
   stage: build
@@ -433,3 +450,4 @@ Debian_AndroidNDK_arm64-v8a:
       - build/install/
   # When CCache doesn't exist (e.g. first build on a fork), build takes more than 1h, which is the default for forks.
   timeout: 1h30m
+

CI/before_script.linux.sh

@@ -34,6 +34,13 @@ if [[ $CI_OPENMW_USE_STATIC_DEPS ]]; then
     )
 fi
 
+if [[ $CI_CLANG_TIDY ]]; then
+	CMAKE_CONF_OPTS+=(
+	      -DCMAKE_CXX_CLANG_TIDY='clang-tidy;-checks=-*,boost-*,clang-analyzer-*,concurrency-*,performance-*,-header-filter=.*,bugprone-*,misc-definitions-in-headers,misc-misplaced-const,misc-redundant-expression'
+	)
+fi
+
+
 if [[ "${CMAKE_BUILD_TYPE}" ]]; then
     CMAKE_CONF_OPTS+=(
         -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}

CI/install_debian_deps.sh

@@ -29,6 +29,7 @@ declare -rA GROUPED_DEPS=(
   # These dependencies can alternatively be built and linked statically.
   [openmw-deps-dynamic]="libmygui-dev libopenscenegraph-dev"
   [coverity]="curl"
+  [clang-tidy]="clang-tidy"
 
   # Pre-requisites for building MyGUI and OSG for static linking.
   #

extern/CMakeLists.txt

@@ -1,5 +1,7 @@
 # SPDX-License-Identifier: GPL-3.0-or-later
 
+set(CMAKE_CXX_CLANG_TIDY "")
+
 # Like `FetchContent_MakeAvailable` but passes EXCLUDE_FROM_ALL to `add_subdirectory`.
 macro(FetchContent_MakeAvailableExcludeFromAll)
     foreach(contentName IN ITEMS ${ARGV})