From efcdb2dfdd79f88027def1264a3b8d6c361fc095 Mon Sep 17 00:00:00 2001 From: Thunderforge Date: Tue, 18 May 2021 19:42:24 -0500 Subject: [PATCH] Using override keyword in most apps Detected by clang-tidy's modernize-use-override Future MRs can be created to run this on OpenMW and OpenMW CS --- apps/essimporter/importcellref.hpp | 2 +- apps/launcher/maindialog.hpp | 2 +- apps/launcher/settingspage.hpp | 2 +- apps/launcher/utils/textinputdialog.hpp | 2 +- apps/wizard/installationpage.hpp | 2 +- apps/wizard/mainwizard.hpp | 2 +- apps/wizard/unshield/unshieldworker.hpp | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-) diff --git a/apps/essimporter/importcellref.hpp b/apps/essimporter/importcellref.hpp index b115628d5e..4d7f07a6cc 100644 --- a/apps/essimporter/importcellref.hpp +++ b/apps/essimporter/importcellref.hpp @@ -27,7 +27,7 @@ namespace ESSImport void load(ESM::ESMReader& esm) override; - virtual ~CellRef() = default; + ~CellRef() override = default; }; } diff --git a/apps/launcher/maindialog.hpp b/apps/launcher/maindialog.hpp index 80e014e285..398ba882c4 100644 --- a/apps/launcher/maindialog.hpp +++ b/apps/launcher/maindialog.hpp @@ -47,7 +47,7 @@ namespace Launcher public: explicit MainDialog(QWidget *parent = nullptr); - ~MainDialog(); + ~MainDialog() override; FirstRunDialogResult showFirstRunDialog(); diff --git a/apps/launcher/settingspage.hpp b/apps/launcher/settingspage.hpp index df7c0e8eb5..fa31eb4033 100644 --- a/apps/launcher/settingspage.hpp +++ b/apps/launcher/settingspage.hpp @@ -22,7 +22,7 @@ namespace Launcher public: SettingsPage(Files::ConfigurationManager &cfg, Config::GameSettings &gameSettings, Config::LauncherSettings &launcherSettings, MainDialog *parent = nullptr); - ~SettingsPage(); + ~SettingsPage() override; void saveSettings(); bool loadSettings(); diff --git a/apps/launcher/utils/textinputdialog.hpp b/apps/launcher/utils/textinputdialog.hpp index de06599639..ad64cb3e2a 100644 --- a/apps/launcher/utils/textinputdialog.hpp +++ b/apps/launcher/utils/textinputdialog.hpp @@ -16,7 +16,7 @@ namespace Launcher public: explicit TextInputDialog(const QString& title, const QString &text, QWidget *parent = nullptr); - ~TextInputDialog (); + ~TextInputDialog () override; inline LineEdit *lineEdit() { return mLineEdit; } void setOkButtonEnabled(bool enabled); diff --git a/apps/wizard/installationpage.hpp b/apps/wizard/installationpage.hpp index cc1ccf5599..97b1fa8bf7 100644 --- a/apps/wizard/installationpage.hpp +++ b/apps/wizard/installationpage.hpp @@ -20,7 +20,7 @@ namespace Wizard Q_OBJECT public: InstallationPage(QWidget *parent); - ~InstallationPage(); + ~InstallationPage() override; int nextId() const override; bool isComplete() const override; diff --git a/apps/wizard/mainwizard.hpp b/apps/wizard/mainwizard.hpp index 249ae1cf92..a8dec32da7 100644 --- a/apps/wizard/mainwizard.hpp +++ b/apps/wizard/mainwizard.hpp @@ -40,7 +40,7 @@ namespace Wizard }; MainWizard(QWidget *parent = nullptr); - ~MainWizard(); + ~MainWizard() override; bool findFiles(const QString &name, const QString &path); void addInstallation(const QString &path); diff --git a/apps/wizard/unshield/unshieldworker.hpp b/apps/wizard/unshield/unshieldworker.hpp index 2553d1bef8..13f4a1168c 100644 --- a/apps/wizard/unshield/unshieldworker.hpp +++ b/apps/wizard/unshield/unshieldworker.hpp @@ -27,7 +27,7 @@ namespace Wizard public: UnshieldWorker(QObject *parent = nullptr); - ~UnshieldWorker(); + ~UnshieldWorker() override; void stopWorker();