Show messagebox while OpenMW appears to be frozen

If it thaws, the messagebox disappears again.
The user can press the Abort button to kill OpenMW and generate a crash
dump.
librecast_all_the_things
AnyOldName3 3 years ago
parent d15c2922a9
commit f05cd901cf

@ -148,15 +148,23 @@ namespace Crash
bool running = true;
bool frozen = false;
while (isAppAlive() && running)
while (isAppAlive() && running && !mFreezeAbort)
{
if (isAppFrozen())
{
if (!frozen)
{
showFreezeMessageBox();
frozen = true;
handleCrash();
running = false;
}
if (!frozen && waitApp())
}
else if (frozen)
{
hideFreezeMessageBox();
frozen = false;
}
if (!mFreezeAbort && waitApp())
{
shmLock();
@ -180,6 +188,9 @@ namespace Crash
}
if (frozen)
hideFreezeMessageBox();
if (mFreezeAbort)
{
TerminateProcess(mAppProcessHandle, 0xDEAD);
std::string message = "OpenMW appears to have frozen.\nCrash log saved to '" + std::string(mShm->mStartup.mLogFilePath) + "'.\nPlease report this to https://gitlab.com/OpenMW/openmw/issues !";
@ -258,4 +269,43 @@ namespace Crash
}
}
void CrashMonitor::showFreezeMessageBox()
{
std::thread messageBoxThread([&]() {
SDL_MessageBoxButtonData button = { SDL_MESSAGEBOX_BUTTON_RETURNKEY_DEFAULT, 0, "Abort" };
SDL_MessageBoxData messageBoxData = {
SDL_MESSAGEBOX_ERROR,
nullptr,
"OpenMW appears to have frozen",
"OpenMW appears to have frozen. Press Abort to terminate it and generate a crash dump.\nIf OpenMW hasn't actually frozen, this message box will disappear a within a few seconds of it becoming responsive.",
1,
&button,
nullptr
};
int buttonId;
if (SDL_ShowMessageBox(&messageBoxData, &buttonId) == 0 && buttonId == 0)
mFreezeAbort = true;
});
mFreezeMessageBoxThreadId = GetThreadId(messageBoxThread.native_handle());
messageBoxThread.detach();
}
void CrashMonitor::hideFreezeMessageBox()
{
if (!mFreezeMessageBoxThreadId)
return;
EnumWindows([](HWND handle, LPARAM param) -> BOOL {
CrashMonitor& crashMonitor = *(CrashMonitor*)param;
DWORD processId;
if (GetWindowThreadProcessId(handle, &processId) == crashMonitor.mFreezeMessageBoxThreadId && processId == GetCurrentProcessId())
PostMessage(handle, WM_CLOSE, 0, 0);
return true;
}, (LPARAM)this);
mFreezeMessageBoxThreadId = 0;
}
} // namespace Crash

@ -33,6 +33,9 @@ private:
HANDLE mShmHandle = nullptr;
HANDLE mShmMutex = nullptr;
DWORD mFreezeMessageBoxThreadId = 0;
std::atomic_bool mFreezeAbort;
static std::unordered_map<HWINEVENTHOOK, CrashMonitor*> smEventHookOwners;
void signalApp() const;
@ -48,6 +51,10 @@ private:
void shmUnlock();
void handleCrash();
void showFreezeMessageBox();
void hideFreezeMessageBox();
};
} // namespace Crash

Loading…
Cancel
Save