Do not copy objects twice where possible

components/lua/scriptscontainer.cpp

@@ -532,7 +532,7 @@ namespace LuaUtil
         t.mScriptId = scriptId;
         t.mSerializable = true;
         t.mTime = time;
-        t.mArg = callbackArg;
+        t.mArg = std::move(callbackArg);
         t.mSerializedArg = serialize(t.mArg, mSerializer);
         insertTimer(type == TimerType::GAME_TIME ? mGameTimersQueue : mSimulationTimersQueue, std::move(t));
     }

components/lua_ui/properties.hpp

@@ -25,7 +25,7 @@ namespace LuaUi
     }
 
     template <typename T, typename LuaT>
-    sol::optional<T> parseValue(sol::object table, std::string_view field, std::string_view errorPrefix)
+    sol::optional<T> parseValue(const sol::object& table, std::string_view field, std::string_view errorPrefix)
     {
         sol::object opt = LuaUtil::getFieldOrNil(table, field);
         if (opt != sol::nil && !opt.is<LuaT>())
@@ -51,7 +51,7 @@ namespace LuaUi
     }
 
     template <typename T>
-    sol::optional<T> parseValue(sol::object table, std::string_view field, std::string_view errorPrefix)
+    sol::optional<T> parseValue(const sol::object& table, std::string_view field, std::string_view errorPrefix)
     {
         if constexpr (isMyGuiVector<T>())
             return parseValue<T, osg::Vec2f>(table, field, errorPrefix);

components/lua_ui/scriptsettings.cpp

@@ -21,7 +21,7 @@ namespace LuaUi
                 Log(Debug::Warning) << "A script settings page has an empty name";
             if (!element.get())
                 Log(Debug::Warning) << "A script settings page has no UI element assigned";
-            return { name, searchHints, element };
+            return { std::move(name), std::move(searchHints), element };
         }
     }
 

components/lua_ui/widget.cpp

@@ -266,7 +266,7 @@ namespace LuaUi
             mOnCoordChange.value()(this, newCoord);
     }
 
-    void WidgetExtension::setProperties(sol::object props)
+    void WidgetExtension::setProperties(const sol::object& props)
     {
         mProperties = props;
         updateProperties();

components/lua_ui/widget.hpp

@@ -44,10 +44,10 @@ namespace LuaUi
         void setCallback(const std::string&, const LuaUtil::Callback&);
         void clearCallbacks();
 
-        void setProperties(sol::object);
-        void setTemplateProperties(sol::object props) { mTemplateProperties = props; }
+        void setProperties(const sol::object& props);
+        void setTemplateProperties(const sol::object& props) { mTemplateProperties = props; }
 
-        void setExternal(sol::object external) { mExternal = external; }
+        void setExternal(const sol::object& external) { mExternal = external; }
 
         MyGUI::IntCoord forcedCoord();
         void forceCoord(const MyGUI::IntCoord& offset);