From 29177bccb8dac4458330f7c0294cc4eb2e9f076f Mon Sep 17 00:00:00 2001 From: Alexei Kotov Date: Fri, 21 Feb 2025 00:56:09 +0300 Subject: [PATCH 1/4] Play the item's down sound when an item quick key is assigned --- apps/openmw/mwgui/quickkeysmenu.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/apps/openmw/mwgui/quickkeysmenu.cpp b/apps/openmw/mwgui/quickkeysmenu.cpp index c8932c97b6..7e501071e4 100644 --- a/apps/openmw/mwgui/quickkeysmenu.cpp +++ b/apps/openmw/mwgui/quickkeysmenu.cpp @@ -246,6 +246,8 @@ namespace MWGui if (mItemSelectionDialog) mItemSelectionDialog->setVisible(false); + + MWBase::Environment::get().getWindowManager()->playSound(item.getClass().getDownSoundId(item)); } void QuickKeysMenu::onAssignItemCancel() From 982962c6086b553d6746dfd971e0318a6cbab941 Mon Sep 17 00:00:00 2001 From: Alexei Kotov Date: Fri, 21 Feb 2025 00:56:37 +0300 Subject: [PATCH 2/4] Don't center quick keys menu instructions --- files/data/mygui/openmw_quickkeys_menu.layout | 1 - 1 file changed, 1 deletion(-) diff --git a/files/data/mygui/openmw_quickkeys_menu.layout b/files/data/mygui/openmw_quickkeys_menu.layout index ba6832cf95..892d4e748b 100644 --- a/files/data/mygui/openmw_quickkeys_menu.layout +++ b/files/data/mygui/openmw_quickkeys_menu.layout @@ -12,7 +12,6 @@ - From 733dfbb89d938ebb1c9539205a5713227374fdc1 Mon Sep 17 00:00:00 2001 From: Alexei Kotov Date: Fri, 21 Feb 2025 01:00:17 +0300 Subject: [PATCH 3/4] Don't assume any scripted item is usable --- apps/openmw/mwgui/sortfilteritemmodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/apps/openmw/mwgui/sortfilteritemmodel.cpp b/apps/openmw/mwgui/sortfilteritemmodel.cpp index fe85ea4bd0..8c6277db4d 100644 --- a/apps/openmw/mwgui/sortfilteritemmodel.cpp +++ b/apps/openmw/mwgui/sortfilteritemmodel.cpp @@ -279,7 +279,7 @@ namespace MWGui && !base.get()->mBase->mData.mIsScroll) return false; - if ((mFilter & Filter_OnlyUsableItems) && base.getClass().getScript(base).empty()) + if ((mFilter & Filter_OnlyUsableItems)) { std::unique_ptr actionOnUse = base.getClass().use(base); if (!actionOnUse || actionOnUse->isNullAction()) From a0e0b3c65b8610365602988372430f21b3abd0d7 Mon Sep 17 00:00:00 2001 From: Alexei Kotov Date: Thu, 3 Jul 2025 08:30:50 +0300 Subject: [PATCH 4/4] Some quick key menu layout fixes --- files/data/mygui/openmw_quickkeys_menu.layout | 20 +++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/files/data/mygui/openmw_quickkeys_menu.layout b/files/data/mygui/openmw_quickkeys_menu.layout index 892d4e748b..697f186411 100644 --- a/files/data/mygui/openmw_quickkeys_menu.layout +++ b/files/data/mygui/openmw_quickkeys_menu.layout @@ -1,35 +1,35 @@ - + - + - + - + - - - - - + + + + + - +