Do not copy a static string

components/fx/stateupdater.cpp

@@ -7,6 +7,8 @@
 
 namespace fx
 {
+    std::string StateUpdater::sDefinition = UniformData::getDefinition("_omw_data");
+
     StateUpdater::StateUpdater(bool useUBO)
         : mUseUBO(useUBO)
     {

components/fx/stateupdater.hpp

@@ -100,11 +100,7 @@ namespace fx
             mPointLightBuffer = std::move(buffer);
         }
 
-        static std::string getStructDefinition()
+        static const std::string& getStructDefinition() { return sDefinition; }
-        {
-            static std::string definition = UniformData::getDefinition("_omw_data");
-            return definition;
-        }
 
         void setDefaults(osg::StateSet* stateset) override;
 
@@ -275,6 +271,8 @@ namespace fx
         UniformData mData;
         bool mUseUBO;
 
+        static std::string sDefinition;
+
         std::shared_ptr<SceneUtil::PPLightBuffer> mPointLightBuffer;
     };
 }