Commit Graph

11 Commits (master)

Author SHA1 Message Date
Alexei Kotov a5d936993f Clarify Fallout 4 next gen update BA2 version naming 8 months ago
Alexei Kotov b32385a0af Fix BA2 signature check 8 months ago
Alexei Kotov 22fb3d7f83 Add support for Fallout 4 next-gen update BA2s 8 months ago
AnyOldName3 ff3ffa13b6 Auto format 10 months ago
AnyOldName3 28131fd62b Fixes for a whole bunch of warnings
These warnings were always enabled, but we didn't see them due to https://gitlab.com/OpenMW/openmw/-/issues/7882.
I do not fully understand the cause of 7822 as I can't repro it in a minimal CMake project.

Some of these fixes are thought through.
Some are sensible best guesses.
Some are kind of a stab in the dark as I don't know whether there was a
possible bug the warning was telling me about that I've done nothing to
help by introducing a static_cast.

Nearly all of these warnings were about some kind of narrowing
conversion, so I'm not sure why they weren't firing with GCC and Clang,
which have -Wall -Wextra -pedantic set, which should imply -Wnarrowing,
and they can't have been affected by 7882.

There were also some warnings being triggered from Boost code.
The vast majority of library headers that do questionable things weren't
firing warnings off, but for some reason, /external:I wasn't putting
these Boost headers into external mode.

We need these warnings dealt with one way or another so we can switch
the default Windows CI from MSBuild (which doesn't do ccache) to Ninja
(which does).
I have the necessary magic for that on a branch, but the branch won't
build because of these warnings.
10 months ago
Alexei Kotov 84ab7afd44 Make BA2 extension hash calculation safer (#7784) 11 months ago
Alexei Kotov b2bb19ae4d Support Starfield BA2s 1 year ago
Cédric Mocquillon 3b1d6a7e62 Use the right size 1 year ago
Cédric Mocquillon d73ab7ef6f Add comments 2 years ago
Cédric Mocquillon 24272d07bf Share generateHash used in ba2dx10file and ba2gnrlfile 2 years ago
Cédric Mocquillon c1fbe90953 Handle GNRL case of ba2 format 2 years ago