Commit Graph

87 Commits (master)

Author SHA1 Message Date
Evil Eye 02775c490b Discard additional tokens in non-expression contexts 1 year ago
florent.teppe 65cdd489fb create a specific esm reader function for RefID to avoid allocation for string and then again for RefId
Fixed some types

removed useless header

applied clang format

fixed compile tests

fixed clang tidy, and closer to logic before this MR

Removed hardcoded refids

unless there is a returned value we don't use static RefIds
can use == between RefId and hardcoded string

Fix clang format

Fixed a few instances where std::string was used, when only const std::string& was needed

removed unused variable
2 years ago
fteppe 125b21de20 Initial commit: In ESM structures, replace the string members that are RefIds to other records, to a new strong type
The strong type is actually just a string underneath, but this will help in the future to have a distinction so it's easier to search and replace when we use an integer ID

Slowly going through all the changes to make, still hundreds of errors

a lot of functions/structures use std::string or stringview to designate an ID. So it takes time

Continues slowly replacing ids. There are technically more and more compilation errors

I have good hope that there is a point where the amount of errors will dramatically go down as all the main functions use the ESM::RefId type

Continue moving forward, changes to the stores

slowly moving along

Starting to see the fruit of those changes.

still many many error, but more and more Irun into a situation where a function is sandwiched between two functions that use the RefId type.

More replacements. Things are starting to get easier

I can see more and more often the issue is that the function is awaiting a RefId, but is given a string
there is less need to go down functions and to fix a long list of them.

Still moving forward, and for the first time error count is going down!

Good pace, not sure about topics though, mId and mName are actually the same thing and are used interchangeably

Cells are back to using string for the name, haven't fixed everything yet. Many other changes

Under the bar of 400 compilation errors.

more good progress <100 compile errors!

More progress

Game settings store can use string for find, it was a bit absurd how every use of it required to create refId from string

some more progress on other fronts

Mostly game settings clean

one error opened a lot of other errors. Down to 18, but more will prbably appear

only link errors left??

Fixed link errors

OpenMW compiles, and launches, with some issues, but still!
2 years ago
clang-format-bot ddb0522bbf
Apply clang-format to code base 2 years ago
elsid f99ed6f1db
Split components/misc/stringops.hpp into multiple headers
Replace all ciEqual overloads with one having std::string_view as argument.
2 years ago
Evil Eye ac747f02f3 Don't teleport NPCs to unknown cells 3 years ago
Evil Eye bee94e2afc Treat commas in scripts as whitespace 3 years ago
Evil Eye fef902617a Parse integer format arguments as variable names 3 years ago
Evil Eye dfb6bdf77e Allow integer variable names 3 years ago
Bret Curtis 5a824d0333 components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues 4 years ago
Capostrophic e02b66cdf4 Ignore bogus string arguments for Disable/Enable again 5 years ago
Evil Eye 3875b837bc make MenuMode, Random, GetSecondsPassed regular functions 5 years ago
Evil Eye f0e2ee45fa reuse ImplicitRef and ExplicitRef for enable, disable, getdisabled, startscript; move scriptrunning and stopscript 5 years ago
Capostrophic 3d64a46df2 Allow using functions in non-conditional expressions (bug #3725) 6 years ago
Capostrophic 17dce28705 Improve compiler messages 6 years ago
Capostrophic cc855e065a Ignore stray references for variables in Set instruction 6 years ago
Capostrophic 95aa05e41b Tweaks to script parser messages and pathgrid warnings 6 years ago
Andrei Kortunov f0919f51e9 Fix integer result formatting of scripting functions 6 years ago
James Carty 579f35511a Add support for scietific notation flag for MessageBox 6 years ago
Marc Zinnschlag 565922f9ad naked expressions beginning with the member operator were allowed erroneously outside of the console (Fixes issue #2971) 7 years ago
Ewan Higgs 38a2de3c51 convert std::autor_ptr to std::unique_ptr, originally by Ewan Higgs and updated by Bret Curtis 8 years ago
Allofich 73463cd12f Remove unnecessary virtual destructor 8 years ago
Allofich 8c5aae0722 Add virtual destructors 8 years ago
MiroslavR f6f3f71db5 Improve format specifiers for message boxes 9 years ago
Marc Zinnschlag 06efd72a89 allow keywords as strings in messagebox instruction (Fixes #2991) 9 years ago
Marc Zinnschlag ae54f34f25 removed a redundant else and made unary + work also in the console 9 years ago
scrawl 67bd6cd708 Remove empty line at the beginning of files
git ls-files -z | xargs -0 sed -i '1{/^$/d}'
10 years ago
Marc Zinnschlag cbf9f83b85 allow use of IDs as function arguments, even if the ID matches a keyword (Fixes #2830) 10 years ago
Rohit Nirmal 396fba7fa9 Silence -Wreorder warnings, and remove -Wno-reorder. 10 years ago
Marc Zinnschlag 057d0913d6 Merge branch 'scriptfixes' 10 years ago
Marc Zinnschlag b951251572 handle junk in argument lists (Fixes #2206) 10 years ago
Marc Zinnschlag ed5387fb8c replaced stay [ ignoring implementation with one that does not interfere with other workarounds (Fixes #2205) 10 years ago
scrawl 7252cb63a6 Fix cppcheck issues 10 years ago
slothlife 35ced14e45 Fix for MSVC warnings 10 years ago
Marc Zinnschlag 14f32563e7 fixed script compiler code ordering issue 10 years ago
scrawl 174153b2da Revert "Fix member variable case problem"
This reverts commit f0354ea04c.

Fixes #759 (again)

Conflicts:
	components/compiler/lineparser.cpp
10 years ago
Marc Zinnschlag 736ab76f68 limit argument error workaround to PositionCell instruction (Fixes #1732) 10 years ago
Marc Zinnschlag 2abc4e42c8 end parsing of line after parsing a declaration 11 years ago
Marc Zinnschlag 6a745c014f workaround for incorrect argument order for PositionCell instruction 11 years ago
Marc Zinnschlag 19f4c46fe4 alllow (and ignore) explicit references for StopScript and ScriptRunning 11 years ago
Marc Zinnschlag e8322da663 added support for targeted scripts to script compiler 11 years ago
Marc Zinnschlag 12fc0aaecb removed an unused parser settings (implicitly fixing a case were this setting was not applied correctly) 11 years ago
scrawl 452b522bc3 Fix typos 11 years ago
Marc Zinnschlag d213c6c36a fixed a constness-issue 11 years ago
Marc Zinnschlag e76ef92669 also allow the use of keywords as remote local variables in set statements 11 years ago
Marc Zinnschlag 749136bf33 ignore attempts to set non-existing variables 11 years ago
Marc Zinnschlag a85d3c7dcb ignore unused explicit references for functions 11 years ago
Marc Zinnschlag 6e2e4d1adf ignore stray begin 11 years ago
Marc Zinnschlag c0a6acfe6c allow the use of keywords as variable names in more places 11 years ago
Marc Zinnschlag bfb0e62c4a ignore additional string argument after enable/disable 11 years ago