mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-02-26 08:09:42 +00:00
Code Issues Releases Wiki Activity
28982 commits 108 branches 68 tags 135 MiB
Commit graph

28982 commits

This branch
This branch
All branches
Author SHA1 Message Date
elsid
9ac3bb753e
Move declaration private static member variables of LightManager to .cpp 
There is no need to expose them to other translation units.
 2022-07-08 17:21:01 +02:00
elsid
4211cf1c24
Use uniform indent and apply openmw naming policy 2022-07-08 17:14:13 +02:00
psi29a
98f839982e Merge branch 'refactor_actors' into 'master' 
Refactor MWMechanics::Actors

See merge request OpenMW/openmw!2094
 2022-07-07 17:56:09 +00:00
psi29a
7fd87ff34f Merge branch 'stop_hitting_yourself' into 'master' 
Don't try to start combat with oneself and don't tell the player what to do

Closes #6856

See merge request OpenMW/openmw!2110
 2022-07-06 20:46:46 +00:00
Evil Eye
e42d63f4a4 Don't try to start combat with oneself and don't tell the player what to do 2022-07-06 19:12:36 +02:00
psi29a
510a9b9a5e Merge branch 'navmeshtilescache_find' into 'master' 
Avoid redundant copy when finding item in NavMeshTilesCache

See merge request OpenMW/openmw!2109
 2022-07-06 13:48:24 +00:00
psi29a
1ef8ca1f27 Merge branch 'fix_tidy_warnings' into 'master' 
Fix several Clang-Tidy warnings

See merge request OpenMW/openmw!2107
 2022-07-06 13:47:59 +00:00
psi29a
8cd396205b Merge branch 'benchmark_1_6_1' into 'master' 
Support google benchmark v1.6.1

See merge request OpenMW/openmw!2108
 2022-07-06 13:46:36 +00:00
elsid
520738277a
Support google benchmark v1.6.1 2022-07-06 15:06:59 +02:00
elsid
6fb7af3b63
Avoid redundant copy when finding item in NavMeshTilesCache 
std::make_tuple returns a tuple for types with removed references which makes it
to copy arguments. std::tie leaves references.
 2022-07-06 14:23:07 +02:00
elsid
b4f12aace1
Explicitly ignore result of std::unique_ptr::release call 
components/nifbullet/bulletnifloader.cpp:206:13: warning: the value returned by this function should be used [bugprone-unused-return-value]
            boxShape.release();
            ^~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:232:13: warning: the value returned by this function should be used [bugprone-unused-return-value]
            child.release();
            ^~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:233:13: warning: the value returned by this function should be used [bugprone-unused-return-value]
            mStaticMesh.release();
            ^~~~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:240:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        mStaticMesh.release();
        ^~~~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:246:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        mAvoidStaticMesh.release();
        ^~~~~~~~~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:411:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        childMesh.release();
        ^~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:425:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        childShape.release();
        ^~~~~~~~~~~~~~~~~~~~
 2022-07-06 13:52:29 +02:00
elsid
bd7f56ddb4
Don't rely on virtual dispatch in constructor 
apps/openmw/mwrender/animation.cpp:1841:60: warning: Call to virtual method 'ObjectAnimation::canBeHarvested' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
        if (ptr.getRefData().getCustomData() != nullptr && canBeHarvested())
                                                           ^~~~~~~~~~~~~~~~

apps/openmw/mwrender/bulletdebugdraw.cpp:33:5: warning: Call to virtual method 'DebugDrawer::setDebugMode' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
    setDebugMode(debugMode);
    ^~~~~~~~~~~~~~~~~~~~~~~

openmw/mwinput/controllermanager.cpp:63:17: warning: Call to virtual method 'ControllerManager::controllerAdded' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall]
                controllerAdded(fakeDeviceID, evt);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 2022-07-06 13:52:28 +02:00
elsid
4ecee2e167
Avoid using reserved identifier in the global namespace 
apps/launcher/datafilespage.cpp:762:12: warning: declaration uses identifier '_reloadCellsMutex', which is reserved in the global namespace [bugprone-reserved-identifier]
std::mutex _reloadCellsMutex;
           ^~~~~~~~~~~~~~~~~
           reloadCellsMutex

apps/openmw/mwgui/journalwindow.cpp:86:103: warning: declaration uses identifier '_sender', which is reserved in the global namespace [bugprone-reserved-identifier]
        void adviseButtonClick (char const * name, void (JournalWindowImpl::*Handler) (MyGUI::Widget* _sender))
                                                                                                      ^~~~~~~
                                                                                                      sender

apps/openmw/mwgui/journalwindow.cpp:92:100: warning: declaration uses identifier '_sender', which is reserved in the global namespace [bugprone-reserved-identifier]
        void adviseKeyPress (char const * name, void (JournalWindowImpl::*Handler) (MyGUI::Widget* _sender, MyGUI::KeyCode key, MyGUI::Char character))
                                                                                                   ^~~~~~~
                                                                                                   sender
 2022-07-06 13:52:28 +02:00
elsid
72bda2bd10
Avoid redundant initialization 
components/nifbullet/bulletnifloader.cpp:79:24: warning: Value stored to 'a' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
        unsigned short a = strip[0], b = strip[0], c = strip[1];
                       ^   ~~~~~~~~
 2022-07-06 13:52:28 +02:00
elsid
7501597813
Do not use float as loop variable 
apps/opencs/view/render/instanceselectionmode.cpp:294:9: warning: Variable 'i' with floating point type 'float' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter]
        for (float i = 0.0; i <= resolution; i += 2)
        ^                   ~                ~
 2022-07-06 13:52:28 +02:00
elsid
5b9ca3b979
Avoid possible division by zero 
components/detournavigator/navmeshdb.cpp:183:43: warning: Division by zero [clang-analyzer-core.DivideZero]
        setMaxPageCount(*mDb, maxFileSize / dbPageSize + static_cast<std::uint64_t>((maxFileSize % dbPageSize) != 0));
                              ~~~~~~~~~~~~^~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:182:33: note: Calling 'getPageSize'
        const auto dbPageSize = getPageSize(*mDb);
                                ^~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:144:13: note: 'value' initialized to 0
            std::uint64_t value = 0;
            ^~~~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:145:13: note: Calling 'request<DetourNavigator::(anonymous namespace)::GetPageSize, unsigned long *, >'
            request(db, statement, &value, 1);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
components/sqlite3/request.hpp:254:64: note: Left side of '&&' is false
            for (std::size_t i = 0; executeStep(db, statement) && i < max; ++i)
                                                               ^
components/detournavigator/navmeshdb.cpp:145:13: note: Returning from 'request<DetourNavigator::(anonymous namespace)::GetPageSize, unsigned long *, >'
            request(db, statement, &value, 1);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:146:13: note: Returning zero (loaded from 'value')
            return value;
            ^~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:182:33: note: Returning from 'getPageSize'
        const auto dbPageSize = getPageSize(*mDb);
                                ^~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:182:9: note: 'dbPageSize' initialized to 0
        const auto dbPageSize = getPageSize(*mDb);
        ^~~~~~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:183:43: note: Division by zero
        setMaxPageCount(*mDb, maxFileSize / dbPageSize + static_cast<std::uint64_t>((maxFileSize % dbPageSize) != 0));
                              ~~~~~~~~~~~~^~~~~~~~~~~~
 2022-07-06 13:52:28 +02:00
elsid
f1ded70366
Remove redundant condition 
apps/openmw/mwmechanics/character.cpp:500:14: warning: redundant condition 'isRealWeapon' [bugprone-redundant-branch-condition]
        else if (isRealWeapon)
             ^~~~~~~~~~~~~~~~~
 2022-07-06 13:52:25 +02:00
Alexei Kotov
c38e342c99 Merge branch 'psi29a-master-patch-21668' into 'master' 
DeathKnockOut when KnockOut...

See merge request OpenMW/openmw!2106
 2022-07-06 10:52:48 +00:00
psi29a
95a6fa8d0c DeathKnockOut when KnockOut... 2022-07-06 10:48:22 +00:00
psi29a
bd8b2b005b Merge branch 'android-no-space-left-workaround' into 'master' 
disable android's install step to work around no space left

See merge request OpenMW/openmw!2105
 2022-07-06 09:31:16 +00:00
psi29a
b2cf0918f5 Update .gitlab-ci.yml 2022-07-06 08:41:54 +00:00
psi29a
a793749aa3 Merge branch 'sun_fix' into 'master' 
Flickering sun

Closes #6854

See merge request OpenMW/openmw!2104
 2022-07-06 08:39:51 +00:00
psi29a
9519764a74 Update .gitlab-ci.yml 2022-07-06 07:56:31 +00:00
psi29a
94ea3e3a23 disable android's install step to work around no space left 2022-07-06 07:54:23 +00:00
psi29a
9ed4d17f8a Merge branch 'hidden_marker' into 'master' 
Use single implementation to check whether marker is hidden

See merge request OpenMW/openmw!2096
 2022-07-06 07:30:56 +00:00
glassmancody.info
89bc756732 tmp_sun_fix 2022-07-05 23:47:23 -07:00
psi29a
b2766b0650 Merge branch 'sdl2_point_22' into 'master' 
Fix mouse clicking with sdl2 2.0.22

Closes #6678

See merge request OpenMW/openmw!2101
 2022-07-06 06:32:24 +00:00
jvoisin
2a16fddf21 Merge branch 'psi29a-master-patch-40957' into 'master' 
No attack animation while blocking fix

Closes #6855

See merge request OpenMW/openmw!2103
 2022-07-05 21:43:56 +00:00
AnyOldName3
2bb28b5e27 Merge branch 'fix_typo' into 'master' 
Fix particle flags typo (#6857)

Closes #6857

See merge request OpenMW/openmw!2102
 2022-07-05 19:31:37 +00:00
psi29a
cec707e994 No attack animation while blocking fix 2022-07-05 18:29:21 +00:00
psi29a
715b8497f9 Merge branch 'live_cell_ref' into 'master' 
Use descriptive names for range elements

See merge request OpenMW/openmw!2092
 2022-07-05 18:26:40 +00:00
glassmancody.info
0954597fa7 fix typo with wrong flags in particle nifloader 2022-07-05 11:00:28 -07:00
psi29a
f8f2e00eca Fix mouse clicking with sdl2 2.0.22 2022-07-05 17:44:22 +00:00
psi29a
7470f6971d Merge branch 'TisIPickles27-test' into 'master' 
[WIP] Maybe force dedicated GPU on dual-AMD machines

See merge request OpenMW/openmw!1214
 2022-07-05 15:56:02 +00:00
psi29a
33a5f27b18 Merge branch 'soft_docs' into 'master' 
Update soft effect docs

See merge request OpenMW/openmw!2090
 2022-07-05 15:51:23 +00:00
psi29a
46694a5e81 Merge branch 'coverity' into 'master' 
Coverity issues, part 2

See merge request OpenMW/openmw!2100
 2022-07-05 15:47:19 +00:00
Andrei Kortunov
38042fd7a2 Init missing variables 2022-07-05 17:47:52 +04:00
Andrei Kortunov
aed0da46a9 Check a result of dynamic_cast 2022-07-05 17:47:49 +04:00
jvoisin
f451b09f10 Merge branch 'rm_stream_include' into 'master' 
Remove redundant ostream, istream, iostream and sstream includes

See merge request OpenMW/openmw!2097
 2022-07-05 11:00:50 +00:00
Petr Mikheev
1fa25f48db Merge branch 'ci_integration_tests' into 'master' 
Run integration tests in CI

See merge request OpenMW/openmw!1995
 2022-07-05 10:22:16 +00:00
psi29a
9003e83470 Merge branch 'particle_vertex' into 'master' 
Soft enforce vertex lighting on particle systems (i.e. with exception of normal maps)

See merge request OpenMW/openmw!2098
 2022-07-05 10:15:36 +00:00
psi29a
85a8359b36 Merge branch 'only_when_necassary' into 'master' 
Conditional soft particles

See merge request OpenMW/openmw!2078
 2022-07-05 10:14:32 +00:00
glassmancody.info
7bed2208e9 only force ppl on particles with normal maps 2022-07-04 18:28:29 -07:00
elsid
bef15edf0b
Remove redundant ostream, istream, iostream and sstream includes 
* Replace by std::to_string and operator+ where possible.
* Move the code requiring to include <sstream> from .hpp to .cpp files.
 2022-07-05 01:41:28 +02:00
elsid
20c15b30de
Move getLuaType out of MWWorld::PtrBase 
This function is used only for Lua related code and don't need to be present
everywhere ptr.hpp is included.
 2022-07-05 00:53:19 +02:00
AnyOldName3
c81e94ebee Merge branch 'store_multiview' into 'master' 
Avoid calling getMultiview from ~StereoFrustumManager

See merge request OpenMW/openmw!2091
 2022-07-04 22:38:09 +00:00
elsid
4613840914
Use single implementation to check whether marker is hidden 2022-07-05 00:36:37 +02:00
elsid
c476437b6e
Mark Actors member functions as const where possible 2022-07-04 22:37:27 +02:00
elsid
ae4ec0a1d0
Convert static const to constexpr where possible 2022-07-04 22:16:38 +02:00
elsid
2ec757ab0f
Remove unnecessary member functions from Actors 2022-07-04 22:16:38 +02:00