Commit Graph

6102 Commits (38ee6d285d5ce80a9273bda4b0e739f375d3fb90)

Author SHA1 Message Date
Petr Mikheev 38ee6d285d Use std::string_view in VFS::Manager 3 years ago
elsid 9398e97600
Avoid manual memory management for VFS archives 3 years ago
jvoisin 2ef2e93a46 Merge branch 'collection-lowercase' into 'master'
Makes key inside Collection::getCollection use lowercase

Closes #6483

See merge request OpenMW/openmw!2135
3 years ago
ζeh Matt 92e209c62a
Simplify getIsHungAppWindow 3 years ago
Matt 888d009a1e Apply 1 suggestion(s) to 1 file(s) 3 years ago
Matt 32d50765ab Apply 1 suggestion(s) to 1 file(s) 3 years ago
Igor Fedosov 68887e79a0 Makes key inside Collection::getCollection use lowercase 3 years ago
ζeh Matt 0d625abde0
Declare utf8ToUtf16 static 3 years ago
ζeh Matt 100e400fed
Dynamically obtain the function pointer to IsHungAppWindow 3 years ago
psi29a 80adcf3c88 Merge branch 'maybe_lock' into 'master'
Refactor Maybe*Locks

See merge request OpenMW/openmw!2126
3 years ago
Andrei Kortunov d3da09878d Drop line about non-existent UnrefQueue 3 years ago
elsid 22ed6d5c1e
Use unsigned to define number of threads 3 years ago
psi29a 54db3a97bb Merge branch 'multiview-refactor' into 'master'
[Multiview] refactoring

See merge request OpenMW/openmw!2122
3 years ago
Petr Mikheev 9fbcc5df5e Merge branch 'localization' into 'master'
Use Lua's YAML-based localization for MyGUI

See merge request OpenMW/openmw!2099
3 years ago
Andrei Kortunov ccbb5e03fb Use YAML files to translate MyGUI's localization tags 3 years ago
Mads Buvik Sandvei b277fa48c7 Refactor multiview to avoid littering OSG_HAS_MULTIVIEW and multiview-related uniforms around the code, keep them all in multiview.cpp. 3 years ago
psi29a aaaeed572a Merge branch 'fix_6841' into 'master'
Treat empty `RootCollisionNode` in NIF as NC flag and generate VisualOnly collision shape

Closes #6841

See merge request OpenMW/openmw!2084
3 years ago
Petr Mikheev 8b8c304953 Treat empty `RootCollisionNode` in NIF as NCC flag and generate CameraOnly collision shape 3 years ago
Petr Mikheev dc3ba3a75b Fix #6862 3 years ago
elsid 9ac3bb753e
Move declaration private static member variables of LightManager to .cpp
There is no need to expose them to other translation units.
3 years ago
elsid 4211cf1c24
Use uniform indent and apply openmw naming policy 3 years ago
psi29a 510a9b9a5e Merge branch 'navmeshtilescache_find' into 'master'
Avoid redundant copy when finding item in NavMeshTilesCache

See merge request OpenMW/openmw!2109
3 years ago
elsid 6fb7af3b63
Avoid redundant copy when finding item in NavMeshTilesCache
std::make_tuple returns a tuple for types with removed references which makes it
to copy arguments. std::tie leaves references.
3 years ago
elsid b4f12aace1
Explicitly ignore result of std::unique_ptr::release call
components/nifbullet/bulletnifloader.cpp:206:13: warning: the value returned by this function should be used [bugprone-unused-return-value]
            boxShape.release();
            ^~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:232:13: warning: the value returned by this function should be used [bugprone-unused-return-value]
            child.release();
            ^~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:233:13: warning: the value returned by this function should be used [bugprone-unused-return-value]
            mStaticMesh.release();
            ^~~~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:240:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        mStaticMesh.release();
        ^~~~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:246:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        mAvoidStaticMesh.release();
        ^~~~~~~~~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:411:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        childMesh.release();
        ^~~~~~~~~~~~~~~~~~~

components/nifbullet/bulletnifloader.cpp:425:9: warning: the value returned by this function should be used [bugprone-unused-return-value]
        childShape.release();
        ^~~~~~~~~~~~~~~~~~~~
3 years ago
elsid 72bda2bd10
Avoid redundant initialization
components/nifbullet/bulletnifloader.cpp:79:24: warning: Value stored to 'a' during its initialization is never read [clang-analyzer-deadcode.DeadStores]
        unsigned short a = strip[0], b = strip[0], c = strip[1];
                       ^   ~~~~~~~~
3 years ago
elsid 5b9ca3b979
Avoid possible division by zero
components/detournavigator/navmeshdb.cpp:183:43: warning: Division by zero [clang-analyzer-core.DivideZero]
        setMaxPageCount(*mDb, maxFileSize / dbPageSize + static_cast<std::uint64_t>((maxFileSize % dbPageSize) != 0));
                              ~~~~~~~~~~~~^~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:182:33: note: Calling 'getPageSize'
        const auto dbPageSize = getPageSize(*mDb);
                                ^~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:144:13: note: 'value' initialized to 0
            std::uint64_t value = 0;
            ^~~~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:145:13: note: Calling 'request<DetourNavigator::(anonymous namespace)::GetPageSize, unsigned long *, >'
            request(db, statement, &value, 1);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
components/sqlite3/request.hpp:254:64: note: Left side of '&&' is false
            for (std::size_t i = 0; executeStep(db, statement) && i < max; ++i)
                                                               ^
components/detournavigator/navmeshdb.cpp:145:13: note: Returning from 'request<DetourNavigator::(anonymous namespace)::GetPageSize, unsigned long *, >'
            request(db, statement, &value, 1);
            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:146:13: note: Returning zero (loaded from 'value')
            return value;
            ^~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:182:33: note: Returning from 'getPageSize'
        const auto dbPageSize = getPageSize(*mDb);
                                ^~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:182:9: note: 'dbPageSize' initialized to 0
        const auto dbPageSize = getPageSize(*mDb);
        ^~~~~~~~~~~~~~~~~~~~~
components/detournavigator/navmeshdb.cpp:183:43: note: Division by zero
        setMaxPageCount(*mDb, maxFileSize / dbPageSize + static_cast<std::uint64_t>((maxFileSize % dbPageSize) != 0));
                              ~~~~~~~~~~~~^~~~~~~~~~~~
3 years ago
AnyOldName3 2bb28b5e27 Merge branch 'fix_typo' into 'master'
Fix particle flags typo (#6857)

Closes #6857

See merge request OpenMW/openmw!2102
3 years ago
glassmancody.info 0954597fa7 fix typo with wrong flags in particle nifloader 3 years ago
Andrei Kortunov 38042fd7a2 Init missing variables 3 years ago
Andrei Kortunov aed0da46a9 Check a result of dynamic_cast 3 years ago
jvoisin f451b09f10 Merge branch 'rm_stream_include' into 'master'
Remove redundant ostream, istream, iostream and sstream includes

See merge request OpenMW/openmw!2097
3 years ago
psi29a 9003e83470 Merge branch 'particle_vertex' into 'master'
Soft enforce vertex lighting on particle systems (i.e. with exception of normal maps)

See merge request OpenMW/openmw!2098
3 years ago
psi29a 85a8359b36 Merge branch 'only_when_necassary' into 'master'
Conditional soft particles

See merge request OpenMW/openmw!2078
3 years ago
glassmancody.info 7bed2208e9 only force ppl on particles with normal maps 3 years ago
elsid bef15edf0b
Remove redundant ostream, istream, iostream and sstream includes
* Replace by std::to_string and operator+ where possible.
* Move the code requiring to include <sstream> from .hpp to .cpp files.
3 years ago
elsid 782d3d9680
Avoid calling getMultiview from ~StereoFrustumManager
Otherwise coverity complains about a function throwing exceptions called from a
destructor.
3 years ago
Andrei Kortunov f6a07ab603 Merge branch 'fix_image_button_scale' into 'master'
Use float based scale factor for ImageButton texture (#6849)

Closes #6849

See merge request OpenMW/openmw!2076
3 years ago
elsid a16c55c93f
Use float based scale factor for ImageButton texture 3 years ago
jvoisin bbcc12262f Merge branch 'fix_icu_from_utf8_debug_crash' into 'master'
Avoid constructing icu::StringPiece from std::string directly (#6782)

Closes #6782

See merge request OpenMW/openmw!2073
3 years ago
jvoisin 498a835b77 Merge branch 'coverity' into 'master'
Fix some Coverity issues

See merge request OpenMW/openmw!2082
3 years ago
Andrei Kortunov fe785ea788 Don't cast away const when we can avoid it 3 years ago
Andrei Kortunov 14b5674d32 Init missing data members 3 years ago
Andrei Kortunov 124db67496 Add an assert to detect possible nullptr dereference 3 years ago
Andrei Kortunov 5d94a94a98 Use a Boost API to resolve symlinks instead of low-level code 3 years ago
Andrei Kortunov 7cce341822 Fix initializer 3 years ago
Andrei Kortunov d2a1cc954f Remove unused variable 3 years ago
Andrei Kortunov aa349f2ed9 Initialize some missing variables 3 years ago
Andrei Kortunov 523ad825c2 There is no point to compare an unsigned value with 0 3 years ago
glassmancody.info a0265ffb89 only enable soft particles when enabled in settings 3 years ago
AnyOldName3 6609243c87 Merge branch 'dont_notice_me_launcher_senpai' into 'master'
Don't load content entries from global and local configs

Closes #6441

See merge request OpenMW/openmw!2068
3 years ago