40 Commits (8cf431aeb2b80907e25d941ee6078da0236720e7)

Author	SHA1	Message	Date
Andrei Kortunov	5836bd8d87	Remove redundant include	2 years ago
Andrei Kortunov	9a7c57874d	Do not use Qt streams with legacy encodings in the Wizard code	2 years ago
clang-format-bot	ddb0522bbf	Apply clang-format to code base	2 years ago
Mat	405a5c5d25	functor-based Qt signal-slot syntax wizard	2 years ago
elsid	c197896765	Use unique_ptr for Wizard::InstallationPage members	2 years ago
jvoisin	8b9ed57348	Clean up Qt includes	3 years ago
Eris Caffee	db84d9e649	Issue 2766 Warn user of old MW version detected	3 years ago
Capostrophic	21c49ca1b0	Make Wizard less shy (bug #4493)	5 years ago
tri4ng1e	d4d1703bcf	Some PVS-Studio and cppcheck fixes ... cppcheck: [apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types. [apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types. [apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types. [apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference. [apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference. [apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated. [apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container. [apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list. PVS-Studio: apps/opencs/model/filter/parser.cpp 582 warn V560 A part of conditional expression is always true: allowPredefined. apps/opencs/view/world/referencecreator.cpp 67 warn V547 Expression '!errors.empty()' is always false. apps/opencs/view/world/referencecreator.cpp 74 warn V547 Expression '!errors.empty()' is always false. apps/opencs/view/doc/loader.cpp 170 warn V560 A part of conditional expression is always true: !completed. apps/opencs/view/doc/loader.cpp 170 warn V560 A part of conditional expression is always true: !error.empty(). apps/opencs/model/tools/pathgridcheck.cpp 32 err V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34. apps/opencs/model/world/refidadapterimp.cpp 1376 err V547 Expression 'subColIndex < 3' is always true. apps/openmw/mwgui/widgets.hpp 318 warn V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179. apps/openmw/mwgui/widgets.hpp 319 warn V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180. apps/openmw/mwgui/widgets.hpp 320 warn V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181 apps/openmw/mwmechanics/actors.cpp 1425 warn V547 Expression '!detected' is always true. apps/openmw/mwmechanics/character.cpp 2155 err V547 Expression 'mode == 0' is always true. apps/openmw/mwmechanics/character.cpp 1192 warn V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present. apps/openmw/mwmechanics/character.cpp 521 warn V560 A part of conditional expression is always true: (idle == mIdleState). apps/openmw/mwmechanics/pathfinding.cpp 317 err V547 Expression 'mPath.size() >= 2' is always true. apps/openmw/mwscript/interpretercontext.cpp 409 warn V560 A part of conditional expression is always false: rank > 9. apps/openmw/mwgui/windowbase.cpp 28 warn V560 A part of conditional expression is always true: !visible. apps/openmw/mwgui/journalwindow.cpp 561 warn V547 Expression '!mAllQuests' is always false. apps/openmw/mwgui/referenceinterface.cpp 18 warn V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16. apps/openmw/mwworld/scene.cpp 463 warn V547 Expression 'adjustPlayerPos' is always true. apps/openmw/mwworld/worldimp.cpp 409 err V766 An item with the same key '"sCompanionShare"' has already been added. apps/openmw/mwworld/cellstore.cpp 691 warn V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691. apps/openmw/mwworld/weather.cpp 1125 warn V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125. apps/openmw/mwworld/weather.cpp 1137 warn V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137. apps/wizard/unshield/unshieldworker.cpp 475 warn V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression. apps/wizard/installationpage.cpp 163 warn V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected. components/fontloader/fontloader.cpp 427 err V547 Expression 'i == 1' is always true. components/nifosg/nifloader.cpp 282 warn V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282. components/esm/loadregn.cpp 119 err V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119. components/esm/cellref.cpp 178 warn V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178. components/esmterrain/storage.cpp 235 warn V560 A part of conditional expression is always true: colStart == 0. components/esmterrain/storage.cpp 237 warn V560 A part of conditional expression is always true: rowStart == 0.	7 years ago
Thunderforge	f41a4bb937	Changing "New Installation" to "Retail CD/DVD" for clarity	8 years ago
scrawl	2f9b404094	InstallationPage: properly exit the QThread (Fixes #2210)	9 years ago
Bret Curtis	dcfadeb51a	fix typo and annoying gcc/clang unused return values in crash catcher	10 years ago
scrawl	1e06f69d9e	Remove the "browse to existing installation" button, now replaced by the wizard ... Clean up some debug spam	10 years ago
pvdk	aa07a33906	Fixed most of the memory leaks and started working on correctly exiting the thread	11 years ago
pvdk	5d94cb112f	Fixed segfault bug due to accessing members of unitialized struct	11 years ago
pvdk	10d2ca82f7	Implemented a simple logger	11 years ago
pvdk	254fe0a424	Made install functions use file finding methods and improved error handling	11 years ago
pvdk	ef16b46148	Wizard now autodetects correct installation archive	11 years ago
pvdk	b2156351d8	Work in progress commit, working on data1.hdr autodetection	11 years ago
pvdk	3792b301e9	Wizard now runs the ini-importer to import settings from Morrowind.ini	11 years ago
pvdk	755c99df3c	Some minor fixes	11 years ago
pvdk	6916c0bc94	Wizard now writes valid Morrowind.ini files	11 years ago
pvdk	e8170adde5	Some minor changes, implemented suggestions	11 years ago
pvdk	5024f1bf77	Added a warning when trying to install tribunal after bloodmoon	11 years ago
pvdk	1262eab03a	Added some nice error messages to the installation process	11 years ago
pvdk	2736527e5a	Did some cleanup work on the unshield thread: more code re-use	11 years ago
pvdk	3fd88aca59	Re-added support for GoTY disks and added a messagebox, displayed when done	11 years ago
pvdk	8db333c8d0	Made the getter/setter functions thread-safe	11 years ago
pvdk	cdbf5c68b0	Implemented selection of installation media and added forgotten file	11 years ago
pvdk	0f7f3391f7	WIP: Working on the installation of addons	11 years ago
pvdk	691e007524	Redid the unshield thread stuff, this time the way it should be done	11 years ago
pvdk	3a55d88bac	Working on the installshield thread	11 years ago
pvdk	40486370d9	Working on the Unshield functionality	11 years ago
pvdk	445f96434e	Added Morrowind.ini detection logic	11 years ago
pvdk	8ea31e5050	Working on a Morrowind.ini reader	11 years ago
pvdk	30710bad70	Modified components widget so the checked items can be stored for all pages to access	11 years ago
pvdk	77fe73799a	Enabled language setting to be accessable from different pages	11 years ago
pvdk	d7f9604140	WIP: Working on the installation selection and added the ui for the language page	11 years ago
pvdk	0e1d3237fe	Added some logic to the page switching	11 years ago
pvdk	8162f8370b	Added all the pages to the wizard	11 years ago