Commit Graph

11 Commits (f85053d78c7d21484bcf49d75ab2a9fce5ce79f3)

Author SHA1 Message Date
Bo Svensson 4657c655b1 refactors parentFileIndices (#3211)
This PR aims to start addressing `ESM` design issues that have silenced errors we incorporated into groundcover `ESM` loading approaches.

- We move the resolution of `parentFileIndices` from `ESMStore` to `ESMReader` as suggested in a `TODO` comment.
- We improve a highly misleading comment which downplayed the significance of `parentFileIndices`.
- We document important preconditions.
- We move a user facing error message to the highest level and improve its context.
- We remove an inappropriate `setGlobalReaderList` method. We now pass this reader list into the method that requires it.
- We remove a thoroughly pointless optimisation of `Store<ESM::LandTexture>`'s construction that has unnecessarily depended on `getGlobalReaderList`.

There should be no functional changes for `master`, but this PR should remove an issue blocking PR #3208.
3 years ago
Petr Mikheev 47c89567fb Load LuaScriptsCfg from both *.omwscripts and *.omwaddon files. 3 years ago
AnyOldName3 fd4a62ce35 Use correct variable types when loading config for tests 4 years ago
Bret Curtis 5a824d0333 components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues 4 years ago
Evil Eye 6ad20ec9c7 Mutate base records when adding/removing spells 5 years ago
Andrei Kortunov e06f0b797a Replace all NULLs to nullptr 6 years ago
scrawl aae1aa3708 Adjust tests to work with esm_rewrite branch. 9 years ago
scrawl f91aae2350 Tests: add record overwrite test 9 years ago
scrawl 1e817a976f Tests: add record deletion test 9 years ago
scrawl 771193bae8 Tests: add content_diagnostics_test (requires some data files) 9 years ago
scrawl 38c155c579 Tests: add dialogue_merging_test (requires some data files) 9 years ago