mirror of
				https://github.com/OpenMW/openmw.git
				synced 2025-10-31 18:56:38 +00:00 
			
		
		
		
	cppcheck:
[apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference.
[apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference.
[apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated.
[apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container.
[apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list.
PVS-Studio:
apps/opencs/model/filter/parser.cpp  582  warn  V560 A part of conditional expression is always true: allowPredefined.
apps/opencs/view/world/referencecreator.cpp  67  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/world/referencecreator.cpp  74  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !completed.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !error.empty().
apps/opencs/model/tools/pathgridcheck.cpp  32  err  V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34.
apps/opencs/model/world/refidadapterimp.cpp  1376  err  V547 Expression 'subColIndex < 3' is always true.
apps/openmw/mwgui/widgets.hpp  318  warn  V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179.
apps/openmw/mwgui/widgets.hpp  319  warn  V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180.
apps/openmw/mwgui/widgets.hpp  320  warn  V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181
apps/openmw/mwmechanics/actors.cpp  1425  warn  V547 Expression '!detected' is always true.
apps/openmw/mwmechanics/character.cpp  2155  err  V547 Expression 'mode == 0' is always true.
apps/openmw/mwmechanics/character.cpp  1192  warn  V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present.
apps/openmw/mwmechanics/character.cpp  521  warn  V560 A part of conditional expression is always true: (idle == mIdleState).
apps/openmw/mwmechanics/pathfinding.cpp  317  err  V547 Expression 'mPath.size() >= 2' is always true.
apps/openmw/mwscript/interpretercontext.cpp  409  warn  V560 A part of conditional expression is always false: rank > 9.
apps/openmw/mwgui/windowbase.cpp  28  warn  V560 A part of conditional expression is always true: !visible.
apps/openmw/mwgui/journalwindow.cpp  561  warn  V547 Expression '!mAllQuests' is always false.
apps/openmw/mwgui/referenceinterface.cpp  18  warn  V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16.
apps/openmw/mwworld/scene.cpp  463  warn  V547 Expression 'adjustPlayerPos' is always true.
apps/openmw/mwworld/worldimp.cpp  409  err  V766 An item with the same key '"sCompanionShare"' has already been added.
apps/openmw/mwworld/cellstore.cpp  691  warn  V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691.
apps/openmw/mwworld/weather.cpp  1125  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125.
apps/openmw/mwworld/weather.cpp  1137  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137.
apps/wizard/unshield/unshieldworker.cpp  475  warn  V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression.
apps/wizard/installationpage.cpp  163  warn  V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected.
components/fontloader/fontloader.cpp  427  err  V547 Expression 'i == 1' is always true.
components/nifosg/nifloader.cpp  282  warn  V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282.
components/esm/loadregn.cpp  119  err  V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119.
components/esm/cellref.cpp  178  warn  V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178.
components/esmterrain/storage.cpp  235  warn  V560 A part of conditional expression is always true: colStart == 0.
components/esmterrain/storage.cpp  237  warn  V560 A part of conditional expression is always true: rowStart == 0.
		
	
			
		
			
				
	
	
		
			121 lines
		
	
	
	
		
			3.6 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			121 lines
		
	
	
	
		
			3.6 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| #include "loadregn.hpp"
 | |
| 
 | |
| #include "esmreader.hpp"
 | |
| #include "esmwriter.hpp"
 | |
| #include "defs.hpp"
 | |
| 
 | |
| namespace ESM
 | |
| {
 | |
|     unsigned int Region::sRecordId = REC_REGN;
 | |
| 
 | |
|     void Region::load(ESMReader &esm, bool &isDeleted)
 | |
|     {
 | |
|         isDeleted = false;
 | |
| 
 | |
|         bool hasName = false;
 | |
|         while (esm.hasMoreSubs())
 | |
|         {
 | |
|             esm.getSubName();
 | |
|             switch (esm.retSubName().intval)
 | |
|             {
 | |
|                 case ESM::SREC_NAME:
 | |
|                     mId = esm.getHString();
 | |
|                     hasName = true;
 | |
|                     break;
 | |
|                 case ESM::FourCC<'F','N','A','M'>::value:
 | |
|                     mName = esm.getHString();
 | |
|                     break;
 | |
|                 case ESM::FourCC<'W','E','A','T'>::value:
 | |
|                 {
 | |
|                     esm.getSubHeader();
 | |
|                     if (esm.getVer() == VER_12)
 | |
|                     {
 | |
|                         mData.mA = 0;
 | |
|                         mData.mB = 0;
 | |
|                         esm.getExact(&mData, sizeof(mData) - 2);
 | |
|                     }
 | |
|                     else if (esm.getVer() == VER_13)
 | |
|                     {
 | |
|                         // May include the additional two bytes (but not necessarily)
 | |
|                         if (esm.getSubSize() == sizeof(mData))
 | |
|                         {
 | |
|                             esm.getExact(&mData, sizeof(mData));
 | |
|                         }
 | |
|                         else
 | |
|                         {
 | |
|                             mData.mA = 0;
 | |
|                             mData.mB = 0;
 | |
|                             esm.getExact(&mData, sizeof(mData)-2);
 | |
|                         }
 | |
|                     }
 | |
|                     else
 | |
|                     {
 | |
|                         esm.fail("Don't know what to do in this version");
 | |
|                     }
 | |
|                     break;
 | |
|                 }
 | |
|                 case ESM::FourCC<'B','N','A','M'>::value:
 | |
|                     mSleepList = esm.getHString();
 | |
|                     break;
 | |
|                 case ESM::FourCC<'C','N','A','M'>::value:
 | |
|                     esm.getHT(mMapColor);
 | |
|                     break;
 | |
|                 case ESM::FourCC<'S','N','A','M'>::value:
 | |
|                 {
 | |
|                     SoundRef sr;
 | |
|                     esm.getHT(sr, 33);
 | |
|                     mSoundList.push_back(sr);
 | |
|                     break;
 | |
|                 }
 | |
|                 case ESM::SREC_DELE:
 | |
|                     esm.skipHSub();
 | |
|                     isDeleted = true;
 | |
|                     break;
 | |
|                 default:
 | |
|                     esm.fail("Unknown subrecord");
 | |
|                     break;
 | |
|             }
 | |
|         }
 | |
| 
 | |
|         if (!hasName)
 | |
|             esm.fail("Missing NAME subrecord");
 | |
|     }
 | |
| 
 | |
|     void Region::save(ESMWriter &esm, bool isDeleted) const
 | |
|     {
 | |
|         esm.writeHNCString("NAME", mId);
 | |
| 
 | |
|         if (isDeleted)
 | |
|         {
 | |
|             esm.writeHNCString("DELE", "");
 | |
|             return;
 | |
|         }
 | |
| 
 | |
|         esm.writeHNOCString("FNAM", mName);
 | |
| 
 | |
|         if (esm.getVersion() == VER_12)
 | |
|             esm.writeHNT("WEAT", mData, sizeof(mData) - 2);
 | |
|         else
 | |
|             esm.writeHNT("WEAT", mData);
 | |
| 
 | |
|         esm.writeHNOCString("BNAM", mSleepList);
 | |
| 
 | |
|         esm.writeHNT("CNAM", mMapColor);
 | |
|         for (std::vector<SoundRef>::const_iterator it = mSoundList.begin(); it != mSoundList.end(); ++it)
 | |
|         {
 | |
|             esm.writeHNT<SoundRef>("SNAM", *it);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     void Region::blank()
 | |
|     {
 | |
|         mData.mClear = mData.mCloudy = mData.mFoggy = mData.mOvercast = mData.mRain =
 | |
|             mData.mThunder = mData.mAsh, mData.mBlight = mData.mA = mData.mB = 0;
 | |
| 
 | |
|         mMapColor = 0;
 | |
| 
 | |
|         mName.clear();
 | |
|         mSleepList.clear();
 | |
|         mSoundList.clear();
 | |
|     }
 | |
| }
 |