mirror of
				https://github.com/OpenMW/openmw.git
				synced 2025-11-04 04:56:39 +00:00 
			
		
		
		
	cppcheck:
[apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference.
[apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference.
[apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated.
[apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container.
[apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list.
PVS-Studio:
apps/opencs/model/filter/parser.cpp  582  warn  V560 A part of conditional expression is always true: allowPredefined.
apps/opencs/view/world/referencecreator.cpp  67  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/world/referencecreator.cpp  74  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !completed.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !error.empty().
apps/opencs/model/tools/pathgridcheck.cpp  32  err  V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34.
apps/opencs/model/world/refidadapterimp.cpp  1376  err  V547 Expression 'subColIndex < 3' is always true.
apps/openmw/mwgui/widgets.hpp  318  warn  V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179.
apps/openmw/mwgui/widgets.hpp  319  warn  V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180.
apps/openmw/mwgui/widgets.hpp  320  warn  V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181
apps/openmw/mwmechanics/actors.cpp  1425  warn  V547 Expression '!detected' is always true.
apps/openmw/mwmechanics/character.cpp  2155  err  V547 Expression 'mode == 0' is always true.
apps/openmw/mwmechanics/character.cpp  1192  warn  V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present.
apps/openmw/mwmechanics/character.cpp  521  warn  V560 A part of conditional expression is always true: (idle == mIdleState).
apps/openmw/mwmechanics/pathfinding.cpp  317  err  V547 Expression 'mPath.size() >= 2' is always true.
apps/openmw/mwscript/interpretercontext.cpp  409  warn  V560 A part of conditional expression is always false: rank > 9.
apps/openmw/mwgui/windowbase.cpp  28  warn  V560 A part of conditional expression is always true: !visible.
apps/openmw/mwgui/journalwindow.cpp  561  warn  V547 Expression '!mAllQuests' is always false.
apps/openmw/mwgui/referenceinterface.cpp  18  warn  V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16.
apps/openmw/mwworld/scene.cpp  463  warn  V547 Expression 'adjustPlayerPos' is always true.
apps/openmw/mwworld/worldimp.cpp  409  err  V766 An item with the same key '"sCompanionShare"' has already been added.
apps/openmw/mwworld/cellstore.cpp  691  warn  V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691.
apps/openmw/mwworld/weather.cpp  1125  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125.
apps/openmw/mwworld/weather.cpp  1137  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137.
apps/wizard/unshield/unshieldworker.cpp  475  warn  V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression.
apps/wizard/installationpage.cpp  163  warn  V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected.
components/fontloader/fontloader.cpp  427  err  V547 Expression 'i == 1' is always true.
components/nifosg/nifloader.cpp  282  warn  V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282.
components/esm/loadregn.cpp  119  err  V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119.
components/esm/cellref.cpp  178  warn  V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178.
components/esmterrain/storage.cpp  235  warn  V560 A part of conditional expression is always true: colStart == 0.
components/esmterrain/storage.cpp  237  warn  V560 A part of conditional expression is always true: rowStart == 0.
		
	
			
		
			
				
	
	
		
			201 lines
		
	
	
	
		
			5.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			201 lines
		
	
	
	
		
			5.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
#include "loader.hpp"
 | 
						|
 | 
						|
#include <QVBoxLayout>
 | 
						|
#include <QLabel>
 | 
						|
#include <QProgressBar>
 | 
						|
#include <QCursor>
 | 
						|
#include <QDialogButtonBox>
 | 
						|
#include <QCloseEvent>
 | 
						|
#include <QListWidget>
 | 
						|
 | 
						|
#include "../../model/doc/document.hpp"
 | 
						|
 | 
						|
void CSVDoc::LoadingDocument::closeEvent (QCloseEvent *event)
 | 
						|
{
 | 
						|
    event->ignore();
 | 
						|
    cancel();
 | 
						|
}
 | 
						|
 | 
						|
CSVDoc::LoadingDocument::LoadingDocument (CSMDoc::Document *document)
 | 
						|
: mDocument (document), mAborted (false), mMessages (0), mTotalRecords (0)
 | 
						|
{
 | 
						|
    setWindowTitle (QString::fromUtf8((std::string("Opening ") + document->getSavePath().filename().string()).c_str()));
 | 
						|
 | 
						|
    setMinimumWidth (400);
 | 
						|
 | 
						|
    mLayout = new QVBoxLayout (this);
 | 
						|
 | 
						|
    // file progress
 | 
						|
    mFile = new QLabel (this);
 | 
						|
 | 
						|
    mLayout->addWidget (mFile);
 | 
						|
 | 
						|
    mFileProgress = new QProgressBar (this);
 | 
						|
 | 
						|
    mLayout->addWidget (mFileProgress);
 | 
						|
 | 
						|
    int size = static_cast<int> (document->getContentFiles().size())+1;
 | 
						|
    if (document->isNew())
 | 
						|
        --size;
 | 
						|
 | 
						|
    mFileProgress->setMinimum (0);
 | 
						|
    mFileProgress->setMaximum (size);
 | 
						|
    mFileProgress->setTextVisible (true);
 | 
						|
    mFileProgress->setValue (0);
 | 
						|
 | 
						|
    // record progress
 | 
						|
    mLayout->addWidget (mRecords = new QLabel ("Records", this));
 | 
						|
 | 
						|
    mRecordProgress = new QProgressBar (this);
 | 
						|
 | 
						|
    mLayout->addWidget (mRecordProgress);
 | 
						|
 | 
						|
    mRecordProgress->setMinimum (0);
 | 
						|
    mRecordProgress->setTextVisible (true);
 | 
						|
    mRecordProgress->setValue (0);
 | 
						|
 | 
						|
    // error message
 | 
						|
    mError = new QLabel (this);
 | 
						|
    mError->setWordWrap (true);
 | 
						|
 | 
						|
    mLayout->addWidget (mError);
 | 
						|
 | 
						|
    // buttons
 | 
						|
    mButtons = new QDialogButtonBox (QDialogButtonBox::Cancel, Qt::Horizontal, this);
 | 
						|
 | 
						|
    mLayout->addWidget (mButtons);
 | 
						|
 | 
						|
    setLayout (mLayout);
 | 
						|
 | 
						|
    move (QCursor::pos());
 | 
						|
 | 
						|
    show();
 | 
						|
 | 
						|
    connect (mButtons, SIGNAL (rejected()), this, SLOT (cancel()));
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::LoadingDocument::nextStage (const std::string& name, int totalRecords)
 | 
						|
{
 | 
						|
    mFile->setText (QString::fromUtf8 (("Loading: " + name).c_str()));
 | 
						|
 | 
						|
    mFileProgress->setValue (mFileProgress->value()+1);
 | 
						|
 | 
						|
    mRecordProgress->setValue (0);
 | 
						|
    mRecordProgress->setMaximum (totalRecords>0 ? totalRecords : 1);
 | 
						|
 | 
						|
    mTotalRecords = totalRecords;
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::LoadingDocument::nextRecord (int records)
 | 
						|
{
 | 
						|
    if (records<=mTotalRecords)
 | 
						|
    {
 | 
						|
        mRecordProgress->setValue (records);
 | 
						|
 | 
						|
        std::ostringstream stream;
 | 
						|
 | 
						|
        stream << "Records: " << records << " of " << mTotalRecords;
 | 
						|
 | 
						|
        mRecords->setText (QString::fromUtf8 (stream.str().c_str()));
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::LoadingDocument::abort (const std::string& error)
 | 
						|
{
 | 
						|
    mAborted = true;
 | 
						|
    mError->setText (QString::fromUtf8 (("<font color=red>Loading failed: " + error + "</font>").c_str()));
 | 
						|
    mButtons->setStandardButtons (QDialogButtonBox::Close);
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::LoadingDocument::addMessage (const std::string& message)
 | 
						|
{
 | 
						|
    if (!mMessages)
 | 
						|
    {
 | 
						|
        mMessages = new QListWidget (this);
 | 
						|
        mLayout->insertWidget (4, mMessages);
 | 
						|
    }
 | 
						|
 | 
						|
    new QListWidgetItem (QString::fromUtf8 (message.c_str()), mMessages);
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::LoadingDocument::cancel()
 | 
						|
{
 | 
						|
    if (!mAborted)
 | 
						|
        emit cancel (mDocument);
 | 
						|
    else
 | 
						|
    {
 | 
						|
        emit close (mDocument);
 | 
						|
        deleteLater();
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
 | 
						|
CSVDoc::Loader::Loader() {}
 | 
						|
 | 
						|
CSVDoc::Loader::~Loader()
 | 
						|
{
 | 
						|
    for (std::map<CSMDoc::Document *, LoadingDocument *>::iterator iter (mDocuments.begin());
 | 
						|
        iter!=mDocuments.end(); ++iter)
 | 
						|
        delete iter->second;
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::Loader::add (CSMDoc::Document *document)
 | 
						|
{
 | 
						|
    LoadingDocument *loading = new LoadingDocument (document);
 | 
						|
    mDocuments.insert (std::make_pair (document, loading));
 | 
						|
 | 
						|
    connect (loading, SIGNAL (cancel (CSMDoc::Document *)),
 | 
						|
        this, SIGNAL (cancel (CSMDoc::Document *)));
 | 
						|
    connect (loading, SIGNAL (close (CSMDoc::Document *)),
 | 
						|
        this, SIGNAL (close (CSMDoc::Document *)));
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::Loader::loadingStopped (CSMDoc::Document *document, bool completed,
 | 
						|
    const std::string& error)
 | 
						|
{
 | 
						|
    std::map<CSMDoc::Document *, LoadingDocument *>::iterator iter = mDocuments.begin();
 | 
						|
 | 
						|
    for (; iter!=mDocuments.end(); ++iter)
 | 
						|
        if (iter->first==document)
 | 
						|
            break;
 | 
						|
 | 
						|
    if (iter==mDocuments.end())
 | 
						|
        return;
 | 
						|
 | 
						|
    if (completed || error.empty())
 | 
						|
    {
 | 
						|
        delete iter->second;
 | 
						|
        mDocuments.erase (iter);
 | 
						|
    }
 | 
						|
    else
 | 
						|
    {
 | 
						|
        iter->second->abort (error);
 | 
						|
        // Leave the window open for now (wait for the user to close it)
 | 
						|
        mDocuments.erase (iter);
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::Loader::nextStage (CSMDoc::Document *document, const std::string& name,
 | 
						|
    int totalRecords)
 | 
						|
{
 | 
						|
    std::map<CSMDoc::Document *, LoadingDocument *>::iterator iter = mDocuments.find (document);
 | 
						|
 | 
						|
    if (iter!=mDocuments.end())
 | 
						|
        iter->second->nextStage (name, totalRecords);
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::Loader::nextRecord (CSMDoc::Document *document, int records)
 | 
						|
{
 | 
						|
    std::map<CSMDoc::Document *, LoadingDocument *>::iterator iter = mDocuments.find (document);
 | 
						|
 | 
						|
    if (iter!=mDocuments.end())
 | 
						|
        iter->second->nextRecord (records);
 | 
						|
}
 | 
						|
 | 
						|
void CSVDoc::Loader::loadMessage (CSMDoc::Document *document, const std::string& message)
 | 
						|
{
 | 
						|
    std::map<CSMDoc::Document *, LoadingDocument *>::iterator iter = mDocuments.find (document);
 | 
						|
 | 
						|
    if (iter!=mDocuments.end())
 | 
						|
        iter->second->addMessage (message);
 | 
						|
}
 |