1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-01-22 22:53:53 +00:00
openmw/apps/openmw_test_suite
Bo Svensson 4657c655b1 refactors parentFileIndices (#3211)
This PR aims to start addressing `ESM` design issues that have silenced errors we incorporated into groundcover `ESM` loading approaches.

- We move the resolution of `parentFileIndices` from `ESMStore` to `ESMReader` as suggested in a `TODO` comment.
- We improve a highly misleading comment which downplayed the significance of `parentFileIndices`.
- We document important preconditions.
- We move a user facing error message to the highest level and improve its context.
- We remove an inappropriate `setGlobalReaderList` method. We now pass this reader list into the method that requires it.
- We remove a thoroughly pointless optimisation of `Store<ESM::LandTexture>`'s construction that has unnecessarily depended on `getGlobalReaderList`.

There should be no functional changes for `master`, but this PR should remove an issue blocking PR #3208.
2021-11-03 11:07:28 +01:00
..
detournavigator Remove redundant BulletShape getters 2021-10-30 03:44:08 +02:00
esm Use std::variant for ESM::Variant implementation 2021-04-08 19:39:31 +02:00
esmloader Merge branch 'fix_windows_tests' into 'master' 2021-10-22 12:35:10 +00:00
lua Redesign LuaUtil::ScriptsContainer to work with ScriptsConfiguration 2021-10-26 21:32:48 +02:00
misc Add functions to compress/decompress vector of bytes 2021-10-18 20:46:22 +02:00
mwdialogue Fix keyword search when the keyword is preceded by a non whitespace non alpha character 2021-10-07 13:26:40 +00:00
mwscript Test binary operators 2021-10-30 12:23:14 +02:00
mwworld refactors parentFileIndices (#3211) 2021-11-03 11:07:28 +01:00
nifloader Expect nif node children to have parent 2021-11-02 22:44:33 +01:00
openmw Add tests for openmw options 2021-10-05 22:51:12 +02:00
settings Add tests for settings parser 2019-10-21 22:47:24 +02:00
shader Correctly resetting line numbering during shader processing. 2020-10-03 14:22:34 +02:00
sqlite3 Add sqlite3 helpers 2021-10-16 17:43:08 +02:00
CMakeLists.txt Start adding compiler tests 2021-10-30 10:42:08 +02:00
openmw_test_suite.cpp Fix tests on windows 2021-10-21 19:48:31 +02:00