mirror of
https://github.com/OpenMW/openmw.git
synced 2025-10-31 02:56:38 +00:00
66c5944ecf
When it->second.mPosition->mPrev != value.mPrev value is first moved into *mPosition and then used to get mPrev. Since mPrev is RefId and it's copy-only type there is no real problem but coverity complains about it. Also enforce contract of insertInfo to support move-only types by adding a test for a value type with deleted copy constructors.
105 lines
2.8 KiB
C++
105 lines
2.8 KiB
C++
#ifndef OPENMW_COMPONENTS_ESM3_INFOORDER_H
|
|
#define OPENMW_COMPONENTS_ESM3_INFOORDER_H
|
|
|
|
#include "components/esm/refid.hpp"
|
|
|
|
#include <iterator>
|
|
#include <list>
|
|
#include <type_traits>
|
|
#include <unordered_map>
|
|
#include <utility>
|
|
|
|
namespace ESM
|
|
{
|
|
template <class T>
|
|
class InfoOrder
|
|
{
|
|
public:
|
|
const std::list<T>& getOrderedInfo() const { return mOrderedInfo; }
|
|
|
|
template <class V>
|
|
void insertInfo(V&& value, bool deleted)
|
|
{
|
|
static_assert(std::is_same_v<std::decay_t<V>, T>);
|
|
|
|
auto it = mInfoPositions.find(value.mId);
|
|
|
|
if (it != mInfoPositions.end() && it->second.mPosition->mPrev == value.mPrev)
|
|
{
|
|
*it->second.mPosition = std::forward<V>(value);
|
|
it->second.mDeleted = deleted;
|
|
return;
|
|
}
|
|
|
|
auto before = mOrderedInfo.begin();
|
|
if (!value.mPrev.empty())
|
|
{
|
|
const auto prevIt = mInfoPositions.find(value.mPrev);
|
|
if (prevIt != mInfoPositions.end())
|
|
before = std::next(prevIt->second.mPosition);
|
|
else
|
|
before = mOrderedInfo.end();
|
|
}
|
|
|
|
if (it == mInfoPositions.end())
|
|
{
|
|
const RefId id = value.mId;
|
|
mInfoPositions.emplace(id,
|
|
Item{
|
|
.mPosition = mOrderedInfo.insert(before, std::forward<V>(value)),
|
|
.mDeleted = deleted,
|
|
});
|
|
}
|
|
else
|
|
{
|
|
*it->second.mPosition = std::forward<V>(value);
|
|
it->second.mDeleted = deleted;
|
|
mOrderedInfo.splice(before, mOrderedInfo, it->second.mPosition);
|
|
}
|
|
}
|
|
|
|
void removeInfo(const RefId& infoRefId)
|
|
{
|
|
const auto it = mInfoPositions.find(infoRefId);
|
|
|
|
if (it == mInfoPositions.end())
|
|
return;
|
|
|
|
mOrderedInfo.erase(it->second.mPosition);
|
|
mInfoPositions.erase(it);
|
|
}
|
|
|
|
void removeDeleted()
|
|
{
|
|
for (auto it = mInfoPositions.begin(); it != mInfoPositions.end();)
|
|
{
|
|
if (!it->second.mDeleted)
|
|
{
|
|
++it;
|
|
continue;
|
|
}
|
|
|
|
mOrderedInfo.erase(it->second.mPosition);
|
|
it = mInfoPositions.erase(it);
|
|
}
|
|
}
|
|
|
|
void extractOrderedInfo(std::list<T>& info)
|
|
{
|
|
info = mOrderedInfo;
|
|
mInfoPositions.clear();
|
|
}
|
|
|
|
private:
|
|
struct Item
|
|
{
|
|
typename std::list<T>::iterator mPosition;
|
|
bool mDeleted = false;
|
|
};
|
|
|
|
std::list<T> mOrderedInfo;
|
|
std::unordered_map<RefId, Item> mInfoPositions;
|
|
};
|
|
}
|
|
|
|
#endif
|