mirror of
https://github.com/OpenMW/openmw.git
synced 2025-01-23 09:23:52 +00:00
9d61d76e92
Adds a boolean setting to the user preferences. This setting is locally saved to all OpenMW-CS check stages. When a verification is done, the setting is updated on setup for each check stage. If set to true, the boolean value is then used to skip the verification process for every base record - minus some special cases where, e.g., counters are to be set first. Related issue: - Fixes #4466: Editor: Add option to ignore base records when running verifier (https://gitlab.com/OpenMW/openmw/issues/4466) Tests: The changes were successfully tested in OpenMW-CS by creating faulty "Base" and "Modified" records for every record type (if possible) and, then, running the verifier with and without the option respectively.
63 lines
1.9 KiB
C++
63 lines
1.9 KiB
C++
#include "factioncheck.hpp"
|
|
|
|
#include <sstream>
|
|
#include <map>
|
|
|
|
#include <components/esm/loadfact.hpp>
|
|
#include <components/esm/loadskil.hpp>
|
|
|
|
#include "../prefs/state.hpp"
|
|
|
|
#include "../world/universalid.hpp"
|
|
|
|
CSMTools::FactionCheckStage::FactionCheckStage (const CSMWorld::IdCollection<ESM::Faction>& factions)
|
|
: mFactions (factions)
|
|
{
|
|
mIgnoreBaseRecords = CSMPrefs::get()["Reports"]["ignore-base-records"].isTrue();
|
|
}
|
|
|
|
int CSMTools::FactionCheckStage::setup()
|
|
{
|
|
mIgnoreBaseRecords = CSMPrefs::get()["Reports"]["ignore-base-records"].isTrue();
|
|
|
|
return mFactions.getSize();
|
|
}
|
|
|
|
void CSMTools::FactionCheckStage::perform (int stage, CSMDoc::Messages& messages)
|
|
{
|
|
const CSMWorld::Record<ESM::Faction>& record = mFactions.getRecord (stage);
|
|
|
|
// Skip "Base" records (setting!) and "Deleted" records
|
|
if ((mIgnoreBaseRecords && record.isBaseOnly()) || record.isDeleted())
|
|
return;
|
|
|
|
const ESM::Faction& faction = record.get();
|
|
|
|
CSMWorld::UniversalId id (CSMWorld::UniversalId::Type_Faction, faction.mId);
|
|
|
|
// test for empty name
|
|
if (faction.mName.empty())
|
|
messages.push_back (std::make_pair (id, faction.mId + " has an empty name"));
|
|
|
|
// test for invalid attributes
|
|
if (faction.mData.mAttribute[0]==faction.mData.mAttribute[1] && faction.mData.mAttribute[0]!=-1)
|
|
{
|
|
messages.push_back (std::make_pair (id , "Faction lists same attribute twice"));
|
|
}
|
|
|
|
// test for non-unique skill
|
|
std::map<int, int> skills; // ID, number of occurrences
|
|
|
|
for (int i=0; i<7; ++i)
|
|
if (faction.mData.mSkills[i]!=-1)
|
|
++skills[faction.mData.mSkills[i]];
|
|
|
|
for (std::map<int, int>::const_iterator iter (skills.begin()); iter!=skills.end(); ++iter)
|
|
if (iter->second>1)
|
|
{
|
|
messages.push_back (std::make_pair (id,
|
|
ESM::Skill::indexToId (iter->first) + " is listed more than once"));
|
|
}
|
|
|
|
/// \todo check data members that can't be edited in the table view
|
|
}
|