mirror of
				https://github.com/OpenMW/openmw.git
				synced 2025-10-31 21:56:41 +00:00 
			
		
		
		
	cppcheck:
[apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference.
[apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference.
[apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated.
[apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container.
[apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list.
PVS-Studio:
apps/opencs/model/filter/parser.cpp  582  warn  V560 A part of conditional expression is always true: allowPredefined.
apps/opencs/view/world/referencecreator.cpp  67  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/world/referencecreator.cpp  74  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !completed.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !error.empty().
apps/opencs/model/tools/pathgridcheck.cpp  32  err  V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34.
apps/opencs/model/world/refidadapterimp.cpp  1376  err  V547 Expression 'subColIndex < 3' is always true.
apps/openmw/mwgui/widgets.hpp  318  warn  V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179.
apps/openmw/mwgui/widgets.hpp  319  warn  V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180.
apps/openmw/mwgui/widgets.hpp  320  warn  V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181
apps/openmw/mwmechanics/actors.cpp  1425  warn  V547 Expression '!detected' is always true.
apps/openmw/mwmechanics/character.cpp  2155  err  V547 Expression 'mode == 0' is always true.
apps/openmw/mwmechanics/character.cpp  1192  warn  V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present.
apps/openmw/mwmechanics/character.cpp  521  warn  V560 A part of conditional expression is always true: (idle == mIdleState).
apps/openmw/mwmechanics/pathfinding.cpp  317  err  V547 Expression 'mPath.size() >= 2' is always true.
apps/openmw/mwscript/interpretercontext.cpp  409  warn  V560 A part of conditional expression is always false: rank > 9.
apps/openmw/mwgui/windowbase.cpp  28  warn  V560 A part of conditional expression is always true: !visible.
apps/openmw/mwgui/journalwindow.cpp  561  warn  V547 Expression '!mAllQuests' is always false.
apps/openmw/mwgui/referenceinterface.cpp  18  warn  V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16.
apps/openmw/mwworld/scene.cpp  463  warn  V547 Expression 'adjustPlayerPos' is always true.
apps/openmw/mwworld/worldimp.cpp  409  err  V766 An item with the same key '"sCompanionShare"' has already been added.
apps/openmw/mwworld/cellstore.cpp  691  warn  V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691.
apps/openmw/mwworld/weather.cpp  1125  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125.
apps/openmw/mwworld/weather.cpp  1137  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137.
apps/wizard/unshield/unshieldworker.cpp  475  warn  V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression.
apps/wizard/installationpage.cpp  163  warn  V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected.
components/fontloader/fontloader.cpp  427  err  V547 Expression 'i == 1' is always true.
components/nifosg/nifloader.cpp  282  warn  V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282.
components/esm/loadregn.cpp  119  err  V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119.
components/esm/cellref.cpp  178  warn  V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178.
components/esmterrain/storage.cpp  235  warn  V560 A part of conditional expression is always true: colStart == 0.
components/esmterrain/storage.cpp  237  warn  V560 A part of conditional expression is always true: rowStart == 0.
		
	
			
		
			
				
	
	
		
			165 lines
		
	
	
	
		
			5.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			165 lines
		
	
	
	
		
			5.1 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
| ///Program to test .nif files both on the FileSystem and in BSA archives.
 | |
| 
 | |
| #include <iostream>
 | |
| #include <fstream>
 | |
| #include <cstdlib>
 | |
| 
 | |
| #include <components/nif/niffile.hpp>
 | |
| #include <components/files/constrainedfilestream.hpp>
 | |
| #include <components/vfs/manager.hpp>
 | |
| #include <components/vfs/bsaarchive.hpp>
 | |
| #include <components/vfs/filesystemarchive.hpp>
 | |
| 
 | |
| #include <boost/program_options.hpp>
 | |
| #include <boost/filesystem.hpp>
 | |
| 
 | |
| // Create local aliases for brevity
 | |
| namespace bpo = boost::program_options;
 | |
| namespace bfs = boost::filesystem;
 | |
| 
 | |
| ///See if the file has the named extension
 | |
| bool hasExtension(std::string filename, std::string  extensionToFind)
 | |
| {
 | |
|     std::string extension = filename.substr(filename.find_last_of(".")+1);
 | |
| 
 | |
|     //Convert strings to lower case for comparison
 | |
|     std::transform(extension.begin(), extension.end(), extension.begin(), ::tolower);
 | |
|     std::transform(extensionToFind.begin(), extensionToFind.end(), extensionToFind.begin(), ::tolower);
 | |
| 
 | |
|     if(extension == extensionToFind)
 | |
|         return true;
 | |
|     else
 | |
|         return false;
 | |
| }
 | |
| 
 | |
| ///See if the file has the "nif" extension.
 | |
| bool isNIF(const std::string & filename)
 | |
| {
 | |
|     return hasExtension(filename,"nif");
 | |
| }
 | |
| ///See if the file has the "bsa" extension.
 | |
| bool isBSA(const std::string & filename)
 | |
| {
 | |
|     return hasExtension(filename,"bsa");
 | |
| }
 | |
| 
 | |
| /// Check all the nif files in a given VFS::Archive
 | |
| /// \note Takes ownership!
 | |
| /// \note Can not read a bsa file inside of a bsa file.
 | |
| void readVFS(VFS::Archive* anArchive,std::string archivePath = "")
 | |
| {
 | |
|     VFS::Manager myManager(true);
 | |
|     myManager.addArchive(anArchive);
 | |
|     myManager.buildIndex();
 | |
| 
 | |
|     std::map<std::string, VFS::File*> files=myManager.getIndex();
 | |
|     for(std::map<std::string, VFS::File*>::const_iterator it=files.begin(); it!=files.end(); ++it)
 | |
|     {
 | |
|         std::string name = it->first;
 | |
| 
 | |
|         try{
 | |
|             if(isNIF(name))
 | |
|             {
 | |
|             //           std::cout << "Decoding: " << name << std::endl;
 | |
|                 Nif::NIFFile temp_nif(myManager.get(name),archivePath+name);
 | |
|             }
 | |
|             else if(isBSA(name))
 | |
|             {
 | |
|                 if(!archivePath.empty() && !isBSA(archivePath))
 | |
|                 {
 | |
| //                     std::cout << "Reading BSA File: " << name << std::endl;
 | |
|                     readVFS(new VFS::BsaArchive(archivePath+name),archivePath+name+"/");
 | |
| //                     std::cout << "Done with BSA File: " << name << std::endl;
 | |
|                 }
 | |
|             }
 | |
|         }
 | |
|         catch (std::exception& e)
 | |
|         {
 | |
|             std::cerr << "ERROR, an exception has occurred:  " << e.what() << std::endl;
 | |
|         }
 | |
|     }
 | |
| }
 | |
| 
 | |
| std::vector<std::string> parseOptions (int argc, char** argv)
 | |
| {
 | |
|     bpo::options_description desc("Ensure that OpenMW can use the provided NIF and BSA files\n\n"
 | |
|         "Usages:\n"
 | |
|         "  niftool <nif files, BSA files, or directories>\n"
 | |
|         "      Scan the file or directories for nif errors.\n\n"
 | |
|         "Allowed options");
 | |
|     desc.add_options()
 | |
|         ("help,h", "print help message.")
 | |
|         ("input-file", bpo::value< std::vector<std::string> >(), "input file")
 | |
|         ;
 | |
| 
 | |
|     //Default option if none provided
 | |
|     bpo::positional_options_description p;
 | |
|     p.add("input-file", -1);
 | |
| 
 | |
|     bpo::variables_map variables;
 | |
|     try
 | |
|     {
 | |
|         bpo::parsed_options valid_opts = bpo::command_line_parser(argc, argv).
 | |
|             options(desc).positional(p).run();
 | |
|         bpo::store(valid_opts, variables);
 | |
|     }
 | |
|     catch(std::exception &e)
 | |
|     {
 | |
|         std::cout << "ERROR parsing arguments: " << e.what() << "\n\n"
 | |
|             << desc << std::endl;
 | |
|         exit(1);
 | |
|     }
 | |
| 
 | |
|     bpo::notify(variables);
 | |
|     if (variables.count ("help"))
 | |
|     {
 | |
|         std::cout << desc << std::endl;
 | |
|         exit(1);
 | |
|     }
 | |
|     if (variables.count("input-file"))
 | |
|     {
 | |
|         return variables["input-file"].as< std::vector<std::string> >();
 | |
|     }
 | |
| 
 | |
|     std::cout << "No input files or directories specified!" << std::endl;
 | |
|     std::cout << desc << std::endl;
 | |
|     exit(1);
 | |
| }
 | |
| 
 | |
| int main(int argc, char **argv)
 | |
| {
 | |
|     std::vector<std::string> files = parseOptions (argc, argv);
 | |
| 
 | |
| //     std::cout << "Reading Files" << std::endl;
 | |
|     for(std::vector<std::string>::const_iterator it=files.begin(); it!=files.end(); ++it)
 | |
|     {
 | |
|          std::string name = *it;
 | |
| 
 | |
|         try{
 | |
|             if(isNIF(name))
 | |
|             {
 | |
|                 //std::cout << "Decoding: " << name << std::endl;
 | |
|                 Nif::NIFFile temp_nif(Files::openConstrainedFileStream(name.c_str()),name);
 | |
|              }
 | |
|              else if(isBSA(name))
 | |
|              {
 | |
| //                 std::cout << "Reading BSA File: " << name << std::endl;
 | |
|                 readVFS(new VFS::BsaArchive(name));
 | |
|              }
 | |
|              else if(bfs::is_directory(bfs::path(name)))
 | |
|              {
 | |
| //                 std::cout << "Reading All Files in: " << name << std::endl;
 | |
|                 readVFS(new VFS::FileSystemArchive(name),name);
 | |
|              }
 | |
|              else
 | |
|              {
 | |
|                  std::cerr << "ERROR:  \"" << name << "\" is not a nif file, bsa file, or directory!" << std::endl;
 | |
|              }
 | |
|         }
 | |
|         catch (std::exception& e)
 | |
|         {
 | |
|             std::cerr << "ERROR, an exception has occurred:  " << e.what() << std::endl;
 | |
|         }
 | |
|      }
 | |
|      return 0;
 | |
| }
 |