mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-01-20 13:53:53 +00:00
Code Issues Releases Wiki Activity
openmw/apps/opencs/view/render
History
Bo Svensson c9c8d02332
fixes a crash (#3183) 
This PR fixes a crash caused by the improperly ensured lifetime of RigGeometry::mSourceGeometry. mSourceGeometry was not adequate to ensure mSourceGeometry would outlive mGeometry because we extend mGeometrys lifetime beyond this lifetime by passing mGeometry to the draw traversal instead of this.
In addition,

We add important comments.
We detect and prevent generally unsafe operations in high level code.
We add a sprinkling of const to help clarify intentions.
2021-10-23 10:31:46 +02:00
..
actor.cpp fixes a crash (#3183) 2021-10-23 10:31:46 +02:00
actor.hpp Pass std::string_view instead of const std::string& 2021-09-09 18:39:50 +02:00
brushdraw.cpp Optimize terrain editing brush drawing performance 2021-09-18 15:57:00 +03:00
brushdraw.hpp Fix and simplify brush outlines and coordinate calculations 2020-03-26 13:25:33 +02:00
cameracontroller.cpp Fix node masks signed/unsigned mismatch 2021-04-20 10:52:51 +04:00
cameracontroller.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
cell.cpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
cell.hpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
cellarrow.cpp Minor UI tweaks all around OpenMW-CS 2021-10-03 19:13:51 +00:00
cellarrow.hpp Show number of pathgrid node in a tooltip 2021-06-28 00:34:49 +02:00
cellborder.cpp Rebased branch, reduced code duplication, added comments, adjusted formatting. 2021-05-18 17:53:00 +02:00
cellborder.hpp Directly use Geometry instead of Geode; fix for loop; add size_t type-cast. 2021-05-18 14:56:03 +02:00
cellmarker.cpp as it says; revert vismask and uncomplicate openmw 2020-04-20 20:57:38 +02:00
cellmarker.hpp Update cell marker appearance 2016-02-14 10:28:41 -05:00
cellwater.cpp Replace zeroes and nulls by nullptrs 2020-11-29 11:14:07 +04:00
cellwater.hpp Reload water 2017-08-20 20:55:56 -04:00
commands.cpp Merge branch 'terrainselectioncrashfix' into 'openmw-47' 2021-08-22 19:22:54 +00:00
commands.hpp Merge branch 'terrainselectioncrashfix' into 'openmw-47' 2021-08-22 19:22:54 +00:00
editmode.cpp Implement brush outline for terrainshapemode 2020-03-26 13:25:33 +02:00
editmode.hpp Replace zeroes and nulls by nullptrs 2020-11-29 11:14:07 +04:00
instancedragmodes.hpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
instancemode.cpp Clear temporary movement data at the end of the drag 2021-09-01 02:04:04 +03:00
instancemode.hpp Use floats, not doubles 2021-09-01 02:04:04 +03:00
instancemovemode.cpp Lamoot's new icon set 2018-04-15 12:35:45 +03:00
instancemovemode.hpp Replace zeroes and nulls by nullptrs 2020-11-29 11:14:07 +04:00
instanceselectionmode.cpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
instanceselectionmode.hpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
lighting.cpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
lighting.hpp Replace zeroes and nulls by nullptrs 2020-11-29 11:14:07 +04:00
lightingbright.cpp Daytime node switch support (feature #4836) 2019-02-02 10:50:15 +04:00
lightingbright.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
lightingday.cpp Daytime node switch support (feature #4836) 2019-02-02 10:50:15 +04:00
lightingday.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
lightingnight.cpp Daytime node switch support (feature #4836) 2019-02-02 10:50:15 +04:00
lightingnight.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
mask.hpp Fix node masks signed/unsigned mismatch 2021-04-20 10:52:51 +04:00
object.cpp Update original cell column and do not modify the refnum when moving a reference to another cell with 3D editing. 2021-08-28 16:12:40 +10:00
object.hpp Show number of pathgrid node in a tooltip 2021-06-28 00:34:49 +02:00
orbitcameramode.cpp Remove some superfluous includes in the opencs 2021-05-14 10:57:31 +02:00
orbitcameramode.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
pagedworldspacewidget.cpp Remove some superfluous includes in the opencs 2021-05-14 10:57:31 +02:00
pagedworldspacewidget.hpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
pathgrid.cpp Show number of pathgrid node in a tooltip 2021-06-28 00:34:49 +02:00
pathgrid.hpp Show number of pathgrid node in a tooltip 2021-06-28 00:34:49 +02:00
pathgridmode.cpp Remove some superfluous includes in the opencs 2021-05-14 10:57:31 +02:00
pathgridmode.hpp Replace zeroes and nulls by nullptrs 2020-11-29 11:14:07 +04:00
pathgridselectionmode.cpp as it says; revert vismask and uncomplicate openmw 2020-04-20 20:57:38 +02:00
pathgridselectionmode.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
previewwidget.cpp Daytime node switch support (feature #4836) 2019-02-02 10:50:15 +04:00
previewwidget.hpp Replace zeroes and nulls by nullptrs 2020-11-29 11:14:07 +04:00
scenewidget.cpp Remove some superfluous includes in the opencs 2021-05-14 10:57:31 +02:00
scenewidget.hpp Fix node masks signed/unsigned mismatch 2021-04-20 10:52:51 +04:00
selectionmode.cpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
selectionmode.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
tagbase.cpp Show number of pathgrid node in a tooltip 2021-06-28 00:34:49 +02:00
tagbase.hpp Show number of pathgrid node in a tooltip 2021-06-28 00:34:49 +02:00
terrainselection.cpp Remove unused include 2021-10-15 21:54:00 +03:00
terrainselection.hpp Various terrain selection and editmode dragging fixes 2021-10-15 21:54:00 +03:00
terrainshapemode.cpp Only iterate through temporary selection when using toggle 2021-10-15 21:54:00 +03:00
terrainshapemode.hpp Various terrain selection and editmode dragging fixes 2021-10-15 21:54:00 +03:00
terrainstorage.cpp Terrain selection optimizations, measurements, renderBin change 2021-10-15 21:54:00 +03:00
terrainstorage.hpp components/compiler cleanup; also cleaned up related cascading warnings; fixed up final/override issues 2020-10-22 23:57:53 +02:00
terraintexturemode.cpp Only iterate through temporary selection when using toggle 2021-10-15 21:54:00 +03:00
terraintexturemode.hpp Various terrain selection and editmode dragging fixes 2021-10-15 21:54:00 +03:00
unpagedworldspacewidget.cpp Remove some superfluous includes in the opencs 2021-05-14 10:57:31 +02:00
unpagedworldspacewidget.hpp [OpenMW-CS] Cube and sphere instance selection 2021-01-09 21:35:07 +00:00
worldspacewidget.cpp Call dragEnded instead of pressed also after aborted operation 2021-10-15 21:54:00 +03:00
worldspacewidget.hpp Merge branch 'terrainselectioncrashfix' into 'openmw-47' 2021-08-22 19:22:54 +00:00