1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-02-19 15:39:49 +00:00
openmw/components/sceneutil
Bo Svensson c9c8d02332
fixes a crash (#3183)
This PR fixes a crash caused by the improperly ensured lifetime of RigGeometry::mSourceGeometry. mSourceGeometry was not adequate to ensure mSourceGeometry would outlive mGeometry because we extend mGeometrys lifetime beyond this lifetime by passing mGeometry to the draw traversal instead of this.
In addition,

We add important comments.
We detect and prevent generally unsafe operations in high level code.
We add a sprinkling of const to help clarify intentions.
2021-10-23 10:31:46 +02:00
..
actorutil.cpp Move base_anim settings to settings-default.cfg 2021-01-27 13:41:02 +02:00
actorutil.hpp
agentpath.cpp refactor and fix wobbly shores 2021-08-04 17:49:57 -07:00
agentpath.hpp
attach.cpp fixes a crash (#3183) 2021-10-23 10:31:46 +02:00
attach.hpp fixes a crash (#3183) 2021-10-23 10:31:46 +02:00
clone.cpp clone.cpp remove dynamic_cast (#3097) 2021-09-09 23:04:11 +02:00
clone.hpp fixes a crash (#3183) 2021-10-23 10:31:46 +02:00
controller.cpp
controller.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
detourdebugdraw.cpp
detourdebugdraw.hpp
keyframe.hpp adds a replacement for osg::NodeCallback (#3144) 2021-10-04 10:56:55 +02:00
lightcontroller.cpp converts remaining osg::NodeCallback (#3147) 2021-10-05 14:21:12 +02:00
lightcontroller.hpp converts remaining osg::NodeCallback (#3147) 2021-10-05 14:21:12 +02:00
lightmanager.cpp discard off-screen lights (#3120) 2021-10-06 11:53:24 +02:00
lightmanager.hpp discard off-screen lights (#3120) 2021-10-06 11:53:24 +02:00
lightutil.cpp Finalize settings, torch fix 2021-04-13 11:09:49 -07:00
lightutil.hpp Finalize settings, torch fix 2021-04-13 11:09:49 -07:00
morphgeometry.cpp fixes a crash (#3183) 2021-10-23 10:31:46 +02:00
morphgeometry.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
mwshadowtechnique.cpp avoids virtual function calls in ComputeLightSpaceBounds (#3167) 2021-10-11 15:11:59 +02:00
mwshadowtechnique.hpp avoids virtual function calls in ComputeLightSpaceBounds (#3167) 2021-10-11 15:11:59 +02:00
navmesh.cpp refactor and fix wobbly shores 2021-08-04 17:49:57 -07:00
navmesh.hpp
nodecallback.hpp adds a replacement for osg::NodeCallback (#3144) 2021-10-04 10:56:55 +02:00
optimizer.cpp speeds up optimizer (#3162) 2021-10-10 18:09:15 +02:00
optimizer.hpp speeds up optimizer (#3162) 2021-10-10 18:09:15 +02:00
osgacontroller.cpp cleans up osgacontroller.cpp (#3142) 2021-10-04 12:20:33 +02:00
osgacontroller.hpp cleans up osgacontroller.cpp (#3142) 2021-10-04 12:20:33 +02:00
pathgridutil.cpp refactor and fix wobbly shores 2021-08-04 17:49:57 -07:00
pathgridutil.hpp
positionattitudetransform.cpp
positionattitudetransform.hpp Mark overrided methods by override keyword 2020-10-16 22:18:54 +04:00
recastmesh.cpp Use different colors for walkable and non-walkable triangles 2021-10-09 17:44:25 +02:00
recastmesh.hpp
riggeometry.cpp fixes a crash (#3183) 2021-10-23 10:31:46 +02:00
riggeometry.hpp fixes a crash (#3183) 2021-10-23 10:31:46 +02:00
rtt.cpp converts remaining osg::NodeCallback (#3147) 2021-10-05 14:21:12 +02:00
rtt.hpp Stereo friendly StateSetUpdater 2021-07-26 14:01:02 +02:00
screencapture.cpp Manage work item lifetime on the client side 2021-07-12 11:41:14 +02:00
screencapture.hpp Manage work item lifetime on the client side 2021-07-12 11:41:14 +02:00
serialize.cpp Serialize NifOsg::MatrixTransform children properly 2021-08-12 18:33:06 +03:00
serialize.hpp
shadow.cpp allows to skip ComputeLightSpaceBounds traversal (#3152) 2021-10-11 11:27:50 +02:00
shadow.hpp allows to skip ComputeLightSpaceBounds traversal (#3152) 2021-10-11 11:27:50 +02:00
shadowsbin.cpp shadowsbin.cpp uniform 2021-09-12 09:21:10 +00:00
shadowsbin.hpp Allow shadowsbin to optimise clockwise-wound meshes when face culling is off 2020-12-23 01:24:15 +00:00
skeleton.cpp optimises skeleton.cpp (#3158) 2021-10-09 11:14:22 +02:00
skeleton.hpp optimises skeleton.cpp (#3158) 2021-10-09 11:14:22 +02:00
statesetupdater.cpp converts remaining osg::NodeCallback (#3147) 2021-10-05 14:21:12 +02:00
statesetupdater.hpp resets state updater to apply light settings (#3141) 2021-10-06 11:21:30 +02:00
textkeymap.hpp Separate keyframes logic to provide basis for osgAnimation integration. 2020-11-18 22:48:47 +02:00
util.cpp converts remaining osg::NodeCallback (#3147) 2021-10-05 14:21:12 +02:00
util.hpp converts remaining osg::NodeCallback (#3147) 2021-10-05 14:21:12 +02:00
visitor.cpp Merge branch 'string_view' into 'master' 2021-09-09 20:41:16 +00:00
visitor.hpp Don't use FreezeOnCull for any particle system (#4744) 2021-08-08 03:36:35 +03:00
waterutil.cpp refactor and fix wobbly shores 2021-08-04 17:49:57 -07:00
waterutil.hpp refactor and fix wobbly shores 2021-08-04 17:49:57 -07:00
workqueue.cpp Reset mIsReleased before starting threads 2021-08-08 02:28:59 +02:00
workqueue.hpp Stop engine work queue before destructing environment 2021-07-08 21:14:01 +02:00
writescene.cpp
writescene.hpp