Always run preloadCommonAssets even when the menu is skipped

Move to before the content files are loaded so we can do preloading in parallel with content file loading

apps/openmw/engine.cpp

@@ -650,8 +650,6 @@ void OMW::Engine::go()
     }
     else if (!mSkipMenu)
     {
-        mEnvironment.getWorld()->preloadCommonAssets();
-
         // start in main menu
         mEnvironment.getWindowManager()->pushGuiMode (MWGui::GM_MainMenu);
         try

apps/openmw/mwbase/world.hpp

@@ -95,8 +95,6 @@ namespace MWBase
 
             virtual ~World() {}
 
-            virtual void preloadCommonAssets() = 0;
-
             virtual void startNewGame (bool bypass) = 0;
             ///< \param bypass Bypass regular game start.
 

apps/openmw/mwworld/worldimp.cpp

@@ -157,6 +157,8 @@ namespace MWWorld
         mRendering = new MWRender::RenderingManager(viewer, rootNode, resourceSystem, &mFallback, resourcePath);
         mProjectileManager.reset(new ProjectileManager(mRendering->getLightRoot(), resourceSystem, mRendering, mPhysics));
 
+        mRendering->preloadCommonAssets();
+
         mEsm.resize(contentFiles.size());
         Loading::Listener* listener = MWBase::Environment::get().getWindowManager()->getLoadingScreen();
         listener->loadingOn();
@@ -3348,9 +3350,4 @@ namespace MWWorld
         return mPhysics->getHitDistance(weaponPos, target) - halfExtents.y();
     }
 
-    void World::preloadCommonAssets()
-    {
-        mRendering->preloadCommonAssets();
-    }
-
 }

apps/openmw/mwworld/worldimp.hpp

@@ -191,8 +191,6 @@ namespace MWWorld
             virtual void startNewGame (bool bypass);
             ///< \param bypass Bypass regular game start.
 
-            virtual void preloadCommonAssets();
-
             virtual void clear();
 
             virtual int countSavedGameRecords() const;