teamnwah/openmw-tes3coop
2
0
Fork 1
forked from mirror/openmw-tes3mp
Code Issues Pull requests 1 Releases Wiki Activity

Merge pull request #1726 from elsid/fix_catch_warnings

Browse source 
Fix warnings: catching polymorphic type by value
This commit is contained in:
Bret Curtis 2018-06-02 19:36:04 +02:00 committed by GitHub
commit 4a2b973052
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/openmw/mwworld/worldimp.cpp
View file

@ -2601,11 +2601,11 @@ namespace MWWorld
int y = std::stoi(name.substr(name.find(',')+1));
ext = getExterior(x, y)->getCell();
}
catch (std::invalid_argument)
catch (const std::invalid_argument&)
{
// This exception can be ignored, as this means that name probably refers to a interior cell instead of comma separated coordinates
}
catch (std::out_of_range)
catch (const std::out_of_range&)
{
throw std::runtime_error("Cell coordinates out of range.");
}

4
components/widgets/numericeditbox.cpp
View file

@ -38,11 +38,11 @@ namespace Gui
setCaption(MyGUI::utility::toString(mValue));
}
}
catch (std::invalid_argument)
catch (const std::invalid_argument&)
{
setCaption(MyGUI::utility::toString(mValue));
}
catch (std::out_of_range)
catch (const std::out_of_range&)
{
setCaption(MyGUI::utility::toString(mValue));
}