general player class cleanup

apps/openmw/mwworld/player.cpp

@@ -32,6 +32,27 @@ namespace MWWorld
                 -mPlayer.ref.pos.pos[1]));
     }
 
+    void Player::moveRel (float &relX, float &relY, float &relZ)
+    {
+        // Move camera relative to its own direction
+        camera->moveRelative (Ogre::Vector3(relX,0,relZ));
+
+        // Up/down movement is always done relative the world axis.
+        camera->move (Ogre::Vector3(0,relY,0));
+
+        // Get new camera position, converting back to MW coords.
+        Ogre::Vector3 pos = camera->getPosition();
+        relX = pos[0];
+        relY = -pos[2];
+        relZ = pos[1];
+
+        // TODO: Collision detection must be used to find the REAL new
+        // position.
+
+        // Set the position
+        setPos(relX, relY, relZ);
+    }
+
     void Player::setClass (const ESM::Class& class_)
     {
         ESM::Class *new_class = new ESM::Class (class_);

apps/openmw/mwworld/player.hpp

@@ -33,7 +33,7 @@ namespace MWWorld
 
         ~Player();
 
-    // Set the player position. Uses Morrowind coordinates.
+        /// Set the player position. Uses Morrowind coordinates.
         void setPos(float _x, float _y, float _z, bool updateCamera = false);
 
         void setCell (MWWorld::Ptr::CellStore *cellStore)
@@ -43,30 +43,9 @@ namespace MWWorld
 
         Ogre::Camera *getCamera() { return camera; }
 
-    // Move the player relative to her own position and
+        /// Move the player relative to her own position and
-    // orientation. After the call, the new position is returned.
+        /// orientation. After the call, the new position is returned.
-    void moveRel(float &relX, float &relY, float &relZ)
+        void moveRel (float &relX, float &relY, float &relZ);
-    {
-      using namespace Ogre;
-
-      // Move camera relative to its own direction
-      camera->moveRelative(Vector3(relX,0,relZ));
-
-      // Up/down movement is always done relative the world axis.
-      camera->move(Vector3(0,relY,0));
-
-      // Get new camera position, converting back to MW coords.
-      Vector3 pos = camera->getPosition();
-      relX = pos[0];
-      relY = -pos[2];
-      relZ = pos[1];
-
-      // TODO: Collision detection must be used to find the REAL new
-      // position.
-
-      // Set the position
-      setPos(relX, relY, relZ);
-    }
 
         MWWorld::Ptr getPlayer()
         {