From 8a84201ba2e3ad7b38038cd905a3389ae65590a8 Mon Sep 17 00:00:00 2001
From: Lukasz Gromanowski <lgromanowski@gmail.com>
Date: Sun, 19 Jun 2011 16:42:35 +0200
Subject: [PATCH] Mantis: #18 - Move components from global namespace into
 their own namespace.

Moving classes from components/bsa into Bsa namespace.

Signed-off-by: Lukasz Gromanowski <lgromanowski@gmail.com>
---
 apps/openmw/engine.cpp                     |  2 +-
 components/bsa/bsa_archive.cpp             | 11 +++++++++++
 components/bsa/bsa_archive.hpp             |  9 +++++++--
 components/bsa/bsa_file.cpp                |  1 +
 components/bsa/bsa_file.hpp                |  9 +++++++--
 components/bsa/tests/bsa_file_test.cpp     |  1 +
 components/bsa/tests/bsatool.cpp           |  1 +
 components/bsa/tests/ogre_archive_test.cpp |  2 +-
 8 files changed, 30 insertions(+), 6 deletions(-)

diff --git a/apps/openmw/engine.cpp b/apps/openmw/engine.cpp
index b2ed0a767..e1386d3c4 100644
--- a/apps/openmw/engine.cpp
+++ b/apps/openmw/engine.cpp
@@ -246,7 +246,7 @@ void OMW::Engine::loadBSA()
     for (Files::MultiDirCollection::TIter iter (bsa.begin()); iter!=bsa.end(); ++iter)
     {
          std::cout << "Adding " << iter->second.string() << std::endl;
-         addBSA (iter->second.string());
+         Bsa::addBSA (iter->second.string());
     }
 }
 
diff --git a/components/bsa/bsa_archive.cpp b/components/bsa/bsa_archive.cpp
index 4691eb546..937a21d0a 100644
--- a/components/bsa/bsa_archive.cpp
+++ b/components/bsa/bsa_archive.cpp
@@ -29,8 +29,12 @@
 #include "bsa_file.hpp"
 #include <libs/mangle/stream/clients/ogre_datastream.hpp>
 
+namespace
+{
+
 using namespace Ogre;
 using namespace Mangle::Stream;
+using namespace Bsa;
 
 /// An OGRE Archive wrapping a BSAFile archive
 class BSAArchive : public Archive
@@ -155,6 +159,11 @@ static void insertBSAFactory()
     }
 }
 
+}
+
+namespace Bsa
+{
+
 // The function below is the only publicly exposed part of this file
 
 void addBSA(const std::string& name, const std::string& group)
@@ -163,3 +172,5 @@ void addBSA(const std::string& name, const std::string& group)
   ResourceGroupManager::getSingleton().
     addResourceLocation(name, "BSA", group);
 }
+
+}
diff --git a/components/bsa/bsa_archive.hpp b/components/bsa/bsa_archive.hpp
index bde6d9c3b..9054966db 100644
--- a/components/bsa/bsa_archive.hpp
+++ b/components/bsa/bsa_archive.hpp
@@ -23,11 +23,16 @@
 
 #include <string>
 
-#ifndef _BSA_ARCHIVE_H_
-#define _BSA_ARCHIVE_H_
+#ifndef BSA_BSA_ARCHIVE_H
+#define BSA_BSA_ARCHIVE_H
+
+namespace Bsa
+{
 
 /// Add the given BSA file as an input archive in the Ogre resource
 /// system.
 void addBSA(const std::string& file, const std::string& group="General");
 
+}
+
 #endif
diff --git a/components/bsa/bsa_file.cpp b/components/bsa/bsa_file.cpp
index e37d38bb2..95358a362 100644
--- a/components/bsa/bsa_file.cpp
+++ b/components/bsa/bsa_file.cpp
@@ -32,6 +32,7 @@
 
 using namespace std;
 using namespace Mangle::Stream;
+using namespace Bsa;
 
 /// Error handling
 void BSAFile::fail(const string &msg)
diff --git a/components/bsa/bsa_file.hpp b/components/bsa/bsa_file.hpp
index 7ec101b43..f54a64d2a 100644
--- a/components/bsa/bsa_file.hpp
+++ b/components/bsa/bsa_file.hpp
@@ -21,8 +21,8 @@
 
  */
 
-#ifndef _BSA_FILE_H_
-#define _BSA_FILE_H_
+#ifndef BSA_BSA_FILE_H
+#define BSA_BSA_FILE_H
 
 #include <libs/mangle/stream/stream.hpp>
 #include <libs/platform/stdint.h>
@@ -31,6 +31,9 @@
 #include <vector>
 #include <map>
 
+namespace Bsa
+{
+
 /**
    This class is used to read "Bethesda Archive Files", or BSAs.
  */
@@ -131,4 +134,6 @@ class BSAFile
     { return files; }
 };
 
+}
+
 #endif
diff --git a/components/bsa/tests/bsa_file_test.cpp b/components/bsa/tests/bsa_file_test.cpp
index ea3f9291c..07ee73d17 100644
--- a/components/bsa/tests/bsa_file_test.cpp
+++ b/components/bsa/tests/bsa_file_test.cpp
@@ -11,6 +11,7 @@
 #include <iostream>
 
 using namespace std;
+using namespace Bsa;
 
 BSAFile bsa;
 
diff --git a/components/bsa/tests/bsatool.cpp b/components/bsa/tests/bsatool.cpp
index da96c2ed5..df37e3827 100644
--- a/components/bsa/tests/bsatool.cpp
+++ b/components/bsa/tests/bsatool.cpp
@@ -11,6 +11,7 @@
 
 using namespace std;
 using namespace Mangle::Stream;
+using namespace Bsa;
 
 int main(int argc, char** argv)
 {
diff --git a/components/bsa/tests/ogre_archive_test.cpp b/components/bsa/tests/ogre_archive_test.cpp
index 1a4334e60..9cd57240f 100644
--- a/components/bsa/tests/ogre_archive_test.cpp
+++ b/components/bsa/tests/ogre_archive_test.cpp
@@ -19,7 +19,7 @@ int main()
   Root *root = new Root("","","");
 
   // Add the BSA
-  addBSA("../../data/Morrowind.bsa");
+  Bsa::addBSA("../../data/Morrowind.bsa");
 
   // Pick a sample file
   String tex = "textures\\tx_natural_cavern_wall13.dds";