Simplify detecting whether a universal id represents a referenceable type.

apps/opencs/view/doc/view.cpp

@@ -464,8 +464,7 @@ void CSVDoc::View::addSubView (const CSMWorld::UniversalId& id, const std::strin
 {
     CSMSettings::UserSettings &userSettings = CSMSettings::UserSettings::instance();
 
-    const std::vector<CSMWorld::UniversalId::Type> referenceables(CSMWorld::UniversalId::listReferenceableTypes());
+    bool isReferenceable = id.getClass() == CSMWorld::UniversalId::Class_RefRecord;
-    bool isReferenceable = std::find(referenceables.begin(), referenceables.end(), id.getType()) != referenceables.end();
 
     // User setting to reuse sub views (on a per top level view basis)
     bool reuse =
@@ -477,12 +476,11 @@ void CSVDoc::View::addSubView (const CSMWorld::UniversalId& id, const std::strin
             bool isSubViewReferenceable =
                 sb->getUniversalId().getType() == CSMWorld::UniversalId::Type_Referenceable;
 
-            if((isReferenceable && isSubViewReferenceable &&
+            if((isReferenceable && isSubViewReferenceable && id.getId() == sb->getUniversalId().getId())
-                id.getId() == sb->getUniversalId().getId())
                ||
                (!isReferenceable && id == sb->getUniversalId()))
             {
-                sb->setFocus(Qt::OtherFocusReason); // FIXME: focus not quite working
+                sb->setFocus();
                 return;
             }
         }
@@ -502,7 +500,7 @@ void CSVDoc::View::addSubView (const CSMWorld::UniversalId& id, const std::strin
     }
 
     SubView *view = NULL;
-    if(std::find(referenceables.begin(), referenceables.end(), id.getType()) != referenceables.end())
+    if(isReferenceable)
     {
         view = mSubViewFactory.makeSubView (CSMWorld::UniversalId(CSMWorld::UniversalId::Type_Referenceable, id.getId()), *mDocument);
     }