[Server] Pass shared_ptr<Player> by reference

2017-12-08 07:32:39 +08:00 · 2017-12-08 07:32:39 +08:00 · c55f0f73b8
commit c55f0f73b8
parent 85a9181c12
58 changed files with 61 additions and 59 deletions
--- a/apps/openmw-mp/processors/ActorProcessor.cpp
+++ b/apps/openmw-mp/processors/ActorProcessor.cpp
@ -6,7 +6,7 @@ using namespace mwmp;
 template<class T>
 typename BasePacketProcessor<T>::processors_t BasePacketProcessor<T>::processors;

-void ActorProcessor::Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList)
+void ActorProcessor::Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList)
 {
    packet.Send(true);
 }
--- a/apps/openmw-mp/processors/ActorProcessor.hpp
+++ b/apps/openmw-mp/processors/ActorProcessor.hpp
@ -14,7 +14,7 @@ namespace mwmp
    {
    public:

-        virtual void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList);
+        virtual void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList);

        static bool Process(RakNet::Packet &packet, BaseActorList &actorList) noexcept;
    };
--- a/apps/openmw-mp/processors/PlayerProcessor.hpp
+++ b/apps/openmw-mp/processors/PlayerProcessor.hpp
@ -18,7 +18,7 @@ namespace mwmp
    {
    public:

-        virtual void Do(PlayerPacket &packet, std::shared_ptr<Player> player) = 0;
+        virtual void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) = 0;

        static bool Process(RakNet::Packet &packet) noexcept;
    };
--- a/apps/openmw-mp/processors/WorldProcessor.cpp
+++ b/apps/openmw-mp/processors/WorldProcessor.cpp
@ -10,7 +10,7 @@ using namespace mwmp;
 template<class T>
 typename BasePacketProcessor<T>::processors_t BasePacketProcessor<T>::processors;

-void WorldProcessor::Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event)
+void WorldProcessor::Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event)
 {
    packet.Send(true);
 }
--- a/apps/openmw-mp/processors/WorldProcessor.hpp
+++ b/apps/openmw-mp/processors/WorldProcessor.hpp
@ -18,7 +18,7 @@ namespace mwmp
    {
    public:

-        virtual void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event);
+        virtual void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event);

        static bool Process(RakNet::Packet &packet, BaseEvent &event) noexcept;
    };
--- a/apps/openmw-mp/processors/actor/ProcessorActorAI.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorAI.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_AI)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorAnimFlags.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorAnimFlags.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_ANIM_FLAGS)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorAnimPlay.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorAnimPlay.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_ANIM_PLAY)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorAttack.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorAttack.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_ATTACK)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorCellChange.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorCellChange.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_CELL_CHANGE)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);

--- a/apps/openmw-mp/processors/actor/ProcessorActorDeath.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorDeath.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_DEATH)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorEquipment.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorEquipment.hpp
@ -14,7 +14,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_EQUIPMENT)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            std::vector<std::shared_ptr<Actor>> actors;

--- a/apps/openmw-mp/processors/actor/ProcessorActorList.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorList.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_LIST)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/actor/ProcessorActorPosition.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorPosition.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_POSITION)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorSpeech.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorSpeech.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_SPEECH)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorStatsDynamic.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorStatsDynamic.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_STATS_DYNAMIC)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            // Send only to players who have the cell loaded
            Cell *serverCell = CellController::get()->getCell(&actorList.cell);
--- a/apps/openmw-mp/processors/actor/ProcessorActorTest.hpp
+++ b/apps/openmw-mp/processors/actor/ProcessorActorTest.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_ACTOR_TEST)
        }

-        void Do(ActorPacket &packet, std::shared_ptr<Player> player, BaseActorList &actorList) override
+        void Do(ActorPacket &packet, const std::shared_ptr<Player> &player, BaseActorList &actorList) override
        {
            std::vector<std::shared_ptr<Actor>> actors;

--- a/apps/openmw-mp/processors/player/ProcessorChatMsg.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorChatMsg.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_CHAT_MESSAGE)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorGUIMessageBox.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorGUIMessageBox.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_GUI_MESSAGEBOX)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorGUIWindow.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorGUIWindow.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_GUI_WINDOW)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorGameWeather.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorGameWeather.hpp
@ -13,9 +13,11 @@ namespace mwmp
            BPP_INIT(ID_GAME_WEATHER)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) final
        {
-            // Placeholder to be filled in later
+            DEBUG_PRINTF(strPacketID);
+
+            Networking::get().getState().getEventCtrl().Call<CoreEvent::ON_PLAYER_WEATHER>(player);
        }
    };
 }
--- a/apps/openmw-mp/processors/player/ProcessorPlayerAnimFlags.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerAnimFlags.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_ANIM_FLAGS)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerAnimPlay.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerAnimPlay.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_ANIM_PLAY)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerAttack.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerAttack.hpp
@ -19,7 +19,7 @@ namespace mwmp
            playerController = Networking::get().getPlayerPacketController();
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerAttribute.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerAttribute.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_ATTRIBUTE)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            if (!player->creatureStats.mDead)
            {
--- a/apps/openmw-mp/processors/player/ProcessorPlayerBook.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerBook.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_BOOK)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerBounty.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerBounty.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_BOUNTY)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            Networking::get().getState().getEventCtrl().Call<CoreEvent::ON_PLAYER_BOUNTY>(player);
        }
--- a/apps/openmw-mp/processors/player/ProcessorPlayerCellChange.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerCellChange.hpp
@ -21,7 +21,7 @@ namespace mwmp
            playerController = Networking::get().getPlayerPacketController();
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerCellState.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerCellState.hpp
@ -17,7 +17,7 @@ namespace mwmp
            playerController = Networking::get().getPlayerPacketController();
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerCharClass.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerCharClass.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_CHARCLASS)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());
        }
--- a/apps/openmw-mp/processors/player/ProcessorPlayerCharGen.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerCharGen.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_CHARGEN)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerDeath.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerDeath.hpp
@ -18,7 +18,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_DEATH)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerDisposition.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerDisposition.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_DISPOSITION)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerEquipment.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerEquipment.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_EQUIPMENT)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerFaction.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerFaction.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_FACTION)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerInventory.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerInventory.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_INVENTORY)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerJournal.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerJournal.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_JOURNAL)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerKillCount.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerKillCount.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_KILL_COUNT)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerLevel.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerLevel.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_LEVEL)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            if (!player->creatureStats.mDead)
                Networking::get().getState().getEventCtrl().Call<CoreEvent::ON_PLAYER_LEVEL>(player);
--- a/apps/openmw-mp/processors/player/ProcessorPlayerMap.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerMap.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_MAP)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerPosition.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerPosition.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_POSITION)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            //DEBUG_PRINTF(strPacketID);
            if (!player->creatureStats.mDead)
--- a/apps/openmw-mp/processors/player/ProcessorPlayerRest.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerRest.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_REST)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerResurrect.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerResurrect.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_RESURRECT)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_VERBOSE, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerShapeshift.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerShapeshift.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_SHAPESHIFT)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerSkill.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerSkill.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_SKILL)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            if (!player->creatureStats.mDead)
            {
--- a/apps/openmw-mp/processors/player/ProcessorPlayerSpeech.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerSpeech.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_SPEECH)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerSpellbook.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerSpellbook.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_SPELLBOOK)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerStatsDynamic.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerStatsDynamic.hpp
@ -17,7 +17,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_STATS_DYNAMIC)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/player/ProcessorPlayerTopic.hpp
+++ b/apps/openmw-mp/processors/player/ProcessorPlayerTopic.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_PLAYER_TOPIC)
        }

-        void Do(PlayerPacket &packet, std::shared_ptr<Player> player) override
+        void Do(PlayerPacket &packet, const std::shared_ptr<Player> &player) override
        {
            DEBUG_PRINTF(strPacketID.c_str());

--- a/apps/openmw-mp/processors/world/ProcessorContainer.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorContainer.hpp
@ -15,7 +15,7 @@ namespace mwmp
            BPP_INIT(ID_CONTAINER)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());
            LOG_APPEND(Log::LOG_INFO, "- action: %i", event.action);
--- a/apps/openmw-mp/processors/world/ProcessorDoorState.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorDoorState.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_DOOR_STATE)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            packet.Send(true);

--- a/apps/openmw-mp/processors/world/ProcessorObjectDelete.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorObjectDelete.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_OBJECT_DELETE)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());
            
--- a/apps/openmw-mp/processors/world/ProcessorObjectLock.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorObjectLock.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_OBJECT_LOCK)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());
            
--- a/apps/openmw-mp/processors/world/ProcessorObjectPlace.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorObjectPlace.hpp
@ -14,7 +14,7 @@ namespace mwmp
            BPP_INIT(ID_OBJECT_PLACE)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/world/ProcessorObjectScale.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorObjectScale.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_OBJECT_SCALE)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());
            
--- a/apps/openmw-mp/processors/world/ProcessorObjectSpawn.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorObjectSpawn.hpp
@ -14,7 +14,7 @@ namespace mwmp
            BPP_INIT(ID_OBJECT_SPAWN)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());

--- a/apps/openmw-mp/processors/world/ProcessorObjectState.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorObjectState.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_OBJECT_STATE)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());
            
--- a/apps/openmw-mp/processors/world/ProcessorObjectTrap.hpp
+++ b/apps/openmw-mp/processors/world/ProcessorObjectTrap.hpp
@ -13,7 +13,7 @@ namespace mwmp
            BPP_INIT(ID_OBJECT_TRAP)
        }

-        void Do(WorldPacket &packet, std::shared_ptr<Player> player, BaseEvent &event) override
+        void Do(WorldPacket &packet, const std::shared_ptr<Player> &player, BaseEvent &event) override
        {
            LOG_MESSAGE_SIMPLE(Log::LOG_INFO, "Received %s from %s", strPacketID.c_str(), player->npc.mName.c_str());