From cac468498621c4e7461d9fcb0fc52b34c7e5de9a Mon Sep 17 00:00:00 2001 From: David Cernat Date: Thu, 23 Nov 2017 10:07:14 +0200 Subject: [PATCH] [Client] Don't force skill update on cell change Previously, an attempt by the server to simultaneously change a player's cell and skills (as you'd expect when a player file is loaded) led to: 1) The server sending the cell packet first and the skill packet afterwards 2) The player receiving the cell packet and sending their own skill packet as part of the client's forced skill update 3) The player receiving the skill packet from the server 4) The server receiving the skill packet from the player The result was that, if the player then left the server without sending another skill packet, the server's memory retained the skills the player had sent instead of the skills it had sent to the player. This is the first step in a solution to that situation and similar ones. --- apps/openmw/mwmp/LocalPlayer.cpp | 3 --- 1 file changed, 3 deletions(-) diff --git a/apps/openmw/mwmp/LocalPlayer.cpp b/apps/openmw/mwmp/LocalPlayer.cpp index 1dc0a0a2a..fe905cd69 100644 --- a/apps/openmw/mwmp/LocalPlayer.cpp +++ b/apps/openmw/mwmp/LocalPlayer.cpp @@ -393,9 +393,6 @@ void LocalPlayer::updateCell(bool forceUpdate) isChangingRegion = false; - // Also force an update to skills (to send all progress to skill increases) - updateSkills(true); - // Also check if the inventory needs to be updated updateInventory(); }