From e94da61ff03f77897a7a9100864d6c5d165735a0 Mon Sep 17 00:00:00 2001
From: Jordan Ayers <jordan.ayers@gmail.com>
Date: Tue, 5 Nov 2013 19:38:45 -0600
Subject: [PATCH] Chargen cleanup.

Move common gui state pop out of if checks.
Move health update before gui state push (used as input for some windows).
---
 apps/openmw/mwgui/charactercreation.cpp | 43 +++++++++----------------
 1 file changed, 16 insertions(+), 27 deletions(-)

diff --git a/apps/openmw/mwgui/charactercreation.cpp b/apps/openmw/mwgui/charactercreation.cpp
index 816f42e3d..9b742742d 100644
--- a/apps/openmw/mwgui/charactercreation.cpp
+++ b/apps/openmw/mwgui/charactercreation.cpp
@@ -332,24 +332,22 @@ namespace MWGui
             mPickClassDialog = 0;
         }
 
+        updatePlayerHealth();
+
         //TODO This bit gets repeated a few times; wrap it in a function
+        MWBase::Environment::get().getWindowManager()->popGuiMode();
         if (mCreationStage == CSE_ReviewNext)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Review);
         }
         else if (mCreationStage >= CSE_ClassChosen)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Birth);
         }
         else
         {
             mCreationStage = CSE_ClassChosen;
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
         }
-
-        updatePlayerHealth();
     }
 
     void CharacterCreation::onPickClassDialogBack()
@@ -403,20 +401,18 @@ namespace MWGui
             mNameDialog = 0;
         }
 
+        MWBase::Environment::get().getWindowManager()->popGuiMode();
         if (mCreationStage == CSE_ReviewNext)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Review);
         }
         else if (mCreationStage >= CSE_NameChosen)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Race);
         }
         else
         {
             mCreationStage = CSE_NameChosen;
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
         }
     }
 
@@ -462,23 +458,21 @@ namespace MWGui
             mRaceDialog = 0;
         }
 
+        updatePlayerHealth();
+
+        MWBase::Environment::get().getWindowManager()->popGuiMode();
         if (mCreationStage == CSE_ReviewNext)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Review);
         }
         else if (mCreationStage >= CSE_RaceChosen)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Class);
         }
         else
         {
             mCreationStage = CSE_RaceChosen;
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
         }
-
-        updatePlayerHealth();
     }
 
     void CharacterCreation::onBirthSignDialogDone(WindowBase* parWindow)
@@ -492,18 +486,17 @@ namespace MWGui
             mBirthSignDialog = 0;
         }
 
+        updatePlayerHealth();
+
+        MWBase::Environment::get().getWindowManager()->popGuiMode();
         if (mCreationStage >= CSE_BirthSignChosen)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Review);
         }
         else
         {
             mCreationStage = CSE_BirthSignChosen;
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
         }
-
-        updatePlayerHealth();
     }
 
     void CharacterCreation::onBirthSignDialogBack()
@@ -552,23 +545,21 @@ namespace MWGui
             mCreateClassDialog = 0;
         }
 
+        updatePlayerHealth();
+
+        MWBase::Environment::get().getWindowManager()->popGuiMode();
         if (mCreationStage == CSE_ReviewNext)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Review);
         }
         else if (mCreationStage >= CSE_ClassChosen)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Birth);
         }
         else
         {
             mCreationStage = CSE_ClassChosen;
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
         }
-
-        updatePlayerHealth();
     }
 
     void CharacterCreation::onCreateClassDialogBack()
@@ -722,23 +713,21 @@ namespace MWGui
         mPlayerClass = *klass;
         MWBase::Environment::get().getWindowManager()->setPlayerClass(mPlayerClass);
 
+        updatePlayerHealth();
+
+        MWBase::Environment::get().getWindowManager()->popGuiMode();
         if (mCreationStage == CSE_ReviewNext)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Review);
         }
         else if (mCreationStage >= CSE_ClassChosen)
         {
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
             MWBase::Environment::get().getWindowManager()->pushGuiMode(GM_Birth);
         }
         else
         {
             mCreationStage = CSE_ClassChosen;
-            MWBase::Environment::get().getWindowManager()->popGuiMode();
         }
-
-        updatePlayerHealth();
     }
 
     CharacterCreation::~CharacterCreation()