Merge remote-tracking branch 'greye/rc0-17'

apps/openmw/mwbase/world.hpp

@@ -254,7 +254,6 @@ namespace MWBase
             virtual bool toggleVanityMode(bool enable, bool force) = 0;
             virtual void allowVanityMode(bool allow) = 0;
             virtual void togglePlayerLooking(bool enable) = 0;
-            virtual bool isVanityEnabled() = 0;
 
             virtual void renderPlayer() = 0;
     };

apps/openmw/mwrender/player.hpp

@@ -107,10 +107,6 @@ namespace MWRender
         void getSightAngles(float &pitch, float &yaw);
 
         void togglePlayerLooking(bool enable);
-
-        bool isVanityEnabled() {
-            return mVanity.enabled;
-        }
     };
 }
 

apps/openmw/mwrender/renderingmanager.hpp

@@ -68,10 +68,6 @@ class RenderingManager: private RenderingInterface, public Ogre::WindowEventList
         return mPlayer->toggleVanityMode(enable, force);
     }
 
-    bool isVanityEnabled() {
-        return mPlayer->isVanityEnabled();
-    }
-
     void allowVanityMode(bool allow) {
         mPlayer->allowVanityMode(allow);
     }

apps/openmw/mwscript/miscextensions.cpp

@@ -209,6 +209,8 @@ namespace MWScript
 
         class OpToggleVanityMode : public Interpreter::Opcode0
         {
+            static bool sActivate;
+
         public:
         
             virtual void execute(Interpreter::Runtime &runtime)
@@ -219,16 +221,17 @@ namespace MWScript
                 MWBase::World *world =
                     MWBase::Environment::get().getWorld();
 
-                bool value = !world->isVanityEnabled();
+                if (world->toggleVanityMode(sActivate, true)) {
-                if (world->toggleVanityMode(value, true)) {
                     context.report(
-                        (value) ? "Vanity Mode -> On" : "Vanity Mode -> Off"
+                        (sActivate) ? "Vanity Mode -> On" : "Vanity Mode -> Off"
                     );
+                    sActivate = !sActivate;
                 } else {
                     context.report("Vanity Mode -> No");
                 }
             }
         };
+        bool OpToggleVanityMode::sActivate = true;
 
         const int opcodeXBox = 0x200000c;
         const int opcodeOnActivate = 0x200000d;

apps/openmw/mwworld/worldimp.hpp

@@ -298,10 +298,6 @@ namespace MWWorld
             }
 
             virtual void renderPlayer();
-
-            virtual bool isVanityEnabled() {
-                return mRendering->isVanityEnabled();
-            }
     };
 }