zer.ooo/web
1
0
Fork 1
Code Issues Pull requests Releases Wiki Activity

feature/embedded-server-config #1

Manually merged
krageon merged 1 commit from krageon/zer.ooo-web:feature/embedded-server-config into master 2019-08-03 19:43:03 +00:00
Conversation 0 Commits 1 Files changed 1 +6 -3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 4f773c0d2f - Show all commits

9
views/etc/openvpn-client-embedded.conf.twig
View file

@ -22,10 +22,13 @@ cipher AES-256-CBC
comp-lzo
<ca>
{{ ca }}</ca>
{{ ca|trim }}
</ca>
<cert>
{{ cert }}</cert>
{{ cert|trim }}
</cert>
eater commented 2019-08-03 19:19:26 +00:00
Outdated
Review
Copy link

please to end on next line

please to end on next line
krageon commented 2019-08-03 19:35:47 +00:00
Outdated
Review
Copy link

Keys have a return after them. This way it looks exactly as the end user expects when the template is filled. This is to my mind the superior option.

Keys have a return after them. This way it looks *exactly* as the end user expects when the template is filled. This is to my mind the superior option.
eater commented 2019-08-03 19:40:07 +00:00
Outdated
Review
Copy link

I would rather have you use the following in that case

<key>
{{ key|trim }}
</key>
I would rather have you use the following in that case ```twig <key> {{ key|trim }} </key> ```
krageon commented 2019-08-03 19:42:14 +00:00
Outdated
Review
Copy link

Good point, it's fixed

Good point, it's fixed
<key>
{{ key }}</key>
{{ key|trim }}
</key>