Modified sorting, should not crash anymore

apps/launcher/model/datafilesmodel.cpp

@@ -223,36 +223,34 @@ void DataFilesModel::sort(int column, Qt::SortOrder order)
     // TODO: Make this more efficient
     emit layoutAboutToBeChanged();
 
+    QList<EsmFile *> sortedFiles;
 
-    QMap<QString, QString> timestamps;
+    QMultiMap<QString, QString> timestamps;
 
-    QList<EsmFile *>::ConstIterator it;
+    foreach (EsmFile *file, mFiles)
-    QList<EsmFile *>::ConstIterator itEnd = mFiles.constEnd();
+        timestamps.insert(file->modified().toString(Qt::ISODate), file->fileName());
-
-    // Make a list of files sorted by timestamp
-    int i = 0;
-    for (it = mFiles.constBegin(); it != itEnd; ++it) {
-        EsmFile *file = item(i);
-        ++i;
-        timestamps[file->modified().toString(Qt::ISODate)] = file->fileName();
-    }
 
-
-    // Now sort the actual list of files by timestamp
-    i = 0;
     QMapIterator<QString, QString> ti(timestamps);
+
     while (ti.hasNext()) {
         ti.next();
-        i++;
 
         QModelIndex index = indexFromItem(findItem(ti.value()));
 
-        if (index.isValid()) {
+        if (!index.isValid())
-            mFiles.swap(index.row(), i);
+            continue;
-        }
 
+        EsmFile *file = item(index.row());
+
+        if (!file)
+            continue;
+
+        sortedFiles.append(file);
     }
 
+    mFiles.clear();
+    mFiles = sortedFiles;
+
     emit layoutChanged();
 }
 
@@ -301,6 +299,7 @@ void DataFilesModel::addMasters(const QString &path)
 
         } catch(std::runtime_error &e) {
             // An error occurred while reading the .esp
+            qWarning() << "Error reading esp: " << e.what();
             continue;
         }
     }
@@ -361,6 +360,7 @@ void DataFilesModel::addPlugins(const QString &path)
             addFile(file);
         } catch(std::runtime_error &e) {
             // An error occurred while reading the .esp
+            qWarning() << "Error reading esp: " << e.what();
             continue;
         }