Make AI cast self-targeted spells at the ground (bug #5695)

CHANGELOG.md

@@ -67,6 +67,7 @@
     Bug #5656: Sneaking characters block hits while standing
     Bug #5661: Region sounds don't play at the right interval
     Bug #5688: Water shader broken indoors with enable indoor shadows = false
+    Bug #5695: ExplodeSpell for actors doesn't target the ground
     Bug #5703: OpenMW-CS menu system crashing on XFCE
     Feature #390: 3rd person look "over the shoulder"
     Feature #2386: Distant Statics in the form of Object Paging

apps/openmw/mwmechanics/aicast.cpp

@@ -46,9 +46,12 @@ bool MWMechanics::AiCast::execute(const MWWorld::Ptr& actor, MWMechanics::Charac
         {
             return false;
         }
+    }
 
     osg::Vec3f targetPos = target.getRefData().getPosition().asVec3();
-        if (target.getClass().isActor())
+    // If the target of an on-target spell is an actor that is not the caster
+    // the target position must be adjusted so that it's not casted at the actor's feet.
+    if (target != actor && target.getClass().isActor())
     {
         osg::Vec3f halfExtents = MWBase::Environment::get().getWorld()->getHalfExtents(target);
         targetPos.z() += halfExtents.z() * 2 * 0.75f;
@@ -65,7 +68,6 @@ bool MWMechanics::AiCast::execute(const MWWorld::Ptr& actor, MWMechanics::Charac
 
     if (!turned)
         return false;
-    }
 
     // Check if the actor is already casting another spell
     bool isCasting = MWBase::Environment::get().getMechanicsManager()->isCastingSpell(actor);