mirror/openmw
1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-03-04 06:09:40 +00:00
Code Issues Releases Wiki Activity

Merged pull request #1937

Browse source
This commit is contained in:
Marc Zinnschlag 2018-09-27 11:06:21 +02:00
commit 5fa9b32e76
2 changed files with 58 additions and 54 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

42
apps/openmw/mwmechanics/character.cpp
View file

@ -351,19 +351,20 @@ void CharacterController::refreshHitRecoilAnims(CharacterState& idle)
idle = CharState_None; idle = CharState_None;
} }
void CharacterController::refreshJumpAnims(const WeaponInfo* weap, JumpingState jump, CharacterState& idle, bool force) void CharacterController::refreshJumpAnims(const WeaponInfo* weap, JumpingState jump, CharacterState& idle, CharacterState& movement, bool force)
{ {
if(force || jump != mJumpState) if (!force && jump == mJumpState && idle == CharState_None && movement == CharState_None)
{ return;
if (jump != JumpState_None)
idle = CharState_None;
bool startAtLoop = (jump == mJumpState); if (jump != JumpState_None && !(mPtr == MWMechanics::getPlayer() && MWBase::Environment::get().getWorld()->isFirstPerson())) // FIXME
mJumpState = jump; {
idle = CharState_None;
movement = CharState_None;
}
std::string jumpAnimName; std::string jumpAnimName;
MWRender::Animation::BlendMask jumpmask = MWRender::Animation::BlendMask_All; MWRender::Animation::BlendMask jumpmask = MWRender::Animation::BlendMask_All;
if(mJumpState != JumpState_None) if (jump != JumpState_None)
{ {
jumpAnimName = "jump"; jumpAnimName = "jump";
if(weap != sWeaponTypeListEnd) if(weap != sWeaponTypeListEnd)
@ -386,6 +387,11 @@ void CharacterController::refreshJumpAnims(const WeaponInfo* weap, JumpingState
} }
} }
if (!force && jump == mJumpState)
return;
mJumpState = jump;
if (!mCurrentJump.empty()) if (!mCurrentJump.empty())
{ {
mAnimation->disable(mCurrentJump); mAnimation->disable(mCurrentJump);
@ -397,7 +403,7 @@ void CharacterController::refreshJumpAnims(const WeaponInfo* weap, JumpingState
if (mAnimation->hasAnimation(jumpAnimName)) if (mAnimation->hasAnimation(jumpAnimName))
{ {
mAnimation->play(jumpAnimName, Priority_Jump, jumpmask, false, mAnimation->play(jumpAnimName, Priority_Jump, jumpmask, false,
1.0f, (startAtLoop?"loop start":"start"), "stop", 0.0f, ~0ul); 1.0f, "start", "stop", 0.f, ~0ul);
mCurrentJump = jumpAnimName; mCurrentJump = jumpAnimName;
} }
} }
@ -410,7 +416,6 @@ void CharacterController::refreshJumpAnims(const WeaponInfo* weap, JumpingState
mCurrentJump = jumpAnimName; mCurrentJump = jumpAnimName;
} }
} }
}
} }
void CharacterController::refreshMovementAnims(const WeaponInfo* weap, CharacterState movement, CharacterState& idle, bool force) void CharacterController::refreshMovementAnims(const WeaponInfo* weap, CharacterState movement, CharacterState& idle, bool force)
@ -494,10 +499,9 @@ void CharacterController::refreshMovementAnims(const WeaponInfo* weap, Character
} }
// If we're playing the same animation, start it from the point it ended // If we're playing the same animation, start it from the point it ended
bool sameAnim = (movementAnimName == mCurrentMovement); float startpoint = 0.f;
float startPoint = 0.f; if (!mCurrentMovement.empty() && movementAnimName == mCurrentMovement)
if (sameAnim) mAnimation->getInfo(mCurrentMovement, &startpoint);
mAnimation->getInfo(mCurrentMovement, &startPoint);
mMovementAnimationControlled = true; mMovementAnimationControlled = true;
@ -546,7 +550,7 @@ void CharacterController::refreshMovementAnims(const WeaponInfo* weap, Character
} }
mAnimation->play(mCurrentMovement, Priority_Movement, movemask, false, mAnimation->play(mCurrentMovement, Priority_Movement, movemask, false,
1.f, (!sameAnim ? "start" : "loop start"), "stop", startPoint, ~0ul, true); 1.f, "start", "stop", startpoint, ~0ul, true);
} }
} }
} }
@ -626,7 +630,7 @@ void CharacterController::refreshCurrentAnims(CharacterState idle, CharacterStat
if (!mPtr.getClass().hasInventoryStore(mPtr)) if (!mPtr.getClass().hasInventoryStore(mPtr))
weap = sWeaponTypeListEnd; weap = sWeaponTypeListEnd;
refreshJumpAnims(weap, jump, idle, force); refreshJumpAnims(weap, jump, idle, movement, force);
refreshMovementAnims(weap, movement, idle, force); refreshMovementAnims(weap, movement, idle, force);
// idle handled last as it can depend on the other states // idle handled last as it can depend on the other states
@ -2164,12 +2168,12 @@ void CharacterController::update(float duration)
if(mAnimQueue.empty() || inwater || sneak) if(mAnimQueue.empty() || inwater || sneak)
{ {
// Note: turning animations should not interrupt idle ones // Note: turning animations should not interrupt idle ones
if (inwater) if (movestate != CharState_None && !isTurning())
idlestate = CharState_None;
else if (inwater)
idlestate = CharState_IdleSwim; idlestate = CharState_IdleSwim;
else if (sneak && !inJump) else if (sneak && !inJump)
idlestate = CharState_IdleSneak; idlestate = CharState_IdleSneak;
else if (movestate != CharState_None && !isTurning())
idlestate = CharState_None;
else else
idlestate = CharState_Idle; idlestate = CharState_Idle;
} }

2
apps/openmw/mwmechanics/character.hpp
View file

@ -214,7 +214,7 @@ class CharacterController : public MWRender::Animation::TextKeyListener
void refreshCurrentAnims(CharacterState idle, CharacterState movement, JumpingState jump, bool force=false); void refreshCurrentAnims(CharacterState idle, CharacterState movement, JumpingState jump, bool force=false);
void refreshHitRecoilAnims(CharacterState& idle); void refreshHitRecoilAnims(CharacterState& idle);
void refreshJumpAnims(const WeaponInfo* weap, JumpingState jump, CharacterState& idle, bool force=false); void refreshJumpAnims(const WeaponInfo* weap, JumpingState jump, CharacterState& idle, CharacterState& movement, bool force=false);
void refreshMovementAnims(const WeaponInfo* weap, CharacterState movement, CharacterState& idle, bool force=false); void refreshMovementAnims(const WeaponInfo* weap, CharacterState movement, CharacterState& idle, bool force=false);
void refreshIdleAnims(const WeaponInfo* weap, CharacterState idle, bool force=false); void refreshIdleAnims(const WeaponInfo* weap, CharacterState idle, bool force=false);