Commit Graph

34 Commits (7b064920dbc1766a28279b72379b7f6383f88a4f)

Author SHA1 Message Date
elsid 0601d7213e
Remove ESM::RefId::sEmpty
This variable is only required to return empty RefId as const reference. There
is no point in doing so for a type cheap to copy.
2 years ago
florent.teppe 65cdd489fb create a specific esm reader function for RefID to avoid allocation for string and then again for RefId
Fixed some types

removed useless header

applied clang format

fixed compile tests

fixed clang tidy, and closer to logic before this MR

Removed hardcoded refids

unless there is a returned value we don't use static RefIds
can use == between RefId and hardcoded string

Fix clang format

Fixed a few instances where std::string was used, when only const std::string& was needed

removed unused variable
2 years ago
florent.teppe 874ff88288 In the interpretter, the id is no longer passed by vallue, but as a const reference instead.
In getMembersLocal(, a reference to a reference wrapper is used, because the id can change, bu all we need to do is change a pointer.No need to change the value
2 years ago
fteppe 125b21de20 Initial commit: In ESM structures, replace the string members that are RefIds to other records, to a new strong type
The strong type is actually just a string underneath, but this will help in the future to have a distinction so it's easier to search and replace when we use an integer ID

Slowly going through all the changes to make, still hundreds of errors

a lot of functions/structures use std::string or stringview to designate an ID. So it takes time

Continues slowly replacing ids. There are technically more and more compilation errors

I have good hope that there is a point where the amount of errors will dramatically go down as all the main functions use the ESM::RefId type

Continue moving forward, changes to the stores

slowly moving along

Starting to see the fruit of those changes.

still many many error, but more and more Irun into a situation where a function is sandwiched between two functions that use the RefId type.

More replacements. Things are starting to get easier

I can see more and more often the issue is that the function is awaiting a RefId, but is given a string
there is less need to go down functions and to fix a long list of them.

Still moving forward, and for the first time error count is going down!

Good pace, not sure about topics though, mId and mName are actually the same thing and are used interchangeably

Cells are back to using string for the name, haven't fixed everything yet. Many other changes

Under the bar of 400 compilation errors.

more good progress <100 compile errors!

More progress

Game settings store can use string for find, it was a bit absurd how every use of it required to create refId from string

some more progress on other fronts

Mostly game settings clean

one error opened a lot of other errors. Down to 18, but more will prbably appear

only link errors left??

Fixed link errors

OpenMW compiles, and launches, with some issues, but still!
2 years ago
clang-format-bot ddb0522bbf
Apply clang-format to code base 2 years ago
Evil Eye 0df45a90b3 Use string_view in the remaining Class methods and push string_views closer to the MyGUI boundary 2 years ago
Evil Eye 51938f9ef7 Use string_view in Interpreter::Context 2 years ago
Evil Eye e79f803402 Change includes 3 years ago
Evil Eye c6ca0e78c9 Make getStringLiteral return a string_view 3 years ago
Evil Eye 67c8d73fe0 Allow scripts to fail per target 4 years ago
Evil Eye 3875b837bc make MenuMode, Random, GetSecondsPassed regular functions 5 years ago
Evil Eye f0e2ee45fa reuse ImplicitRef and ExplicitRef for enable, disable, getdisabled, startscript; move scriptrunning and stopscript 5 years ago
unknown 3b4782959e Allow targeting non-unique actors with StartScript (bug #2311) 5 years ago
Andrei Kortunov 2961f0d810 Allow to use the %Name for creatures (bug #4644) 6 years ago
Marc Zinnschlag 27c84d6cb7 the reference for a targeted script is now determined when needed instead of at the start of the script execution 11 years ago
Marc Zinnschlag 75ab8de3d2 added opcode for running scripts with explicit references (targeted scripts) 11 years ago
Marc Zinnschlag 3b990795c4 added access to remote access of local variables of global scripts 11 years ago
Tom Mason 8ac8fdff47 implemented all text defines except a few for keybindings that don't exist yet 12 years ago
Tom Mason f2c6907244 Added in text escape sequences for dialogue, messageboxes and books. builtins are placeholders, global variables work 12 years ago
Marc Zinnschlag 72fca40090 Issue #181: member variable access in interpreter context 13 years ago
Marc Zinnschlag 125319c441 splitting off console output from messageBox channel 14 years ago
Marc Zinnschlag 69e607e140 implemented getdistance with explicit references 15 years ago
Marc Zinnschlag d4ac3b506e implemented enable, disable and getdisabled with explicit references 15 years ago
Marc Zinnschlag 592fa84e2d added Enable, Disable, GetDisabled 15 years ago
Marc Zinnschlag 6b3ff8a516 constness fixes 15 years ago
Marc Zinnschlag 9d73718ec1 added GetSecondsPassed 15 years ago
Marc Zinnschlag 34b824cb70 implemented GetDistance function 15 years ago
Marc Zinnschlag a61b2c39f0 added scriptrunning/startscript/stopscript; sorted out more case problems 15 years ago
Marc Zinnschlag f9c1548f80 added menumode script function; added global variable handling in compiler and interpreter (openmw context still ignores global variables) 15 years ago
Marc Zinnschlag c12752df4d added sound manager skeleton and sound script functions 15 years ago
Marc Zinnschlag 474b412b47 implemented local script execution 15 years ago
Marc Zinnschlag fac8fb8fcb added return and messagebox statements (messagebox does neither formating nor buttons yet) 15 years ago
Marc Zinnschlag 770eb14d95 added context for standalone interpreter 15 years ago
Marc Zinnschlag 487a70388f added interpreter framework 15 years ago