1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-01-16 20:29:57 +00:00
openmw/apps
Bo Svensson 4657c655b1 refactors parentFileIndices (#3211)
This PR aims to start addressing `ESM` design issues that have silenced errors we incorporated into groundcover `ESM` loading approaches.

- We move the resolution of `parentFileIndices` from `ESMStore` to `ESMReader` as suggested in a `TODO` comment.
- We improve a highly misleading comment which downplayed the significance of `parentFileIndices`.
- We document important preconditions.
- We move a user facing error message to the highest level and improve its context.
- We remove an inappropriate `setGlobalReaderList` method. We now pass this reader list into the method that requires it.
- We remove a thoroughly pointless optimisation of `Store<ESM::LandTexture>`'s construction that has unnecessarily depended on `getGlobalReaderList`.

There should be no functional changes for `master`, but this PR should remove an issue blocking PR #3208.
2021-11-03 11:07:28 +01:00
..
benchmarks Store heightfields as array of heights instead of triangles 2021-07-26 00:22:21 +02:00
bsatool cleans up BSAFile (#3177) 2021-10-14 14:46:44 +02:00
esmtool Do not use union to access FIXED_STRING<4> as int 2021-10-17 17:16:21 +02:00
essimporter Do not use union to access FIXED_STRING<4> as int 2021-10-17 17:16:21 +02:00
launcher Support *.omwscripts in openmw-launcher 2021-10-29 20:09:47 +02:00
mwiniimporter Using auto keyword in most apps 2021-05-18 19:20:59 -05:00
niftest Use recurse subdirectory iterator to iterate over the VFS without exposing internal details 2021-09-14 18:09:54 +02:00
opencs Support *.omwscripts in openmw-launcher 2021-10-29 20:09:47 +02:00
openmw refactors parentFileIndices (#3211) 2021-11-03 11:07:28 +01:00
openmw_test_suite refactors parentFileIndices (#3211) 2021-11-03 11:07:28 +01:00
wizard Remove 'no relevant classes' moc warning 2021-09-14 11:20:18 +02:00
doc.hpp