mirror of https://github.com/OpenMW/openmw.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
4657c655b1
This PR aims to start addressing `ESM` design issues that have silenced errors we incorporated into groundcover `ESM` loading approaches. - We move the resolution of `parentFileIndices` from `ESMStore` to `ESMReader` as suggested in a `TODO` comment. - We improve a highly misleading comment which downplayed the significance of `parentFileIndices`. - We document important preconditions. - We move a user facing error message to the highest level and improve its context. - We remove an inappropriate `setGlobalReaderList` method. We now pass this reader list into the method that requires it. - We remove a thoroughly pointless optimisation of `Store<ESM::LandTexture>`'s construction that has unnecessarily depended on `getGlobalReaderList`. There should be no functional changes for `master`, but this PR should remove an issue blocking PR #3208. |
3 years ago | |
|---|---|---|
| .. | ||
| bsa | 3 years ago | |
| bullethelpers | 3 years ago | |
| compiler | 3 years ago | |
| config | 4 years ago | |
| contentselector | 3 years ago | |
| crashcatcher | 4 years ago | |
| debug | 4 years ago | |
| detournavigator | 3 years ago | |
| esm | 3 years ago | |
| esmloader | 3 years ago | |
| esmterrain | 4 years ago | |
| fallback | 4 years ago | |
| files | 3 years ago | |
| fontloader | 3 years ago | |
| interpreter | 3 years ago | |
| loadinglistener | 3 years ago | |
| lua | 3 years ago | |
| misc | 3 years ago | |
| myguiplatform | 3 years ago | |
| nif | 3 years ago | |
| nifbullet | 3 years ago | |
| nifosg | 3 years ago | |
| process | 6 years ago | |
| queries | 4 years ago | |
| resource | 3 years ago | |
| sceneutil | 3 years ago | |
| sdlutil | 3 years ago | |
| settings | 4 years ago | |
| shader | 3 years ago | |
| sqlite3 | 3 years ago | |
| terrain | 3 years ago | |
| to_utf8 | 4 years ago | |
| translation | 6 years ago | |
| version | 8 years ago | |
| vfs | 3 years ago | |
| widgets | 3 years ago | |
| CMakeLists.txt | 3 years ago | |
| doc.hpp | ||