1
0
Fork 0
mirror of https://github.com/OpenMW/openmw.git synced 2025-02-21 12:39:41 +00:00
openmw/components
jvoisin 534e20cf3a Replace another assert with a throw
It fixes the following crash:

```nasm
[----------------------------------registers-----------------------------------]
RAX: 0xffffffffffffffe4
RBX: 0x7fffffffbd88 --> 0x0
RCX: 0x555555861f01 --> 0xd6000055555582fa
RDX: 0x1
RSI: 0x0
RDI: 0xff
RBP: 0x2e94
RSP: 0x7fffffff9bb0 --> 0x0
RIP: 0x55555574e286 (<_ZN4ESM44Cell4loadERNS_6ReaderE+182>:	mov    eax,DWORD PTR [rax+0xc])
R8 : 0x0
R9 : 0x555555836bd0 --> 0x555555861f90 --> 0x100000000000000
R10: 0xffffffff
R11: 0x0
R12: 0x7fffffffbd88 --> 0x0
R13: 0x7fffffffbd30 --> 0x7fffffffbd28 --> 0xff0001
R14: 0x7fffffff9da0 --> 0x10fc
R15: 0x7fffffff9ea8 --> 0x7fffffff9eb8 --> 0x0
EFLAGS: 0x10206 (carry PARITY adjust zero sign trap INTERRUPT direction overflow)
[-------------------------------------code-------------------------------------]
   0x55555574e27c <_ZN4ESM44Cell4loadERNS_6ReaderE+172>:	mov    rdi,r12
   0x55555574e27f <_ZN4ESM44Cell4loadERNS_6ReaderE+175>:	xor    esi,esi
   0x55555574e281 <_ZN4ESM44Cell4loadERNS_6ReaderE+177>:	call   0x5555557edfb0 <_ZNK4ESM46Reader3grpEm>
=> 0x55555574e286 <_ZN4ESM44Cell4loadERNS_6ReaderE+182>:	mov    eax,DWORD PTR [rax+0xc]
   0x55555574e289 <_ZN4ESM44Cell4loadERNS_6ReaderE+185>:	cmp    eax,0xff
   0x55555574e28e <_ZN4ESM44Cell4loadERNS_6ReaderE+190>:	ja     0x55555574e314 <_ZN4ESM44Cell4loadERNS_6ReaderE+324>
   0x55555574e294 <_ZN4ESM44Cell4loadERNS_6ReaderE+196>:	cmp    al,0x5
   0x55555574e296 <_ZN4ESM44Cell4loadERNS_6ReaderE+198>:	jne    0x55555574e314 <_ZN4ESM44Cell4loadERNS_6ReaderE+324>
[------------------------------------stack-------------------------------------]
0000| 0x7fffffff9bb0 --> 0x0
0008| 0x7fffffff9bb8 --> 0x0
0016| 0x7fffffff9bc0 --> 0x0
0024| 0x7fffffff9bc8 --> 0x0
0032| 0x7fffffff9bd0 --> 0x0
0040| 0x7fffffff9bd8 --> 0x0
0048| 0x7fffffff9be0 --> 0x0
0056| 0x7fffffff9be8 --> 0x0
[------------------------------------------------------------------------------]
Legend: code, data, rodata, value
Stopped reason: SIGSEGV
0x000055555574e286 in ESM4::Cell::load (this=0x7fffffff9da0, reader=...) at /home/jvoisin/dev/openmw/openmw/components/esm4/loadcell.cpp:68
68	   if (reader.grp().type == ESM4::Grp_ExteriorSubCell && reader.grp().label.grid[1] == 0
gdb-peda$ bt
    this=<optimized out>, reader=...) at /home/jvoisin/dev/openmw/openmw/apps/esmtool/tes4.cpp:547
    recordInvocable=...) at /home/jvoisin/dev/openmw/openmw/./components/esm4/readerutils.hpp:31
    at /home/jvoisin/dev/openmw/openmw/./components/esm4/readerutils.hpp:23
    at ../csu/libc-start.c:381
```
2023-05-21 20:07:52 +02:00
..
bsa Fix code format 2023-04-18 20:23:03 +02:00
bullethelpers Remove unused includes 2022-10-09 16:44:18 +02:00
compiler Move from std::atoi to std::from_char 2023-03-18 09:30:48 +00:00
config remove remaining boost::filesystem cruft 2023-04-25 16:15:04 +02:00
contentselector Display directories that contains omwscripts. 2023-03-30 21:32:01 +02:00
crashcatcher Maybe fix Windows freeze catcher 2023-03-04 00:28:22 +00:00
debug Move from std::atoi to std::from_char 2023-03-18 09:30:48 +00:00
detournavigator Count navmeshdb reads for each reading job 2023-05-17 10:08:34 +02:00
esm ESM::ExteriorCellIndex => ESM::ExteriorCellLocation 2023-05-12 22:05:55 +02:00
esm3 removed sDefaultWorldspace, only sDefaultWorldspaceId now. 2023-05-12 22:05:53 +02:00
esm3terrain Apply clang-format to code base 2022-09-22 21:35:26 +03:00
esm4 Replace another assert with a throw 2023-05-21 20:07:52 +02:00
esmloader Gets rid of most ESM::CellId 2023-04-03 14:16:05 +02:00
fallback Move from std::atoi to std::from_char 2023-03-18 09:30:48 +00:00
files Merge branch 'remove_cruft' into 'master' 2023-04-25 16:06:55 +00:00
fontloader Remove unused includes 2022-10-09 16:44:18 +02:00
fx Dehardcode non-game-specific localization GMSTs; Update l10n files. 2023-03-26 13:43:44 +02:00
interpreter Remove ESM::RefId::sEmpty 2023-04-26 21:15:16 +02:00
l10n Dehardcode non-game-specific localization GMSTs; Update l10n files. 2023-03-26 13:43:44 +02:00
loadinglistener Apply clang-format to code base 2022-09-22 21:35:26 +03:00
lua Expose game object's bounding box in lua api 2023-05-18 11:10:10 -07:00
lua_ui Fix bug in LuaUi::Element::destroy() that sometimes leads to an infinite loop on UI cleanup 2023-05-20 02:34:23 +02:00
misc Increase ESM4 active grid 2023-05-18 00:38:41 +02:00
myguiplatform shade refactor 2023-02-25 11:03:39 -08:00
navmeshtool Stop updating navmeshtool progress on first bad message 2023-01-27 19:10:53 +01:00
nif Drop NIF root node transformation for Skyrim models the same way as for Morrowind models. 2023-05-18 02:10:39 +02:00
nifbullet Unify collision shape transformations 2023-03-10 00:12:12 +03:00
nifosg fix shader compilation 2023-02-26 14:31:53 -08:00
platform Minor header cleanup 2023-04-30 16:26:03 +02:00
process Apply clang-format to code base 2022-09-22 21:35:26 +03:00
resource Report raw navmesh cache counters 2023-05-17 10:08:33 +02:00
sceneutil Expose game object's bounding box in lua api 2023-05-18 11:10:10 -07:00
sdlutil Minor header cleanup 2023-04-30 16:26:03 +02:00
serialization Apply clang-format to code base 2022-09-22 21:35:26 +03:00
settings Add settings index to provide lookup by category and name 2023-05-03 22:11:44 +02:00
shader Move from std::atoi to std::from_char 2023-03-18 09:30:48 +00:00
sqlite3 Minor header cleanup 2023-04-30 16:26:03 +02:00
std140 Apply clang-format to code base 2022-09-22 21:35:26 +03:00
stereo [Multiview] Fix transparent pass and vertex shader 2023-04-01 20:27:07 +00:00
terrain Minor header cleanup 2023-04-30 16:26:03 +02:00
to_utf8 Applies review advice. 2023-01-04 12:22:16 +01:00
translation Apply clang-format to code base 2022-09-22 21:35:26 +03:00
version Apply clang-format to code base 2022-09-22 21:35:26 +03:00
vfs fixed some typos and spelling errors 2023-05-09 20:07:08 -04:00
widgets Move from std::atoi to std::from_char 2023-03-18 09:30:48 +00:00
CMakeLists.txt Expose game object's bounding box in lua api 2023-05-18 11:10:10 -07:00
doc.hpp second set of additional doxygen comments 2010-09-25 20:15:05 +02:00
windows.hpp Fix build on Windows 2022-04-25 00:25:46 +02:00