You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openmw/apps
elsid a0cfcc50a2
Fix dangling pointer access on clicking save in the main menu
getSignature() returns an object which means expression like:
className = it->getSignature().mPlayerClassName;
assigns a temporary object to className that does not outlive the statement.
Having className a string view such code leads to a dangling pointer.

Return a reference from getSignature to save on redundant copying.

Change getSignature implementation to make it visible that it finds a maximum
element.

Do not call getSignature multiple times when possible to avoid seaching for the
same max element multiple times.
2 years ago
..
benchmarks Use version instead of generation and revision for recast mesh 2 years ago
bsatool Use raw string literals to format command usage messages 2 years ago
bulletobjecttool Avoid chained operator() calls to prevent formatting issues 2 years ago
esmtool Dump NIFZ and KFFZ sub records by esmtool 2 years ago
essimporter Use raw string literals to format command usage messages 2 years ago
launcher Do not wrap emit expresison with parenthesis 2 years ago
mwiniimporter Avoid chained operator() calls to prevent formatting issues 2 years ago
navmeshtool Avoid chained operator() calls to prevent formatting issues 2 years ago
niftest Use raw string literals to format command usage messages 2 years ago
opencs Add comma to the last array element to prevent putting multiple elements on a single line 2 years ago
openmw Fix dangling pointer access on clicking save in the main menu 2 years ago
openmw_test_suite Add comments to prevent line splitting on formatting 2 years ago
wizard Added dedicated functions for conversions between QString and std::filesystem::path. 2 years ago
doc.hpp