You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
openmw-tes3mp/apps/openmw/mwscript
tri4ng1e d4d1703bcf
Some PVS-Studio and cppcheck fixes
cppcheck:
[apps/esmtool/record.cpp:697]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1126]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/esmtool/record.cpp:1138]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[apps/niftest/niftest.cpp:36]: (performance) Function parameter 'filename' should be passed by reference.
[apps/niftest/niftest.cpp:41]: (performance) Function parameter 'filename' should be passed by reference.
[apps/opencs/model/prefs/boolsetting.cpp:25]: (warning) Possible leak in public function. The pointer 'mWidget' is not deallocated before it is allocated.
[apps/opencs/model/prefs/shortcuteventhandler.cpp:52]: (warning) Return value of std::remove() ignored. Elements remain in container.
[apps/openmw/mwstate/quicksavemanager.cpp:5]: (performance) Variable 'mSaveName' is assigned in constructor body. Consider performing initialization in initialization list.

PVS-Studio:
apps/opencs/model/filter/parser.cpp  582  warn  V560 A part of conditional expression is always true: allowPredefined.
apps/opencs/view/world/referencecreator.cpp  67  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/world/referencecreator.cpp  74  warn  V547 Expression '!errors.empty()' is always false.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !completed.
apps/opencs/view/doc/loader.cpp  170  warn  V560 A part of conditional expression is always true: !error.empty().
apps/opencs/model/tools/pathgridcheck.cpp  32  err  V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 32, 34.
apps/opencs/model/world/refidadapterimp.cpp  1376  err  V547 Expression 'subColIndex < 3' is always true.

apps/openmw/mwgui/widgets.hpp  318  warn  V703 It is odd that the 'mEnableRepeat' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:318, MyGUI_ScrollBar.h:179.
apps/openmw/mwgui/widgets.hpp  319  warn  V703 It is odd that the 'mRepeatTriggerTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:319, MyGUI_ScrollBar.h:180.
apps/openmw/mwgui/widgets.hpp  320  warn  V703 It is odd that the 'mRepeatStepTime' field in derived class 'MWScrollBar' overwrites field in base class 'ScrollBar'. Check lines: widgets.hpp:320, MyGUI_ScrollBar.h:181
apps/openmw/mwmechanics/actors.cpp  1425  warn  V547 Expression '!detected' is always true.
apps/openmw/mwmechanics/character.cpp  2155  err  V547 Expression 'mode == 0' is always true.
apps/openmw/mwmechanics/character.cpp  1192  warn  V592 The expression was enclosed by parentheses twice: ((expression)). One pair of parentheses is unnecessary or misprint is present.
apps/openmw/mwmechanics/character.cpp  521  warn  V560 A part of conditional expression is always true: (idle == mIdleState).
apps/openmw/mwmechanics/pathfinding.cpp  317  err  V547 Expression 'mPath.size() >= 2' is always true.
apps/openmw/mwscript/interpretercontext.cpp  409  warn  V560 A part of conditional expression is always false: rank > 9.
apps/openmw/mwgui/windowbase.cpp  28  warn  V560 A part of conditional expression is always true: !visible.
apps/openmw/mwgui/journalwindow.cpp  561  warn  V547 Expression '!mAllQuests' is always false.
apps/openmw/mwgui/referenceinterface.cpp  18  warn  V571 Recurring check. The '!mPtr.isEmpty()' condition was already verified in line 16.
apps/openmw/mwworld/scene.cpp  463  warn  V547 Expression 'adjustPlayerPos' is always true.
apps/openmw/mwworld/worldimp.cpp  409  err  V766 An item with the same key '"sCompanionShare"' has already been added.
apps/openmw/mwworld/cellstore.cpp  691  warn  V519 The 'state.mWaterLevel' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 689, 691.
apps/openmw/mwworld/weather.cpp  1125  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1123, 1125.
apps/openmw/mwworld/weather.cpp  1137  warn  V519 The 'mResult.mParticleEffect' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 1135, 1137.

apps/wizard/unshield/unshieldworker.cpp  475  warn  V728 An excessive check can be simplified. The '(A && B) || (!A && !B)' expression is equivalent to the 'bool(A) == bool(B)' expression.
apps/wizard/installationpage.cpp  163  warn  V735 Possibly an incorrect HTML. The "</p" closing tag was encountered, while the "</span" tag was expected.

components/fontloader/fontloader.cpp  427  err  V547 Expression 'i == 1' is always true.
components/nifosg/nifloader.cpp  282  warn  V519 The 'created' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 278, 282.
components/esm/loadregn.cpp  119  err  V586 The 'clear' function is called twice for deallocation of the same resource. Check lines: 112, 119.
components/esm/cellref.cpp  178  warn  V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 175, 178.
components/esmterrain/storage.cpp  235  warn  V560 A part of conditional expression is always true: colStart == 0.
components/esmterrain/storage.cpp  237  warn  V560 A part of conditional expression is always true: rowStart == 0.
7 years ago
..
docs Add explicit variant of 'OnActivate' 7 years ago
aiextensions.cpp Allow to use GetDetected without a reference (bug #3110) 7 years ago
aiextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
animationextensions.cpp Add enabled check to animation script commands 8 years ago
animationextensions.hpp added animation-related script instructions 13 years ago
cellextensions.cpp Use ActionTeleport in COE/COC commands 8 years ago
cellextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
compilercontext.cpp fixed for compiler not recognising script names in some situations 9 years ago
compilercontext.hpp Fixed more spelling mistakes 8 years ago
consoleextensions.cpp Remove empty line at the beginning of files 10 years ago
consoleextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
containerextensions.cpp Unequip all items from dead corpse when take all items (bug #4095) 7 years ago
containerextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
controlextensions.cpp Check animation state for GetPCRunning and GetPCSneaking 7 years ago
controlextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
dialogueextensions.cpp Refactor dialogue GUI to talk to the dialogue manager, not the other way around and not both ways. 7 years ago
dialogueextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
extensions.cpp Remove empty line at the beginning of files 10 years ago
extensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
globalscripts.cpp make sure local variables are loaded when trying to access them from outside of a script (Fixes #2659) 9 years ago
globalscripts.hpp fixed warning C4099: 10 years ago
guiextensions.cpp Remove redundant RestBed gui mode 7 years ago
guiextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
interpretercontext.cpp Some PVS-Studio and cppcheck fixes 7 years ago
interpretercontext.hpp purge all instances of <boost/shared_ptr.hpp>, clean up unused headers 8 years ago
locals.cpp Fix char -> int, fix shadowing warning 8 years ago
locals.hpp Implement 'Show' script instruction 9 years ago
miscextensions.cpp Unstack soulgem, added via AddSoulGem console command (bug #4351) 7 years ago
miscextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
ref.cpp Remove some including of mwbase/world.hpp 10 years ago
ref.hpp Remove some including of mwbase/world.hpp 10 years ago
scriptmanagerimp.cpp More consistent wording of errors/warnings 8 years ago
scriptmanagerimp.hpp Always print context for script warnings to remove the need for verbose option 8 years ago
skyextensions.cpp Fixes for building in MSVC 8 years ago
skyextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
soundextensions.cpp Make the PlayMode and PlayType enums scoped 7 years ago
soundextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
statsextensions.cpp Take in account elemental shields for GetResist and SetResist script commands (bug #4093) 7 years ago
statsextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago
transformationextensions.cpp Do not skip weather transitions from SetPos script command (bug #3603) 7 years ago
transformationextensions.hpp fix -Wnewline-eof warnings 10 years ago
userextensions.cpp Remove empty line at the beginning of files 10 years ago
userextensions.hpp initial move of script opcodes and registerExtensions functions to components/compiler 12 years ago